Patch Detail
Show a patch.
GET /api/1.1/patches/13926/?format=api
{ "id": 13926, "url": "https://patchwork.libcamera.org/api/1.1/patches/13926/?format=api", "web_url": "https://patchwork.libcamera.org/patch/13926/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210924150339.18835-1-laurent.pinchart@ideasonboard.com>", "date": "2021-09-24T15:03:39", "name": "[libcamera-devel] libcamera: camera_manager: Fix utils.h #include location", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "e5b6e3f1c2faa414a332423669db3e57c9733a95", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/13926/mbox/", "series": [ { "id": 2565, "url": "https://patchwork.libcamera.org/api/1.1/series/2565/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2565", "date": "2021-09-24T15:03:39", "name": "[libcamera-devel] libcamera: camera_manager: Fix utils.h #include location", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2565/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/13926/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/13926/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6B7A8BDC71\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 24 Sep 2021 15:03:50 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9708C6918C;\n\tFri, 24 Sep 2021 17:03:49 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AAD85687DD\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 24 Sep 2021 17:03:47 +0200 (CEST)", "from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 25F0F45E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 24 Sep 2021 17:03:47 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Ws3/Nu57\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1632495827;\n\tbh=O3pzkOE2POVngwFnxsiXyTRlBKT9EdktddI0i0DHJ+k=;\n\th=From:To:Subject:Date:From;\n\tb=Ws3/Nu57V5IxYQvZIAFHEVjXXH2g5N609s13N1qAyneLCh8R43Ql4gLcyNyqaYJOX\n\tvXEG8/KXQRS5gwF3bgVpfWYy8ZIJ7AjHMbQ0bAbIeYpFJNsqkhLsL1K7rXS8pgihG0\n\tQY4mc8r9L79Csbj8gkEMH4xLCYmbnF3S2k6GT5+c=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 24 Sep 2021 18:03:39 +0300", "Message-Id": "<20210924150339.18835-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.32.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] libcamera: camera_manager: Fix utils.h\n\t#include location", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The utils.h header #include is separate from the rest of the group for\nno reason. Move it to where it should be.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/camera_manager.cpp | 3 +--\n 1 file changed, 1 insertion(+), 2 deletions(-)\n\n\nbase-commit: 40f5fddca7f774944a53f58eeaebc4db79c373d8", "diff": "diff --git a/src/libcamera/camera_manager.cpp b/src/libcamera/camera_manager.cpp\nindex e7d026ae94c8..43bfa2b72a51 100644\n--- a/src/libcamera/camera_manager.cpp\n+++ b/src/libcamera/camera_manager.cpp\n@@ -12,10 +12,9 @@\n \n #include <libcamera/camera.h>\n \n-#include <libcamera/base/utils.h>\n-\n #include <libcamera/base/log.h>\n #include <libcamera/base/thread.h>\n+#include <libcamera/base/utils.h>\n \n #include \"libcamera/internal/device_enumerator.h\"\n #include \"libcamera/internal/ipa_manager.h\"\n", "prefixes": [ "libcamera-devel" ] }