Patch Detail
Show a patch.
GET /api/1.1/patches/13911/?format=api
{ "id": 13911, "url": "https://patchwork.libcamera.org/api/1.1/patches/13911/?format=api", "web_url": "https://patchwork.libcamera.org/patch/13911/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210923120524.76740-1-jeanmichel.hautbois@ideasonboard.com>", "date": "2021-09-23T12:05:24", "name": "[libcamera-devel] fixup! ipa: ipu3: Change limits and split loops in calculateBdsGrid()", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "8426f3ccb46bee484a8441c47e57a7a27c09e500", "submitter": { "id": 75, "url": "https://patchwork.libcamera.org/api/1.1/people/75/?format=api", "name": "Jean-Michel Hautbois", "email": "jeanmichel.hautbois@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/13911/mbox/", "series": [ { "id": 2554, "url": "https://patchwork.libcamera.org/api/1.1/series/2554/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2554", "date": "2021-09-23T12:05:24", "name": "[libcamera-devel] fixup! ipa: ipu3: Change limits and split loops in calculateBdsGrid()", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2554/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/13911/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/13911/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B8863BDC71\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 23 Sep 2021 12:05:34 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 28C6F6918C;\n\tThu, 23 Sep 2021 14:05:34 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6DF2769189\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 23 Sep 2021 14:05:32 +0200 (CEST)", "from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:392e:dcd2:2bf6:d61c])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E860145E;\n\tThu, 23 Sep 2021 14:05:31 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Nhaqw1S8\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1632398732;\n\tbh=d7RWYy6bxEug4X//hGDdi5qyv0kuX2wHbTCBnUWrDwk=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=Nhaqw1S8oT2GzBl+F5to2d8BudaMm4327mmy14KsrIPGo6Dp4VL/Y+0R6dc76hz0X\n\tvGamlr0e7+fDGttB2Qlis0nWssNsb5+hA8SqVbWyNKTiFzA/vpHQaeH0R5JdNjrDAq\n\ttIemTo57gkDTi/JcOGKwYuqTBUte4YFUUYADzyn4=", "From": "Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 23 Sep 2021 14:05:24 +0200", "Message-Id": "<20210923120524.76740-1-jeanmichel.hautbois@ideasonboard.com>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20210923081625.60276-7-jeanmichel.hautbois@ideasonboard.com>", "References": "<20210923081625.60276-7-jeanmichel.hautbois@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] fixup! ipa: ipu3: Change limits and split\n\tloops in calculateBdsGrid()", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Hi JM,\n\nI think you should take this fixup for your v2 ;-).\n\n---\n src/ipa/ipu3/ipu3.cpp | 1 +\n 1 file changed, 1 insertion(+)", "diff": "diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\nindex 06d9bcb8..3868a3a5 100644\n--- a/src/ipa/ipu3/ipu3.cpp\n+++ b/src/ipa/ipu3/ipu3.cpp\n@@ -321,6 +321,7 @@ void IPAIPU3::calculateBdsGrid(const Size &bdsOutputSize)\n \t\tbestLog2.width = shift;\n \t}\n \n+\tminError = std::numeric_limits<uint32_t>::max();\n \tfor (shift = kMinCellSizeLog2; shift <= kMaxCellSizeLog2; ++shift) {\n \t\tuint32_t height = std::clamp(bdsOutputSize.height >> shift,\n \t\t\t\t\t kMinCellHeightPerSet,\n", "prefixes": [ "libcamera-devel" ] }