Patch Detail
Show a patch.
GET /api/1.1/patches/13885/?format=api
{ "id": 13885, "url": "https://patchwork.libcamera.org/api/1.1/patches/13885/?format=api", "web_url": "https://patchwork.libcamera.org/patch/13885/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210922132915.14881-2-david.plowman@raspberrypi.com>", "date": "2021-09-22T13:29:14", "name": "[libcamera-devel,v2,1/2] libcamera: camera: Add a mode sensitivity field", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "93bba9947e1486a72f329e099029d55a1ea6f31b", "submitter": { "id": 42, "url": "https://patchwork.libcamera.org/api/1.1/people/42/?format=api", "name": "David Plowman", "email": "david.plowman@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/13885/mbox/", "series": [ { "id": 2545, "url": "https://patchwork.libcamera.org/api/1.1/series/2545/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2545", "date": "2021-09-22T13:29:13", "name": "Application support for per-mode sensitivities", "version": 2, "mbox": "https://patchwork.libcamera.org/series/2545/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/13885/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/13885/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 38925BF01C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 22 Sep 2021 13:29:29 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F3D0869191;\n\tWed, 22 Sep 2021 15:29:28 +0200 (CEST)", "from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com\n\t[IPv6:2a00:1450:4864:20::42f])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 55ADD6917F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 22 Sep 2021 15:29:25 +0200 (CEST)", "by mail-wr1-x42f.google.com with SMTP id t8so6940074wri.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 22 Sep 2021 06:29:25 -0700 (PDT)", "from pi4-davidp.pitowers.org\n\t([2a00:1098:3142:14:1ce1:9965:4328:89c4])\n\tby smtp.gmail.com with ESMTPSA id\n\tq126sm5776310wma.10.2021.09.22.06.29.23\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 22 Sep 2021 06:29:24 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"fOX/Lr6/\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=u/KfOE6Hnhi4DCfVpPNhejIB69FbyQsSdO7xOHmF9IY=;\n\tb=fOX/Lr6/T0YXnV39PQdmvvGjCpbWKSJVIOAwTu0ElsfACVj3XEMQXnoJTu459mDfoX\n\tnKXarWYJXsFIQTJPuYaW6vtlg93TflnWDIJPKJVRjSVEUaYZhzwmxUhynZi5l/E4E9HB\n\tytfAieDXgw4+7UBTI8ihuwcNNwJW9LuttLKMCEZ1PLqICPAa3RS0xjNgTgZhFQeXWZNL\n\tWWXe3LZjm5whjqXJnHotpZ75ikikHYks6xns9eT5ITGQ+FsCmtsC/hlIN4qV0gPNmakj\n\tabeq3wEhAsQ934musZuMZqxyOi+aqMrrGrHOgkdU6FbHUwn0RrXqMSSA62HOd94x5Gnx\n\t0okg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=u/KfOE6Hnhi4DCfVpPNhejIB69FbyQsSdO7xOHmF9IY=;\n\tb=PNQJ6SRv/zF5rRFhn8odNIKVUiPCf5AmfAIpX/yIv7Vk8hIENEdQ0FVjrfnrd7qHNf\n\t1in9lz9wsAPxmryO5WmjMjl8GHoKmqxIDX9PMqeXLa2Ggx+tNh7s+KK/5YbM6BocwHiF\n\t4rXQNDWua/bNYSKTQ6LuaIQXnpWuNEGPf63Tj09wVnNMuXtktoXtZzGCn1H+y9fgr6/g\n\tvNuwMCPuWOp4dSIr4fD523aPcfGXhI8bV+uLy+Pm98ZpCLHb7B3lziMpX+GGyWs8UGSz\n\tN/h3AGsp3jaFUvjgO2qte+0PtvfAr0iRbsgfesTWlgI16ELI5HtDcL84woxrDg4UIoBK\n\tg3kg==", "X-Gm-Message-State": "AOAM530vrJxGZ0DM6KzX1H2bdso9IxVy1lnfHQv3yLd3nOoRfsnRXyvL\n\tm2D1rD9zVR+pQ7XHXR0BW1sP2EgjcxcaFVEP", "X-Google-Smtp-Source": "ABdhPJx2wGCTVY56A1AvEKt8npegT6HuO2icJ3Qpig7KoSKeVVezc+m30gKFigh9HLLM7YLc1zzLsw==", "X-Received": "by 2002:a05:600c:2259:: with SMTP id\n\ta25mr10650208wmm.133.1632317364777; \n\tWed, 22 Sep 2021 06:29:24 -0700 (PDT)", "From": "David Plowman <david.plowman@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 22 Sep 2021 14:29:14 +0100", "Message-Id": "<20210922132915.14881-2-david.plowman@raspberrypi.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20210922132915.14881-1-david.plowman@raspberrypi.com>", "References": "<20210922132915.14881-1-david.plowman@raspberrypi.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 1/2] libcamera: camera: Add a mode\n\tsensitivity field", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The modeSensitivity field is a number that describes how sensitive the\nselected sensor mode is compared to other readout modes of the same\nsensor. For example, a binned mode might have twice the sensitivity of\nthe full resolution mode, meaning you would get double the signal\nlevel for the same exposure and gains.\n\nSigned-off-by: David Plowman <david.plowman@raspberrypi.com>\n---\n include/libcamera/camera.h | 2 ++\n src/libcamera/camera.cpp | 16 +++++++++++++++-\n 2 files changed, 17 insertions(+), 1 deletion(-)", "diff": "diff --git a/include/libcamera/camera.h b/include/libcamera/camera.h\nindex 601ee46e..3314c06b 100644\n--- a/include/libcamera/camera.h\n+++ b/include/libcamera/camera.h\n@@ -66,6 +66,8 @@ public:\n \n \tTransform transform;\n \n+\tfloat modeSensitivity;\n+\n protected:\n \tCameraConfiguration();\n \ndiff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\nindex 71809bcd..8d795dff 100644\n--- a/src/libcamera/camera.cpp\n+++ b/src/libcamera/camera.cpp\n@@ -156,7 +156,7 @@ LOG_DECLARE_CATEGORY(Camera)\n * \\brief Create an empty camera configuration\n */\n CameraConfiguration::CameraConfiguration()\n-\t: transform(Transform::Identity), config_({})\n+\t: transform(Transform::Identity), modeSensitivity(1.0), config_({})\n {\n }\n \n@@ -327,6 +327,20 @@ std::size_t CameraConfiguration::size() const\n * may adjust this field at its discretion if the selection is not supported.\n */\n \n+/**\n+ * \\var CameraConfiguration::modeSensitivity\n+ * \\brief The relative sensitivity of the chosen sensor mode\n+ *\n+ * Some sensors have readout modes with different sensitivities. For example,\n+ * a binned camera mode might, with the same exposure and gains, produce\n+ * twice the signal level of the full resolution readout. This would be\n+ * signalled by the binned mode, when it is chosen, indicating a value here\n+ * that is twice that of the full resolution mode.\n+ *\n+ * This value should only be read, and not set, by the user. It will be\n+ * valid after the configure method has reteurned successfully.\n+ */\n+\n /**\n * \\var CameraConfiguration::config_\n * \\brief The vector of stream configurations\n", "prefixes": [ "libcamera-devel", "v2", "1/2" ] }