Patch Detail
Show a patch.
GET /api/1.1/patches/13876/?format=api
{ "id": 13876, "url": "https://patchwork.libcamera.org/api/1.1/patches/13876/?format=api", "web_url": "https://patchwork.libcamera.org/patch/13876/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210921115610.366553-2-vedantparanjape160201@gmail.com>", "date": "2021-09-21T11:56:09", "name": "[libcamera-devel,v1,2/3] test: gstreamer: Simplify single stream test using functions from GstUtils", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "8a74dd4c4ebc5581ad81e3cdc3bb211b710a5911", "submitter": { "id": 85, "url": "https://patchwork.libcamera.org/api/1.1/people/85/?format=api", "name": "Vedant Paranjape", "email": "vedantparanjape160201@gmail.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/13876/mbox/", "series": [ { "id": 2540, "url": "https://patchwork.libcamera.org/api/1.1/series/2540/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2540", "date": "2021-09-21T11:56:08", "name": "[libcamera-devel,v1,1/3] test: gstreamer_single_stream_test: Fix memory leak", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2540/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/13876/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/13876/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 637FFBDC71\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 21 Sep 2021 11:56:32 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 256E36918A;\n\tTue, 21 Sep 2021 13:56:32 +0200 (CEST)", "from mail-pf1-x436.google.com (mail-pf1-x436.google.com\n\t[IPv6:2607:f8b0:4864:20::436])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 59CFC60247\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 21 Sep 2021 13:56:30 +0200 (CEST)", "by mail-pf1-x436.google.com with SMTP id s16so10967742pfk.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 21 Sep 2021 04:56:30 -0700 (PDT)", "from localhost.localdomain ([1.186.167.167])\n\tby smtp.googlemail.com with ESMTPSA id\n\ty5sm16654906pfb.207.2021.09.21.04.56.26\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 21 Sep 2021 04:56:28 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"Ve6gaG/k\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=Vx16wBbKP5BTxQUAX9O9bcOJnM+jEFATAluVPu/+z2I=;\n\tb=Ve6gaG/kfExq1L1ijIUauIy2XxJipOuCMpOzbJm40pwwnjKJMS2z4/Y8Q9Bh/z9Y8M\n\twLanFbREd+pMrHm8zfvzWRnVb4SHR5HwRBDwy/zA4RAP445aJX+/8YdHRTw/zWP3aVIN\n\tgWgp7Xcrucbn9i0oe4T+8ns1H8WfNEZYpIol4+/F2eT3Y6W3BOkW3XJV2kQfLf8RE70o\n\ttzY39l4KQRCJHbucIquVkBNteqAkArfsJHdwC9W8KtZuah6ejDtTWPNRHBH+sLjuTcHR\n\trjxUBC9toJgaiEkAmZgVcaRQPx5JQgrAXm4+B/YOdwEIUXmWyfunUlMbGyybWE1qhFPX\n\t40GA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=Vx16wBbKP5BTxQUAX9O9bcOJnM+jEFATAluVPu/+z2I=;\n\tb=GYts/tAVsN1AzICL9/yNDwSdgBnAvtit/+SvC9dwMjdBy76MPKFvc+KJPh89NmuyX8\n\t51ZJiMCBIUp3loayrKqoWE+lyhoRPN5BilMYyYuaJ+pRCtBSt261hHSLWCaD9wEPYLMq\n\tm3mfGXelXVDXkTnBbw0WAIoqXo6WGuIloV9nH8CJNbIs55wvdg+dMeYpbx0nOr5PjY1M\n\tWMklHpeIvjsxhE0PNwgssM1numQzn8JBo54q2HnIDkkO99blngTR7AOSRidvk0Oko6L2\n\txjdmvbyeGc5harcMf/imW19NLFGNqHgH5Bi2HbUboLrUnj3XKz3lgC+GhK/VJItZUqGR\n\tFEAQ==", "X-Gm-Message-State": "AOAM532LcMB4ikDV8j5muixqYQIPTljVGyHCbfHv3pIghXvjj9+DJFrV\n\tLhXOJugNvoGoqhzNG5b8vhODyreARbIYow==", "X-Google-Smtp-Source": "ABdhPJxq5bNHHV3K4bdQVtqyaZMQaYc7LEeG0x2z8Qm/FTzwqy3Vzv8FShQan/kjDcobIrHVN0Nueg==", "X-Received": "by 2002:a63:9911:: with SMTP id\n\td17mr28145328pge.111.1632225388448; \n\tTue, 21 Sep 2021 04:56:28 -0700 (PDT)", "From": "Vedant Paranjape <vedantparanjape160201@gmail.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 21 Sep 2021 17:26:09 +0530", "Message-Id": "<20210921115610.366553-2-vedantparanjape160201@gmail.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20210921115610.366553-1-vedantparanjape160201@gmail.com>", "References": "<20210921115610.366553-1-vedantparanjape160201@gmail.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v1 2/3] test: gstreamer: Simplify single\n\tstream test using functions from GstUtils", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Cc": "Nicolas Dufresne <nicolas.dufresne@collabora.com>,\n\tVedant Paranjape <vedantparanjape160201@gmail.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Simplify memory handling and complexity of the test by using\ngst_parse_bin_from_description_full [1].\n\n[1]: https://gstreamer.freedesktop.org/documentation/gstreamer/gstutils.html?gi-language=c#gst_parse_bin_from_description_full\n\nSigned-off-by: Vedant Paranjape <vedantparanjape160201@gmail.com>\nReviewed-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>\n---\n .../gstreamer_single_stream_test.cpp | 27 +++++++------------\n 1 file changed, 10 insertions(+), 17 deletions(-)", "diff": "diff --git a/test/gstreamer/gstreamer_single_stream_test.cpp b/test/gstreamer/gstreamer_single_stream_test.cpp\nindex 2b561d6bf9f2..5fa52bf710be 100644\n--- a/test/gstreamer/gstreamer_single_stream_test.cpp\n+++ b/test/gstreamer/gstreamer_single_stream_test.cpp\n@@ -33,20 +33,15 @@ protected:\n \t\tif (status_ != TestPass)\n \t\t\treturn status_;\n \n-\t\tg_autoptr(GstElement) convert0 = gst_element_factory_make(\"videoconvert\", \"convert0\");\n-\t\tg_autoptr(GstElement) sink0 = gst_element_factory_make(\"fakesink\", \"sink0\");\n-\t\tg_object_ref_sink(convert0);\n-\t\tg_object_ref_sink(sink0);\n-\n-\t\tif (!convert0 || !sink0) {\n-\t\t\tg_printerr(\"Not all elements could be created. %p.%p\\n\",\n-\t\t\t\t convert0, sink0);\n+\t\tconst gchar *streamDescription = \"queue ! videoconvert ! fakesink\";\n+\t\tg_autoptr(GError) error0 = NULL;\n+\t\tstream0_ = gst_parse_bin_from_description_full(streamDescription, TRUE, NULL, GST_PARSE_FLAG_FATAL_ERRORS, &error0);\n \n+\t\tif (!stream0_) {\n+\t\t\tg_printerr(\"Not all bins could be created. %p\\n\", stream0_);\n \t\t\treturn TestFail;\n \t\t}\n-\n-\t\tconvert0_ = reinterpret_cast<GstElement *>(g_steal_pointer(&convert0));\n-\t\tsink0_ = reinterpret_cast<GstElement *>(g_steal_pointer(&sink0));\n+\t\tg_object_ref_sink(stream0_);\n \n \t\tif (createPipeline() != TestPass)\n \t\t\treturn TestFail;\n@@ -57,8 +52,8 @@ protected:\n \tint run() override\n \t{\n \t\t/* Build the pipeline */\n-\t\tgst_bin_add_many(GST_BIN(pipeline_), libcameraSrc_, convert0_, sink0_, NULL);\n-\t\tif (gst_element_link_many(libcameraSrc_, convert0_, sink0_, NULL) != TRUE) {\n+\t\tgst_bin_add_many(GST_BIN(pipeline_), libcameraSrc_, stream0_, NULL);\n+\t\tif (gst_element_link(libcameraSrc_, stream0_) != TRUE) {\n \t\t\tg_printerr(\"Elements could not be linked.\\n\");\n \t\t\treturn TestFail;\n \t\t}\n@@ -74,13 +69,11 @@ protected:\n \n \tvoid cleanup() override\n \t{\n-\t\tg_clear_object(&convert0_);\n-\t\tg_clear_object(&sink0_);\n+\t\tg_clear_object(&stream0_);\n \t}\n \n private:\n-\tGstElement *convert0_;\n-\tGstElement *sink0_;\n+\tGstElement *stream0_;\n };\n \n TEST_REGISTER(GstreamerSingleStreamTest)\n", "prefixes": [ "libcamera-devel", "v1", "2/3" ] }