Patch Detail
Show a patch.
GET /api/1.1/patches/13875/?format=api
{ "id": 13875, "url": "https://patchwork.libcamera.org/api/1.1/patches/13875/?format=api", "web_url": "https://patchwork.libcamera.org/patch/13875/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210921115610.366553-1-vedantparanjape160201@gmail.com>", "date": "2021-09-21T11:56:08", "name": "[libcamera-devel,v1,1/3] test: gstreamer_single_stream_test: Fix memory leak", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "aceb02434098164ad982b3aa5ed4cfd974a5c04b", "submitter": { "id": 85, "url": "https://patchwork.libcamera.org/api/1.1/people/85/?format=api", "name": "Vedant Paranjape", "email": "vedantparanjape160201@gmail.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/13875/mbox/", "series": [ { "id": 2540, "url": "https://patchwork.libcamera.org/api/1.1/series/2540/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2540", "date": "2021-09-21T11:56:08", "name": "[libcamera-devel,v1,1/3] test: gstreamer_single_stream_test: Fix memory leak", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2540/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/13875/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/13875/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 62D81BDC71\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 21 Sep 2021 11:56:29 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BA02C6918A;\n\tTue, 21 Sep 2021 13:56:28 +0200 (CEST)", "from mail-pg1-x52e.google.com (mail-pg1-x52e.google.com\n\t[IPv6:2607:f8b0:4864:20::52e])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 03CF860247\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 21 Sep 2021 13:56:27 +0200 (CEST)", "by mail-pg1-x52e.google.com with SMTP id g184so20453940pgc.6\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 21 Sep 2021 04:56:26 -0700 (PDT)", "from localhost.localdomain ([1.186.167.167])\n\tby smtp.googlemail.com with ESMTPSA id\n\ty5sm16654906pfb.207.2021.09.21.04.56.23\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 21 Sep 2021 04:56:24 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"Eo9wtLPT\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\n\th=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=AjTUusiayGb8XNBYuRtkKRQ3PtUl1WcJg3+jWBjSajQ=;\n\tb=Eo9wtLPTwScp/79+GQkakjzWElUPvNdfo/DZra2jhXWwyEaUNthNJ1jfIHQ6ADY8GR\n\tsBeIQ0QCMbFxzCc13IRcTbydk85uJXFi66KMER2mtnMOmHquXYcY7CKrUu9oq76TkAyT\n\tYdpGrN8FMsjKwfGvBlpsQjOwkdg1Qh93suc6EVXB7DnqB6cB/WU2bpKUyRBlq8Tz8dws\n\tG4b8QoJMbK34bwC37I6QBVGjo33+LJkBpdb9NC3zaskCUKEXhCWiCSZWpIVggOPbHjgD\n\tBV81M/pMENtRSAgLftjjntOJnh53B4kfRq0IzornmcLGktZmU7coBXADvAgvZWvUpiRl\n\tWMmQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=AjTUusiayGb8XNBYuRtkKRQ3PtUl1WcJg3+jWBjSajQ=;\n\tb=wOeQmKs2iQEd+YCVoqSpJCNIhMicKCaGjEkFlCiePwO/54tDjK4IMyWFKP/euh7u61\n\tYNUjy78JS00aB0w4N73620QNyzaN5pLACNkGTSW/zehTh3hCWI3taEMpjYYjiKxIoSnE\n\tsQMpU8Wfp0VN1hcLE5r/azO4VunRK/Jv56GEi65ekJYcv/CBRwMW4PnhpEUNCO+CUUdD\n\tsD0tGpkwP5LmZxbhjijGQXx7ovlazM9EmSbowNd+t+UPe44d23sTGPVHLfGiPekyRMaq\n\tVz7hJCjupK3Pnui7mjULU6IU1ub9rVN2mNeZsuXkKOa+p45hY+OeJskVWdUPnlIY4nMJ\n\toyxg==", "X-Gm-Message-State": "AOAM531C47sHufRVi925adSFU+hJKluRvJgsg5by0kDpBuKA6jk55hN9\n\tam7C5uYsNLNSsVUxhiVWUTdpLntEloRTTw==", "X-Google-Smtp-Source": "ABdhPJwpMgy++9+ThNBA2BrV576aH8VroXj17N9ZKDmC/D4sDBdLemQFNTFGoZn1sZXULQR1NAb0gQ==", "X-Received": "by 2002:a63:788d:: with SMTP id\n\tt135mr27507177pgc.116.1632225385057; \n\tTue, 21 Sep 2021 04:56:25 -0700 (PDT)", "From": "Vedant Paranjape <vedantparanjape160201@gmail.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 21 Sep 2021 17:26:08 +0530", "Message-Id": "<20210921115610.366553-1-vedantparanjape160201@gmail.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v1 1/3] test:\n\tgstreamer_single_stream_test: Fix memory leak", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Cc": "Nicolas Dufresne <nicolas.dufresne@collabora.com>,\n\tVedant Paranjape <vedantparanjape160201@gmail.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The test hold a valid reference to convert0_ and sink0_ but\nnot released. This results in a memory leak and can be checked\nvia valgrind. Drop the references with test cleanup() virtual\nfunction.\n\nValgrind log (glib and gst suppression files were used):\n==345380== LEAK SUMMARY:\n==345380== definitely lost: 1,688 bytes in 2 blocks\n==345380== indirectly lost: 7,069 bytes in 42 blocks\n\nThe patch fixes the leaks reported by valgrind above to:\n==348870== LEAK SUMMARY:\n==348870== definitely lost: 0 bytes in 0 blocks\n==348870== indirectly lost: 0 bytes in 0 blocks\n\nSigned-off-by: Vedant Paranjape <vedantparanjape160201@gmail.com>\nSigned-off-by: Umang Jain <umang.jain@ideasonboard.com>\nReviewed-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>\n---\n test/gstreamer/gstreamer_single_stream_test.cpp | 6 ++++++\n 1 file changed, 6 insertions(+)", "diff": "diff --git a/test/gstreamer/gstreamer_single_stream_test.cpp b/test/gstreamer/gstreamer_single_stream_test.cpp\nindex 7292f3280617..2b561d6bf9f2 100644\n--- a/test/gstreamer/gstreamer_single_stream_test.cpp\n+++ b/test/gstreamer/gstreamer_single_stream_test.cpp\n@@ -72,6 +72,12 @@ protected:\n \t\treturn TestPass;\n \t}\n \n+\tvoid cleanup() override\n+\t{\n+\t\tg_clear_object(&convert0_);\n+\t\tg_clear_object(&sink0_);\n+\t}\n+\n private:\n \tGstElement *convert0_;\n \tGstElement *sink0_;\n", "prefixes": [ "libcamera-devel", "v1", "1/3" ] }