Patch Detail
Show a patch.
GET /api/1.1/patches/13869/?format=api
{ "id": 13869, "url": "https://patchwork.libcamera.org/api/1.1/patches/13869/?format=api", "web_url": "https://patchwork.libcamera.org/patch/13869/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210920173752.1346190-6-umang.jain@ideasonboard.com>", "date": "2021-09-20T17:37:47", "name": "[libcamera-devel,v3,05/10] android: camera_device: Store results metadata into Camera3RequestDescriptor", "commit_ref": null, "pull_url": null, "state": "rfc", "archived": false, "hash": "81940e483ec6d2d4930ae930e293585a3ce5a563", "submitter": { "id": 86, "url": "https://patchwork.libcamera.org/api/1.1/people/86/?format=api", "name": "Umang Jain", "email": "umang.jain@ideasonboard.com" }, "delegate": { "id": 12, "url": "https://patchwork.libcamera.org/api/1.1/users/12/?format=api", "username": "uajain", "first_name": "Umang", "last_name": "Jain", "email": "umang.jain@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/patch/13869/mbox/", "series": [ { "id": 2539, "url": "https://patchwork.libcamera.org/api/1.1/series/2539/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2539", "date": "2021-09-20T17:37:42", "name": "Async post processor", "version": 3, "mbox": "https://patchwork.libcamera.org/series/2539/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/13869/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/13869/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0971DBF01C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 20 Sep 2021 17:38:14 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8D46569192;\n\tMon, 20 Sep 2021 19:38:13 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1BADF69186\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 20 Sep 2021 19:38:11 +0200 (CEST)", "from perceval.ideasonboard.com (unknown [103.251.226.144])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 29CB445E;\n\tMon, 20 Sep 2021 19:38:09 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"L8fEnt+L\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1632159490;\n\tbh=3mnJFgNfPkK7W75ia59SaYjzKYVr84p1f8A8s0Hprhk=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=L8fEnt+LERMX2HtMjY9F6VMZUxqwkDrIwATBcwv3dCCds7j33U69N+8Bd15lhuROF\n\tki4xMISyPrmh+PFTJAwiYUGxxPYhwvUYxsGMzR0hDhLFOD99ZGbxUA9B3Flw+Ac9eS\n\tNoJi2TQ9WcGgQA9VPRFtSOlWju6L4kJUxGYkz7dQ=", "From": "Umang Jain <umang.jain@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 20 Sep 2021 23:07:47 +0530", "Message-Id": "<20210920173752.1346190-6-umang.jain@ideasonboard.com>", "X-Mailer": "git-send-email 2.31.1", "In-Reply-To": "<20210920173752.1346190-1-umang.jain@ideasonboard.com>", "References": "<20210920173752.1346190-1-umang.jain@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v3 05/10] android: camera_device: Store\n\tresults metadata into Camera3RequestDescriptor", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Store metadata which is sent as capture results into the\nCamera3RequestDescriptor. This is will remove the need to send the\nresult metadata pointer separately to CameraStream::process().\nIn the subsequent commit, a Camera3RequestDescriptor pointer\nwill be passed to CameraStream::process() and the result metadata\ncan be directly accessed from there.\n\nSigned-off-by: Umang Jain <umang.jain@ideasonboard.com>\n---\n src/android/camera_device.cpp | 6 ++++--\n src/android/camera_device.h | 1 +\n 2 files changed, 5 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex 3d6a2bed..1ae4ac73 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -1131,6 +1131,8 @@ void CameraDevice::requestComplete(Request *request)\n \t\tresultMetadata = std::make_unique<CameraMetadata>(0, 0);\n \t}\n \n+\tdescriptor->resultMetadata_ = std::move(resultMetadata);\n+\n \t/* Handle any JPEG compression. */\n \tfor (camera3_stream_buffer_t &buffer : descriptor->buffers_) {\n \t\tCameraStream *cameraStream =\n@@ -1150,7 +1152,7 @@ void CameraDevice::requestComplete(Request *request)\n \n \t\tint ret = cameraStream->process(src, *buffer.buffer,\n \t\t\t\t\t\tdescriptor->settings_,\n-\t\t\t\t\t\tresultMetadata.get());\n+\t\t\t\t\t\tdescriptor->resultMetadata_.get());\n \t\t/*\n \t\t * Return the FrameBuffer to the CameraStream now that we're\n \t\t * done processing it.\n@@ -1165,7 +1167,7 @@ void CameraDevice::requestComplete(Request *request)\n \t\t}\n \t}\n \n-\tcaptureResult.result = resultMetadata->get();\n+\tcaptureResult.result = descriptor->resultMetadata_->get();\n \tcallbacks_->process_capture_result(callbacks_, &captureResult);\n \n \tdescriptors_.pop_front();\ndiff --git a/src/android/camera_device.h b/src/android/camera_device.h\nindex 59d6cd39..b2871e52 100644\n--- a/src/android/camera_device.h\n+++ b/src/android/camera_device.h\n@@ -47,6 +47,7 @@ struct Camera3RequestDescriptor {\n \tstd::vector<std::unique_ptr<libcamera::FrameBuffer>> frameBuffers_;\n \tCameraMetadata settings_;\n \tstd::unique_ptr<CaptureRequest> request_;\n+\tstd::unique_ptr<CameraMetadata> resultMetadata_;\n };\n \n class CameraDevice : protected libcamera::Loggable\n", "prefixes": [ "libcamera-devel", "v3", "05/10" ] }