Patch Detail
Show a patch.
GET /api/1.1/patches/13868/?format=api
{ "id": 13868, "url": "https://patchwork.libcamera.org/api/1.1/patches/13868/?format=api", "web_url": "https://patchwork.libcamera.org/patch/13868/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210920173752.1346190-5-umang.jain@ideasonboard.com>", "date": "2021-09-20T17:37:46", "name": "[libcamera-devel,v3,04/10] camera_device: Remove private scope of Camera3RequestDescriptor", "commit_ref": null, "pull_url": null, "state": "rfc", "archived": false, "hash": "ef19370193a9da74cbda90ac19354dab660389b4", "submitter": { "id": 86, "url": "https://patchwork.libcamera.org/api/1.1/people/86/?format=api", "name": "Umang Jain", "email": "umang.jain@ideasonboard.com" }, "delegate": { "id": 12, "url": "https://patchwork.libcamera.org/api/1.1/users/12/?format=api", "username": "uajain", "first_name": "Umang", "last_name": "Jain", "email": "umang.jain@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/patch/13868/mbox/", "series": [ { "id": 2539, "url": "https://patchwork.libcamera.org/api/1.1/series/2539/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2539", "date": "2021-09-20T17:37:42", "name": "Async post processor", "version": 3, "mbox": "https://patchwork.libcamera.org/series/2539/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/13868/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/13868/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 52AC3BF01C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 20 Sep 2021 17:38:13 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0A9706918E;\n\tMon, 20 Sep 2021 19:38:13 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4454F69193\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 20 Sep 2021 19:38:09 +0200 (CEST)", "from perceval.ideasonboard.com (unknown [103.251.226.144])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E33F045E;\n\tMon, 20 Sep 2021 19:38:07 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"OQKuGvq7\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1632159489;\n\tbh=LAi8gk29ROf52/Gv1fBFmEI1Bsw+/93HLXQ0pkKSPAs=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=OQKuGvq7y9FUSFYzwo2ryv4Lm+ukp0VI8481UOfwWpnXHCYOjgcZ5jAtP2PoMS4F9\n\tgq89Qqi3lIKY5ALQ/MrRbIlqcDkhP8f8BgpWzO499XxP6xqTPzSIhputYvR5pg1yDt\n\toZn8hijBVSXZx+d3/KqUBMVsvr/UPZFVSm242spY=", "From": "Umang Jain <umang.jain@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 20 Sep 2021 23:07:46 +0530", "Message-Id": "<20210920173752.1346190-5-umang.jain@ideasonboard.com>", "X-Mailer": "git-send-email 2.31.1", "In-Reply-To": "<20210920173752.1346190-1-umang.jain@ideasonboard.com>", "References": "<20210920173752.1346190-1-umang.jain@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v3 04/10] camera_device: Remove private\n\tscope of Camera3RequestDescriptor", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Camera3RequestDescriptor is a utility structure that groups information\nabout a capture request. It can be and will be extended to preserve the\ncontext of a capture overall. Since the context of a capture needs to\nbe shared among other classes (for e.g. CameraStream) having a private\ndefinition of the struct doesn't help. Hence, de-scope the structure\nso that it can be shared with other components (through references or\npointers).\n\nSigned-off-by: Umang Jain <umang.jain@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/android/camera_device.cpp | 2 +-\n src/android/camera_device.h | 29 +++++++++++++++--------------\n 2 files changed, 16 insertions(+), 15 deletions(-)", "diff": "diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex cc078fe4..3d6a2bed 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -220,7 +220,7 @@ bool validateCropRotate(const camera3_stream_configuration_t &streamList)\n * later re-used at request complete time to notify the framework.\n */\n \n-CameraDevice::Camera3RequestDescriptor::Camera3RequestDescriptor(\n+Camera3RequestDescriptor::Camera3RequestDescriptor(\n \tCamera *camera, const camera3_capture_request_t *camera3Request)\n {\n \tframeNumber_ = camera3Request->frame_number;\ndiff --git a/src/android/camera_device.h b/src/android/camera_device.h\nindex 9c895b25..59d6cd39 100644\n--- a/src/android/camera_device.h\n+++ b/src/android/camera_device.h\n@@ -34,6 +34,21 @@\n #include \"jpeg/encoder.h\"\n \n struct CameraConfigData;\n+\n+struct Camera3RequestDescriptor {\n+\tCamera3RequestDescriptor() = default;\n+\t~Camera3RequestDescriptor() = default;\n+\tCamera3RequestDescriptor(libcamera::Camera *camera,\n+\t\t\t\t const camera3_capture_request_t *camera3Request);\n+\tCamera3RequestDescriptor &operator=(Camera3RequestDescriptor &&) = default;\n+\n+\tuint32_t frameNumber_ = 0;\n+\tstd::vector<camera3_stream_buffer_t> buffers_;\n+\tstd::vector<std::unique_ptr<libcamera::FrameBuffer>> frameBuffers_;\n+\tCameraMetadata settings_;\n+\tstd::unique_ptr<CaptureRequest> request_;\n+};\n+\n class CameraDevice : protected libcamera::Loggable\n {\n public:\n@@ -72,20 +87,6 @@ private:\n \n \tCameraDevice(unsigned int id, std::shared_ptr<libcamera::Camera> camera);\n \n-\tstruct Camera3RequestDescriptor {\n-\t\tCamera3RequestDescriptor() = default;\n-\t\t~Camera3RequestDescriptor() = default;\n-\t\tCamera3RequestDescriptor(libcamera::Camera *camera,\n-\t\t\t\t\t const camera3_capture_request_t *camera3Request);\n-\t\tCamera3RequestDescriptor &operator=(Camera3RequestDescriptor &&) = default;\n-\n-\t\tuint32_t frameNumber_ = 0;\n-\t\tstd::vector<camera3_stream_buffer_t> buffers_;\n-\t\tstd::vector<std::unique_ptr<libcamera::FrameBuffer>> frameBuffers_;\n-\t\tCameraMetadata settings_;\n-\t\tstd::unique_ptr<CaptureRequest> request_;\n-\t};\n-\n \tenum class State {\n \t\tStopped,\n \t\tFlushing,\n", "prefixes": [ "libcamera-devel", "v3", "04/10" ] }