Patch Detail
Show a patch.
GET /api/1.1/patches/13820/?format=api
{ "id": 13820, "url": "https://patchwork.libcamera.org/api/1.1/patches/13820/?format=api", "web_url": "https://patchwork.libcamera.org/patch/13820/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210913102007.2303225-2-paul.elder@ideasonboard.com>", "date": "2021-09-13T10:20:06", "name": "[libcamera-devel,2/3] ipa: raspberrypi: Clean up NoiseReductionMode values", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "5b431f4f71e02479454db7a4dd612083365147e1", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/1.1/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": { "id": 17, "url": "https://patchwork.libcamera.org/api/1.1/users/17/?format=api", "username": "epaul", "first_name": "Paul", "last_name": "Elder", "email": "paul.elder@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/patch/13820/mbox/", "series": [ { "id": 2521, "url": "https://patchwork.libcamera.org/api/1.1/series/2521/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2521", "date": "2021-09-13T10:20:05", "name": "[libcamera-devel,1/3] controls: Promote NoiseReductionMode to non-draft", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2521/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/13820/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/13820/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 25234BDC71\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 13 Sep 2021 10:20:26 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D44816918A;\n\tMon, 13 Sep 2021 12:20:25 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DE95F69181\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 13 Sep 2021 12:20:22 +0200 (CEST)", "from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 641258F;\n\tMon, 13 Sep 2021 12:20:21 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ICfwqniR\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1631528422;\n\tbh=vgXXX1UiwW1lKKfOtDdsicUxqJhQolxV3lF7wZBPztk=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=ICfwqniRa6qvTjv6wLtuup3QBu+8zfPSPuSLW1ONWofdxRMUsWumQMl0RgpqX/MuQ\n\t+OrluX6rjkmpg+/lzRYaz9nmehrxYAbmIDX9P3Ex7DQNTED2fmPNZQJ3CMeKt5/f4M\n\teK7tO+2FIV91xJqouNGe9PgvaOLjvRumEA2dU3jc=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 13 Sep 2021 19:20:06 +0900", "Message-Id": "<20210913102007.2303225-2-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20210913102007.2303225-1-paul.elder@ideasonboard.com>", "References": "<20210913102007.2303225-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 2/3] ipa: raspberrypi: Clean up\n\tNoiseReductionMode values", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Remove the NoiseReductionMode values that the raspberrypi IPA does not\nsupport. The ControlInfo values that the IPA reports will be used for\ncapability detection, so values that it does not support shall be\nremoved.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\n---\n include/libcamera/ipa/raspberrypi.h | 8 +++++++-\n src/ipa/raspberrypi/raspberrypi.cpp | 2 --\n 2 files changed, 7 insertions(+), 3 deletions(-)", "diff": "diff --git a/include/libcamera/ipa/raspberrypi.h b/include/libcamera/ipa/raspberrypi.h\nindex e0dc6f5e..6e97ef53 100644\n--- a/include/libcamera/ipa/raspberrypi.h\n+++ b/include/libcamera/ipa/raspberrypi.h\n@@ -18,6 +18,12 @@ namespace libcamera {\n \n namespace RPi {\n \n+const std::array<const ControlValue, 3> RPiNoiseReductionModeValues = {\n+\tstatic_cast<int32_t>(controls::NoiseReductionModeOff),\n+\tstatic_cast<int32_t>(controls::NoiseReductionModeFast),\n+\tstatic_cast<int32_t>(controls::NoiseReductionModeHighQuality),\n+};\n+\n /*\n * List of controls handled by the Raspberry Pi IPA\n *\n@@ -45,7 +51,7 @@ static const ControlInfoMap Controls({\n \t\t{ &controls::ColourCorrectionMatrix, ControlInfo(-16.0f, 16.0f) },\n \t\t{ &controls::ScalerCrop, ControlInfo(Rectangle{}, Rectangle(65535, 65535, 65535, 65535), Rectangle{}) },\n \t\t{ &controls::FrameDurationLimits, ControlInfo(INT64_C(1000), INT64_C(1000000000)) },\n-\t\t{ &controls::NoiseReductionMode, ControlInfo(controls::NoiseReductionModeValues) }\n+\t\t{ &controls::NoiseReductionMode, ControlInfo(RPiNoiseReductionModeValues) }\n \t}, controls::controls);\n \n } /* namespace RPi */\ndiff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp\nindex 8d44ab0a..daef1c2d 100644\n--- a/src/ipa/raspberrypi/raspberrypi.cpp\n+++ b/src/ipa/raspberrypi/raspberrypi.cpp\n@@ -608,8 +608,6 @@ static const std::map<int32_t, RPiController::DenoiseMode> DenoiseModeTable = {\n \t{ controls::NoiseReductionModeOff, RPiController::DenoiseMode::Off },\n \t{ controls::NoiseReductionModeFast, RPiController::DenoiseMode::ColourFast },\n \t{ controls::NoiseReductionModeHighQuality, RPiController::DenoiseMode::ColourHighQuality },\n-\t{ controls::NoiseReductionModeMinimal, RPiController::DenoiseMode::ColourOff },\n-\t{ controls::NoiseReductionModeZSL, RPiController::DenoiseMode::ColourHighQuality },\n };\n \n void IPARPi::queueRequest(const ControlList &controls)\n", "prefixes": [ "libcamera-devel", "2/3" ] }