Patch Detail
Show a patch.
GET /api/1.1/patches/13810/?format=api
{ "id": 13810, "url": "https://patchwork.libcamera.org/api/1.1/patches/13810/?format=api", "web_url": "https://patchwork.libcamera.org/patch/13810/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210910104729.542779-3-umang.jain@ideasonboard.com>", "date": "2021-09-10T10:47:29", "name": "[libcamera-devel,v1,2/2] android: Fix generation of thumbnail for EXIF data", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "11a2521e26d65e87b0dea2bc514ca802c420d4a2", "submitter": { "id": 86, "url": "https://patchwork.libcamera.org/api/1.1/people/86/?format=api", "name": "Umang Jain", "email": "umang.jain@ideasonboard.com" }, "delegate": { "id": 12, "url": "https://patchwork.libcamera.org/api/1.1/users/12/?format=api", "username": "uajain", "first_name": "Umang", "last_name": "Jain", "email": "umang.jain@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/patch/13810/mbox/", "series": [ { "id": 2514, "url": "https://patchwork.libcamera.org/api/1.1/series/2514/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2514", "date": "2021-09-10T10:47:27", "name": "android: Fix generation of thumbnail for EXIF data", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2514/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/13810/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/13810/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D5DD3BDB1D\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 10 Sep 2021 10:47:43 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 943B569180;\n\tFri, 10 Sep 2021 12:47:43 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1DF696916A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 10 Sep 2021 12:47:42 +0200 (CEST)", "from perceval.ideasonboard.com (unknown [103.251.226.149])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1241A883;\n\tFri, 10 Sep 2021 12:47:40 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"j07J7mD+\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1631270861;\n\tbh=DD/bgEqmwrB2Sr4qEVYX22q/uI3+AqdUDNwcoUs9aIw=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=j07J7mD+P4tJHvV9v0+tklA1y1N3Yq4RnCJesDOiH6Kk16B4bIdoWybRFCTpYMWGQ\n\truRWGfaFKWVkuQufANJLknF20GNlmq8ljDvdhNnyS+gDtIdBCz3tvuKL2ZmTtCcSGM\n\tITPn08JNRPtIVvfTOXIfsIK91AnXeghbOgar25xQ=", "From": "Umang Jain <umang.jain@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 10 Sep 2021 16:17:29 +0530", "Message-Id": "<20210910104729.542779-3-umang.jain@ideasonboard.com>", "X-Mailer": "git-send-email 2.31.1", "In-Reply-To": "<20210910104729.542779-1-umang.jain@ideasonboard.com>", "References": "<20210910104729.542779-1-umang.jain@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v1 2/2] android: Fix generation of\n\tthumbnail for EXIF data", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Generation of thumbnail is not occuring currently because\nANDROID_JPEG_THUMBNAIL_SIZE is not set for request metadata passed\nto PostProcessorJpeg::process(). This is a regression introduced in\n1264628d3c92(\"android: jpeg: Configure thumbnailer based on request\nmetadata\").\n\nThe patch fixes this issue by setting ANDROID_JPEG_THUMBNAIL_SIZE in\nthe request metadata template populated by\nCameraCapabilities::requestTemplatePreview(). The value for\nANDROID_JPEG_THUMBNAIL_SIZE is set to be the first non-zero size\nreported by static metadata ANDROID_JPEG_AVAILABLE_THUMBNAIL_SIZES.\n\nFixes: 1264628d3c92(\"android: jpeg: Configure thumbnailer based on request metadata\")\nSigned-off-by: Umang Jain <umang.jain@ideasonboard.com>\n---\n src/android/camera_capabilities.cpp | 17 +++++++++++++++--\n 1 file changed, 15 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/android/camera_capabilities.cpp b/src/android/camera_capabilities.cpp\nindex e92bca42..ba551b86 100644\n--- a/src/android/camera_capabilities.cpp\n+++ b/src/android/camera_capabilities.cpp\n@@ -1341,9 +1341,9 @@ std::unique_ptr<CameraMetadata> CameraCapabilities::requestTemplatePreview() con\n {\n \t/*\n \t * \\todo Keep this in sync with the actual number of entries.\n-\t * Currently: 20 entries, 35 bytes\n+\t * Currently: 21 entries, 37 bytes\n \t */\n-\tauto requestTemplate = std::make_unique<CameraMetadata>(21, 36);\n+\tauto requestTemplate = std::make_unique<CameraMetadata>(22, 38);\n \tif (!requestTemplate->isValid()) {\n \t\treturn nullptr;\n \t}\n@@ -1364,6 +1364,19 @@ std::unique_ptr<CameraMetadata> CameraCapabilities::requestTemplatePreview() con\n \trequestTemplate->addEntry(ANDROID_CONTROL_AE_TARGET_FPS_RANGE,\n \t\t\t\t entry.data.i32, 2);\n \n+\t/*\n+\t * Get thumbnail sizes from static metadata and add the first non-zero\n+\t * size to the template.\n+\t */\n+\tfound = staticMetadata_->getEntry(ANDROID_JPEG_AVAILABLE_THUMBNAIL_SIZES,\n+\t\t\t\t\t &entry);\n+\tif (!found) {\n+\t\tLOG(HAL, Error) << \"availableThumbnailSizes not found in static metadata\";\n+\t\treturn nullptr;\n+\t}\n+\trequestTemplate->addEntry(ANDROID_JPEG_THUMBNAIL_SIZE,\n+\t\t\t\t entry.data.i32 + 2, 2);\n+\n \tuint8_t aeMode = ANDROID_CONTROL_AE_MODE_ON;\n \trequestTemplate->addEntry(ANDROID_CONTROL_AE_MODE, aeMode);\n \n", "prefixes": [ "libcamera-devel", "v1", "2/2" ] }