Patch Detail
Show a patch.
GET /api/1.1/patches/13801/?format=api
{ "id": 13801, "url": "https://patchwork.libcamera.org/api/1.1/patches/13801/?format=api", "web_url": "https://patchwork.libcamera.org/patch/13801/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210910070638.467294-4-umang.jain@ideasonboard.com>", "date": "2021-09-10T07:06:32", "name": "[libcamera-devel,v2,3/9] android: post_processor: Plumb down the process() with context", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "c9bdecb2fbafc1c4145ca2668e8a6c06b036e870", "submitter": { "id": 86, "url": "https://patchwork.libcamera.org/api/1.1/people/86/?format=api", "name": "Umang Jain", "email": "umang.jain@ideasonboard.com" }, "delegate": { "id": 12, "url": "https://patchwork.libcamera.org/api/1.1/users/12/?format=api", "username": "uajain", "first_name": "Umang", "last_name": "Jain", "email": "umang.jain@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/patch/13801/mbox/", "series": [ { "id": 2513, "url": "https://patchwork.libcamera.org/api/1.1/series/2513/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2513", "date": "2021-09-10T07:06:29", "name": "Async Post Processor", "version": 2, "mbox": "https://patchwork.libcamera.org/series/2513/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/13801/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/13801/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 11A5ABDC71\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 10 Sep 2021 07:06:54 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CD99269179;\n\tFri, 10 Sep 2021 09:06:53 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0134669169\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 10 Sep 2021 09:06:53 +0200 (CEST)", "from perceval.ideasonboard.com (unknown [103.251.226.149])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D7E1D883;\n\tFri, 10 Sep 2021 09:06:51 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"koe+4uDr\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1631257612;\n\tbh=uquyLzokirPsp+ruweahkcaBqeUYhQGzlxPivJ/R1vs=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=koe+4uDrjLstlHrPHlF9TXxwUNUrLAI6cvPWCottBKW70Dv8lOBQfm63DpuFgXZDp\n\tEOtDt8y9KmE4twfrDpl8bO1lQ8lM0CzzSfPBpROUGp4baoAeQSWHq1zhcpu6nyPVdt\n\tLYDI1OQwz859rF+nXQyad5AMqQaOQhQs0GFlydRM=", "From": "Umang Jain <umang.jain@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 10 Sep 2021 12:36:32 +0530", "Message-Id": "<20210910070638.467294-4-umang.jain@ideasonboard.com>", "X-Mailer": "git-send-email 2.31.1", "In-Reply-To": "<20210910070638.467294-1-umang.jain@ideasonboard.com>", "References": "<20210910070638.467294-1-umang.jain@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 3/9] android: post_processor: Plumb\n\tdown the process() with context", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The context required for post processing of a camera request is saved\nvia Camera3RequestDescriptor. The context needs to be plumbed to\nPostProcessor::process() which should be passed a const pointer to\nCamera3RequestDescriptor. In subsequent commits, we will prepare\nthe post-processor to run asynchrnoously hence, it will require the\ncontext pointer to be emitted back to the upper layers, to identify for\nwhich request the post-processing has been completed.\n\nSigned-off-by: Umang Jain <umang.jain@ideasonboard.com>\n---\n src/android/camera_device.cpp | 3 ++-\n src/android/camera_stream.cpp | 6 ++++--\n src/android/camera_stream.h | 5 ++++-\n src/android/jpeg/post_processor_jpeg.cpp | 3 ++-\n src/android/jpeg/post_processor_jpeg.h | 3 ++-\n src/android/post_processor.h | 5 ++++-\n src/android/yuv/post_processor_yuv.cpp | 3 ++-\n src/android/yuv/post_processor_yuv.h | 3 ++-\n 8 files changed, 22 insertions(+), 9 deletions(-)", "diff": "diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex 0840c056..84549d04 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -1150,7 +1150,8 @@ void CameraDevice::requestComplete(Request *request)\n \n \t\tint ret = cameraStream->process(src, *buffer.buffer,\n \t\t\t\t\t\tdescriptor.settings_,\n-\t\t\t\t\t\tresultMetadata.get());\n+\t\t\t\t\t\tresultMetadata.get(),\n+\t\t\t\t\t\t&descriptor);\n \t\t/*\n \t\t * Return the FrameBuffer to the CameraStream now that we're\n \t\t * done processing it.\ndiff --git a/src/android/camera_stream.cpp b/src/android/camera_stream.cpp\nindex 0fed5382..d1c54797 100644\n--- a/src/android/camera_stream.cpp\n+++ b/src/android/camera_stream.cpp\n@@ -101,7 +101,8 @@ int CameraStream::configure()\n int CameraStream::process(const FrameBuffer *source,\n \t\t\t buffer_handle_t camera3Dest,\n \t\t\t const CameraMetadata &requestMetadata,\n-\t\t\t CameraMetadata *resultMetadata)\n+\t\t\t CameraMetadata *resultMetadata,\n+\t\t\t const Camera3RequestDescriptor *context)\n {\n \tif (!postProcessor_)\n \t\treturn 0;\n@@ -118,7 +119,8 @@ int CameraStream::process(const FrameBuffer *source,\n \t\treturn -EINVAL;\n \t}\n \n-\treturn postProcessor_->process(source, &dest, requestMetadata, resultMetadata);\n+\treturn postProcessor_->process(source, &dest, requestMetadata,\n+\t\t\t\t resultMetadata, context);\n }\n \n FrameBuffer *CameraStream::getBuffer()\ndiff --git a/src/android/camera_stream.h b/src/android/camera_stream.h\nindex 5c232cb6..d589f699 100644\n--- a/src/android/camera_stream.h\n+++ b/src/android/camera_stream.h\n@@ -23,6 +23,8 @@ class CameraDevice;\n class CameraMetadata;\n class PostProcessor;\n \n+struct Camera3RequestDescriptor;\n+\n class CameraStream\n {\n public:\n@@ -121,7 +123,8 @@ public:\n \tint process(const libcamera::FrameBuffer *source,\n \t\t buffer_handle_t camera3Dest,\n \t\t const CameraMetadata &requestMetadata,\n-\t\t CameraMetadata *resultMetadata);\n+\t\t CameraMetadata *resultMetadata,\n+\t\t const Camera3RequestDescriptor *context);\n \tlibcamera::FrameBuffer *getBuffer();\n \tvoid putBuffer(libcamera::FrameBuffer *buffer);\n \ndiff --git a/src/android/jpeg/post_processor_jpeg.cpp b/src/android/jpeg/post_processor_jpeg.cpp\nindex cb45f86b..741eeb21 100644\n--- a/src/android/jpeg/post_processor_jpeg.cpp\n+++ b/src/android/jpeg/post_processor_jpeg.cpp\n@@ -100,7 +100,8 @@ void PostProcessorJpeg::generateThumbnail(const FrameBuffer *source,\n int PostProcessorJpeg::process(const FrameBuffer *source,\n \t\t\t CameraBuffer *destination,\n \t\t\t const CameraMetadata &requestMetadata,\n-\t\t\t CameraMetadata *resultMetadata)\n+\t\t\t CameraMetadata *resultMetadata,\n+\t\t\t const Camera3RequestDescriptor *context)\n {\n \tif (!encoder_)\n \t\treturn 0;\ndiff --git a/src/android/jpeg/post_processor_jpeg.h b/src/android/jpeg/post_processor_jpeg.h\nindex c4b2e9ef..72c38fdb 100644\n--- a/src/android/jpeg/post_processor_jpeg.h\n+++ b/src/android/jpeg/post_processor_jpeg.h\n@@ -25,7 +25,8 @@ public:\n \tint process(const libcamera::FrameBuffer *source,\n \t\t CameraBuffer *destination,\n \t\t const CameraMetadata &requestMetadata,\n-\t\t CameraMetadata *resultMetadata) override;\n+\t\t CameraMetadata *resultMetadata,\n+\t\t const Camera3RequestDescriptor *context) override;\n \n private:\n \tvoid generateThumbnail(const libcamera::FrameBuffer *source,\ndiff --git a/src/android/post_processor.h b/src/android/post_processor.h\nindex 61dfb6d4..1213e7e6 100644\n--- a/src/android/post_processor.h\n+++ b/src/android/post_processor.h\n@@ -14,6 +14,8 @@\n \n class CameraMetadata;\n \n+struct Camera3RequestDescriptor;\n+\n class PostProcessor\n {\n public:\n@@ -24,7 +26,8 @@ public:\n \tvirtual int process(const libcamera::FrameBuffer *source,\n \t\t\t CameraBuffer *destination,\n \t\t\t const CameraMetadata &requestMetadata,\n-\t\t\t CameraMetadata *resultMetadata) = 0;\n+\t\t\t CameraMetadata *resultMetadata,\n+\t\t\t const Camera3RequestDescriptor *context) = 0;\n };\n \n #endif /* __ANDROID_POST_PROCESSOR_H__ */\ndiff --git a/src/android/yuv/post_processor_yuv.cpp b/src/android/yuv/post_processor_yuv.cpp\nindex 0a874886..13a78abe 100644\n--- a/src/android/yuv/post_processor_yuv.cpp\n+++ b/src/android/yuv/post_processor_yuv.cpp\n@@ -52,7 +52,8 @@ int PostProcessorYuv::configure(const StreamConfiguration &inCfg,\n int PostProcessorYuv::process(const FrameBuffer *source,\n \t\t\t CameraBuffer *destination,\n \t\t\t [[maybe_unused]] const CameraMetadata &requestMetadata,\n-\t\t\t [[maybe_unused]] CameraMetadata *metadata)\n+\t\t\t [[maybe_unused]] CameraMetadata *metadata,\n+\t\t\t [[maybe_unused]] const Camera3RequestDescriptor *context)\n {\n \tif (!isValidBuffers(source, *destination))\n \t\treturn -EINVAL;\ndiff --git a/src/android/yuv/post_processor_yuv.h b/src/android/yuv/post_processor_yuv.h\nindex 44a04113..38a30f91 100644\n--- a/src/android/yuv/post_processor_yuv.h\n+++ b/src/android/yuv/post_processor_yuv.h\n@@ -23,7 +23,8 @@ public:\n \tint process(const libcamera::FrameBuffer *source,\n \t\t CameraBuffer *destination,\n \t\t const CameraMetadata &requestMetadata,\n-\t\t CameraMetadata *metadata) override;\n+\t\t CameraMetadata *metadata,\n+\t\t const Camera3RequestDescriptor *context) override;\n \n private:\n \tbool isValidBuffers(const libcamera::FrameBuffer *source,\n", "prefixes": [ "libcamera-devel", "v2", "3/9" ] }