Patch Detail
Show a patch.
GET /api/1.1/patches/138/?format=api
{ "id": 138, "url": "https://patchwork.libcamera.org/api/1.1/patches/138/?format=api", "web_url": "https://patchwork.libcamera.org/patch/138/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190103013110.6849-4-laurent.pinchart@ideasonboard.com>", "date": "2019-01-03T01:31:05", "name": "[libcamera-devel,4/9] libcamera: device_enumerator: Downgrade skipped device errors to warnings", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "5ffa8cfe994dfe8325108f84b90bd284b37f4741", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/138/mbox/", "series": [ { "id": 51, "url": "https://patchwork.libcamera.org/api/1.1/series/51/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=51", "date": "2019-01-03T01:31:02", "name": "[libcamera-devel,1/9] libcamera: camera_manager: Remove put() method", "version": 1, "mbox": "https://patchwork.libcamera.org/series/51/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/138/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/138/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4935E60B32\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 3 Jan 2019 02:30:14 +0100 (CET)", "from avalon.bb.dnainternet.fi\n\t(dfj612ybrt5fhg77mgycy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:2e86:4862:ef6a:2804])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DBA9F573\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 3 Jan 2019 02:30:13 +0100 (CET)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1546479014;\n\tbh=fMsj/nBSFi2DFbLtAD/Y9dIHUHne5/wSU3qpkwCgbmw=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=bokjB5vrU7xL6CIC7pKwaPp7garmA9VcrFYonrIn7Mf/Vn7tw0/oyt+ak8wfbdALC\n\twgNlLL2ZApA7x86jehSxtKV0d85xvTi7A3ljNYTXhhUgycr3Ea3CZJRd7Uf6zCYZ2d\n\tvTKG08vWrSb+L4ZIgSk4BAYnTY2EHziWvtJpUhiQ=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 3 Jan 2019 03:31:05 +0200", "Message-Id": "<20190103013110.6849-4-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.19.2", "In-Reply-To": "<20190103013110.6849-1-laurent.pinchart@ideasonboard.com>", "References": "<20190103013110.6849-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 4/9] libcamera: device_enumerator:\n\tDowngrade skipped device errors to warnings", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Thu, 03 Jan 2019 01:30:14 -0000" }, "content": "When a device is skipped by the udev-based enumerator a message is\nlogged. Downgrade its severity to warning as the error isn't fatal.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/device_enumerator.cpp | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/libcamera/device_enumerator.cpp b/src/libcamera/device_enumerator.cpp\nindex 7eef450e0c65..bc55a12f2a4e 100644\n--- a/src/libcamera/device_enumerator.cpp\n+++ b/src/libcamera/device_enumerator.cpp\n@@ -302,8 +302,8 @@ int DeviceEnumeratorUdev::enumerate()\n \n \t\tdev = udev_device_new_from_syspath(udev_, syspath);\n \t\tif (!dev) {\n-\t\t\tLOG(Error) << \"Failed to get device for '\" <<\n-\t\t\t\t syspath << \"', skipping\";\n+\t\t\tLOG(Warning) << \"Failed to get device for '\" <<\n+\t\t\t\tsyspath << \"', skipping\";\n \t\t\tcontinue;\n \t\t}\n \n", "prefixes": [ "libcamera-devel", "4/9" ] }