Patch Detail
Show a patch.
GET /api/1.1/patches/13785/?format=api
{ "id": 13785, "url": "https://patchwork.libcamera.org/api/1.1/patches/13785/?format=api", "web_url": "https://patchwork.libcamera.org/patch/13785/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210909121447.3888276-1-kieran.bingham@ideasonboard.com>", "date": "2021-09-09T12:14:47", "name": "[libcamera-devel,SimpleCam] simple-cam: Use new metadata API", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "185ab2ee568d5f2da431f8a69472ac73daaf1cc5", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/1.1/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/13785/mbox/", "series": [ { "id": 2505, "url": "https://patchwork.libcamera.org/api/1.1/series/2505/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2505", "date": "2021-09-09T12:14:47", "name": "[libcamera-devel,SimpleCam] simple-cam: Use new metadata API", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2505/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/13785/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/13785/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 369BDBDB1D\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 9 Sep 2021 12:14:54 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8216D6916E;\n\tThu, 9 Sep 2021 14:14:53 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 917056916B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 9 Sep 2021 14:14:51 +0200 (CEST)", "from Monstersaurus.local\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0F62D883;\n\tThu, 9 Sep 2021 14:14:51 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"VqkqQApy\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1631189691;\n\tbh=8fc2GsUoFEqtXTYhM5QKj4JEPDAfJvvq/MG/tzKHJDA=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=VqkqQApyuaI39tHCci7xI9nHUP0mjOit4UK43MpCeJQ4P+1df+aWbENqEOnqESQl5\n\tFNgaD89+Xf9eE2SNybAnCUqB7Hd/aa/tLTNWbCejdS4PZt0jGLAIUDZ09+qOeFcww5\n\tBx/v7YybX/hs5zI7CiZ27EOR0wfD2Wj8OxJBcPMw=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Date": "Thu, 9 Sep 2021 13:14:47 +0100", "Message-Id": "<20210909121447.3888276-1-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.30.2", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [SimpleCam PATCH] simple-cam: Use new metadata API", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "In libcamera commit 32635054bc76 (\"libcamera: framebuffer: Prevent\nmodifying the number of metadata planes\"), the planes are returned as a\nconst span rather than a vector from the metadata.\n\nThis provides better protection on the underlying structures, but was a\nbreak in the API.\n\nUpdate simple-cam to use the new API.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n simple-cam.cpp | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/simple-cam.cpp b/simple-cam.cpp\nindex a8ac3c83ccb5..95e472b4377a 100644\n--- a/simple-cam.cpp\n+++ b/simple-cam.cpp\n@@ -58,10 +58,10 @@ static void processRequest(Request *request)\n \t\t\t << \" bytesused: \";\n \n \t\tunsigned int nplane = 0;\n-\t\tfor (const FrameMetadata::Plane &plane : metadata.planes)\n+\t\tfor (const FrameMetadata::Plane &plane : metadata.planes())\n \t\t{\n \t\t\tstd::cout << plane.bytesused;\n-\t\t\tif (++nplane < metadata.planes.size())\n+\t\t\tif (++nplane < metadata.planes().size())\n \t\t\t\tstd::cout << \"/\";\n \t\t}\n \n", "prefixes": [ "libcamera-devel", "SimpleCam" ] }