Patch Detail
Show a patch.
GET /api/1.1/patches/13777/?format=api
{ "id": 13777, "url": "https://patchwork.libcamera.org/api/1.1/patches/13777/?format=api", "web_url": "https://patchwork.libcamera.org/patch/13777/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210909080902.239533-7-paul.elder@ideasonboard.com>", "date": "2021-09-09T08:09:01", "name": "[libcamera-devel,v3,6/7] v4l2: v4l2_camera_proxy: Set the compressed flag in enum_fmt", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "9d969e0b0fdefa1cd09494a1178b541ddc0dc52c", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/1.1/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/13777/mbox/", "series": [ { "id": 2502, "url": "https://patchwork.libcamera.org/api/1.1/series/2502/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2502", "date": "2021-09-09T08:08:55", "name": "v4l2-compat fixes", "version": 3, "mbox": "https://patchwork.libcamera.org/series/2502/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/13777/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/13777/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D1F1DBDC71\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 9 Sep 2021 08:09:26 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9D37D69175;\n\tThu, 9 Sep 2021 10:09:26 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 168866916A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 9 Sep 2021 10:09:25 +0200 (CEST)", "from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 992B824F;\n\tThu, 9 Sep 2021 10:09:23 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Knqmtd8X\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1631174964;\n\tbh=iFPFSSZyX+1wIG96rnLR/RY21bSWy/RoaWuFI9HmG2E=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=Knqmtd8X7lRcYKuOO603bUtCOPvye7AoX88+MopgOb5dTjUfkS7HoTV2BNwEUCyko\n\tYiE7whN4qMdIbQUCbDORVkDgWonXVdvfM1tkR1jT869hqqIG0nzuV56xcm9SmKJYhH\n\t5/lAsy5nSQDPl8xMSc+91NAmajuOEA2PPJ/y5XIE=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 9 Sep 2021 17:09:01 +0900", "Message-Id": "<20210909080902.239533-7-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20210909080902.239533-1-paul.elder@ideasonboard.com>", "References": "<20210909080902.239533-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v3 6/7] v4l2: v4l2_camera_proxy: Set the\n\tcompressed flag in enum_fmt", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Set the compressed flag in ENUM_FMT if the format is MJPEG. As the only\ncompressed format that libcamera currently supports is MJPEG, this\nshould be sufficient.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/v4l2/v4l2_camera_proxy.cpp | 3 +--\n 1 file changed, 1 insertion(+), 2 deletions(-)", "diff": "diff --git a/src/v4l2/v4l2_camera_proxy.cpp b/src/v4l2/v4l2_camera_proxy.cpp\nindex abb30820..3610e63c 100644\n--- a/src/v4l2/v4l2_camera_proxy.cpp\n+++ b/src/v4l2/v4l2_camera_proxy.cpp\n@@ -276,8 +276,7 @@ int V4L2CameraProxy::vidioc_enum_fmt(V4L2CameraFile *file, struct v4l2_fmtdesc *\n \tPixelFormat format = streamConfig_.formats().pixelformats()[arg->index];\n \tV4L2PixelFormat v4l2Format = V4L2PixelFormat::fromPixelFormat(format);\n \n-\t/* \\todo Set V4L2_FMT_FLAG_COMPRESSED for compressed formats. */\n-\targ->flags = 0;\n+\targ->flags = format == formats::MJPEG ? V4L2_FMT_FLAG_COMPRESSED : 0;\n \tutils::strlcpy(reinterpret_cast<char *>(arg->description),\n \t\t v4l2Format.description(), sizeof(arg->description));\n \targ->pixelformat = v4l2Format;\n", "prefixes": [ "libcamera-devel", "v3", "6/7" ] }