Patch Detail
Show a patch.
GET /api/1.1/patches/13721/?format=api
{ "id": 13721, "url": "https://patchwork.libcamera.org/api/1.1/patches/13721/?format=api", "web_url": "https://patchwork.libcamera.org/patch/13721/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210907132424.657707-4-jeanmichel.hautbois@ideasonboard.com>", "date": "2021-09-07T13:24:23", "name": "[libcamera-devel,v4,3/4] ipa: ipu3: Change Accumulator structure layout", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "14642de6666145e1c3ddfe2690b49fc0e11bd1db", "submitter": { "id": 75, "url": "https://patchwork.libcamera.org/api/1.1/people/75/?format=api", "name": "Jean-Michel Hautbois", "email": "jeanmichel.hautbois@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/13721/mbox/", "series": [ { "id": 2488, "url": "https://patchwork.libcamera.org/api/1.1/series/2488/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2488", "date": "2021-09-07T13:24:20", "name": "Move and improve AWB structures", "version": 4, "mbox": "https://patchwork.libcamera.org/series/2488/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/13721/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/13721/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C4204BDC71\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 7 Sep 2021 13:24:33 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6E6E169172;\n\tTue, 7 Sep 2021 15:24:33 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 62B2460251\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 7 Sep 2021 15:24:29 +0200 (CEST)", "from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:e0a9:3439:7934:19a5])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0E441499;\n\tTue, 7 Sep 2021 15:24:29 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"YOw0tSue\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1631021069;\n\tbh=BYDEpM1OdvnJCG3NRvgFLjur2DXoY02FWoenyjHjsGk=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=YOw0tSueHm3Jj5dWAMguktxZsEeWuLozzbxfEI7Oy/KKaUn6jlgzuXgm0lPTmh/l6\n\t7AKLhbPHjTWf1bXzK95+duPSzv37EVuhErODEjFzt3PZjpjT0ilwNuj6Z6DLuWoSNX\n\tO0GN3JA4vyQFyAPBnmzSYXuW0kfPvwdQcIUKCjmY=", "From": "Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 7 Sep 2021 15:24:23 +0200", "Message-Id": "<20210907132424.657707-4-jeanmichel.hautbois@ideasonboard.com>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20210907132424.657707-1-jeanmichel.hautbois@ideasonboard.com>", "References": "<20210907132424.657707-1-jeanmichel.hautbois@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v4 3/4] ipa: ipu3: Change Accumulator\n\tstructure layout", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The pixel component sums for the Accumulator are inconsistent with other\nsimilar structures such as the IPAFrameContext::awb::gains. Group the\nred, green, and blue sums together in a struct and store them as\nuint64_t to reduce potential architectural differences.\n\nSigned-off-by: Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/ipa/ipu3/algorithms/awb.cpp | 24 ++++++++++++------------\n src/ipa/ipu3/algorithms/awb.h | 8 +++++---\n 2 files changed, 17 insertions(+), 15 deletions(-)", "diff": "diff --git a/src/ipa/ipu3/algorithms/awb.cpp b/src/ipa/ipu3/algorithms/awb.cpp\nindex 97f5839f..bc0aa6fe 100644\n--- a/src/ipa/ipu3/algorithms/awb.cpp\n+++ b/src/ipa/ipu3/algorithms/awb.cpp\n@@ -42,13 +42,13 @@ static constexpr uint32_t kMinGreenLevelInZone = 32;\n * \\var Accumulator::counted\n * \\brief Number of relevant regions used to calculate the sums\n *\n- * \\var Accumulator::rSum\n+ * \\var Accumulator::sum::red\n * \\brief Sum of the red values in the zone\n *\n- * \\var Accumulator::gSum\n+ * \\var Accumulator::sum::green\n * \\brief Sum of the green values in the zone\n *\n- * \\var Accumulator::bSum\n+ * \\var Accumulator::sum::blue\n * \\brief Sum of the blue values in the zone\n */\n \n@@ -173,10 +173,10 @@ void Awb::generateZones(std::vector<RGB> &zones)\n \t\tRGB zone;\n \t\tdouble counted = awbStats_[i].counted;\n \t\tif (counted >= kMinZonesCounted) {\n-\t\t\tzone.G = awbStats_[i].gSum / counted;\n+\t\t\tzone.G = awbStats_[i].sum.green / counted;\n \t\t\tif (zone.G >= kMinGreenLevelInZone) {\n-\t\t\t\tzone.R = awbStats_[i].rSum / counted;\n-\t\t\t\tzone.B = awbStats_[i].bSum / counted;\n+\t\t\t\tzone.R = awbStats_[i].sum.red / counted;\n+\t\t\t\tzone.B = awbStats_[i].sum.blue / counted;\n \t\t\t\tzones.push_back(zone);\n \t\t\t}\n \t\t}\n@@ -209,9 +209,9 @@ void Awb::generateAwbStats(const ipu3_uapi_stats_3a *stats,\n \t\t\t\t/* The cell is not saturated, use the current cell */\n \t\t\t\tawbStats_[awbRegionPosition].counted++;\n \t\t\t\tuint32_t greenValue = currentCell->greenRedAvg + currentCell->greenBlueAvg;\n-\t\t\t\tawbStats_[awbRegionPosition].gSum += greenValue / 2;\n-\t\t\t\tawbStats_[awbRegionPosition].rSum += currentCell->redAvg;\n-\t\t\t\tawbStats_[awbRegionPosition].bSum += currentCell->blueAvg;\n+\t\t\t\tawbStats_[awbRegionPosition].sum.green += greenValue / 2;\n+\t\t\t\tawbStats_[awbRegionPosition].sum.red += currentCell->redAvg;\n+\t\t\t\tawbStats_[awbRegionPosition].sum.blue += currentCell->blueAvg;\n \t\t\t}\n \t\t}\n \t}\n@@ -220,9 +220,9 @@ void Awb::generateAwbStats(const ipu3_uapi_stats_3a *stats,\n void Awb::clearAwbStats()\n {\n \tfor (unsigned int i = 0; i < kAwbStatsSizeX * kAwbStatsSizeY; i++) {\n-\t\tawbStats_[i].bSum = 0;\n-\t\tawbStats_[i].rSum = 0;\n-\t\tawbStats_[i].gSum = 0;\n+\t\tawbStats_[i].sum.blue = 0;\n+\t\tawbStats_[i].sum.red = 0;\n+\t\tawbStats_[i].sum.green = 0;\n \t\tawbStats_[i].counted = 0;\n \t}\n }\ndiff --git a/src/ipa/ipu3/algorithms/awb.h b/src/ipa/ipu3/algorithms/awb.h\nindex ac8ccc84..3385ebe7 100644\n--- a/src/ipa/ipu3/algorithms/awb.h\n+++ b/src/ipa/ipu3/algorithms/awb.h\n@@ -35,9 +35,11 @@ struct Ipu3AwbCell {\n \n struct Accumulator {\n \tunsigned int counted;\n-\tunsigned long long rSum;\n-\tunsigned long long gSum;\n-\tunsigned long long bSum;\n+\tstruct {\n+\t\tuint64_t red;\n+\t\tuint64_t green;\n+\t\tuint64_t blue;\n+\t} sum;\n };\n \n class Awb : public Algorithm\n", "prefixes": [ "libcamera-devel", "v4", "3/4" ] }