Patch Detail
Show a patch.
GET /api/1.1/patches/13711/?format=api
{ "id": 13711, "url": "https://patchwork.libcamera.org/api/1.1/patches/13711/?format=api", "web_url": "https://patchwork.libcamera.org/patch/13711/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210907071311.3364713-2-paul.elder@ideasonboard.com>", "date": "2021-09-07T07:13:11", "name": "[libcamera-devel,2/2] v4l2: v4l2_camera_proxy: Report the proper format name in enum_fmt", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "851f42f35900bb53574620360f599eebce57e64d", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/1.1/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/13711/mbox/", "series": [ { "id": 2486, "url": "https://patchwork.libcamera.org/api/1.1/series/2486/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2486", "date": "2021-09-07T07:13:10", "name": "[libcamera-devel,1/2] libcamera: formats: Add field for name of V4L2 format", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2486/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/13711/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/13711/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 44992BDC71\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 7 Sep 2021 07:13:39 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0A60C6916D;\n\tTue, 7 Sep 2021 09:13:39 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1061169166\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 7 Sep 2021 09:13:37 +0200 (CEST)", "from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A5101499;\n\tTue, 7 Sep 2021 09:13:35 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"or3QhuXg\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1630998816;\n\tbh=+6RIBBoMEsm7LU3qKz/TkP18HIpGVnXNmg0WJj+ascA=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=or3QhuXgHgyD7AayaYSxkVc04hXH734AxdCJbT7mHjho1UN/xbRoQ7VfDa/mkd1VS\n\tksrq0ksnMy1QmPC5a6f34YE4oKvlHfvWnQfNbcM5eas5Sq22xiD4r++aVrfTj3AKMD\n\ttLDAft1l/8i1EiCyhC78bJjGbZOGjEAKfYF2m46o=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 7 Sep 2021 16:13:11 +0900", "Message-Id": "<20210907071311.3364713-2-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20210907071311.3364713-1-paul.elder@ideasonboard.com>", "References": "<20210907071311.3364713-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 2/2] v4l2: v4l2_camera_proxy: Report the\n\tproper format name in enum_fmt", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Now that libcamera has the V4L2 format names, retrive and report those\nnames in ENUM_FMT. While at it, refactor the code slightly with\nPixelFormatInfo.\n\nThis fixes the test failures on v4l2-compliance with the v4l2\ncompatilibity layer that were observed in version v4l2-compliance\nversion 1.21.0-4838.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\n---\n src/v4l2/v4l2_camera_proxy.cpp | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)", "diff": "diff --git a/src/v4l2/v4l2_camera_proxy.cpp b/src/v4l2/v4l2_camera_proxy.cpp\nindex 07b1a90a..ec335ce2 100644\n--- a/src/v4l2/v4l2_camera_proxy.cpp\n+++ b/src/v4l2/v4l2_camera_proxy.cpp\n@@ -270,13 +270,13 @@ int V4L2CameraProxy::vidioc_enum_fmt(V4L2CameraFile *file, struct v4l2_fmtdesc *\n \t\treturn -EINVAL;\n \n \tPixelFormat format = streamConfig_.formats().pixelformats()[arg->index];\n+\tPixelFormatInfo info = PixelFormatInfo::info(format);\n \n \t/* \\todo Set V4L2_FMT_FLAG_COMPRESSED for compressed formats. */\n \targ->flags = 0;\n-\t/* \\todo Add map from format to description. */\n \tutils::strlcpy(reinterpret_cast<char *>(arg->description),\n-\t\t \"Video Format Description\", sizeof(arg->description));\n-\targ->pixelformat = PixelFormatInfo::info(format).v4l2Format;\n+\t\t info.v4l2Name, sizeof(arg->description));\n+\targ->pixelformat = info.v4l2Format;\n \n \tmemset(arg->reserved, 0, sizeof(arg->reserved));\n \n", "prefixes": [ "libcamera-devel", "2/2" ] }