Patch Detail
Show a patch.
GET /api/1.1/patches/13628/?format=api
{ "id": 13628, "url": "https://patchwork.libcamera.org/api/1.1/patches/13628/?format=api", "web_url": "https://patchwork.libcamera.org/patch/13628/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210906081908.3083134-1-paul.elder@ideasonboard.com>", "date": "2021-09-06T08:19:08", "name": "[libcamera-devel] utils: ipc: proxy worker: Fix indentation in call deserialization", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "0fbd3dfca1bb63fd2358547a58ad1b65d9cd2c23", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/1.1/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/13628/mbox/", "series": [ { "id": 2447, "url": "https://patchwork.libcamera.org/api/1.1/series/2447/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2447", "date": "2021-09-06T08:19:08", "name": "[libcamera-devel] utils: ipc: proxy worker: Fix indentation in call deserialization", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2447/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/13628/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/13628/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 78FEEBD87D\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 6 Sep 2021 08:19:24 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DA9426916A;\n\tMon, 6 Sep 2021 10:19:23 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1E57E60503\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 6 Sep 2021 10:19:22 +0200 (CEST)", "from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AD4F624F;\n\tMon, 6 Sep 2021 10:19:20 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"MHkOWloh\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1630916361;\n\tbh=Y+bXwUvvzasgNb6zDvbun1F0/31FsNqiJsKuJ+zQKj0=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=MHkOWloh3RCMhXEuISKYEQQZJ77YnC2n+Oz7m3uPNUoOWx+B9JMpPJmlf1DecYdpb\n\tMz3lKtcVqqyXB++/fwPWSn9f67DX+5HalETYM6sN7cAwcx4ZTf7D2mwIGKjcilkep/\n\tiz1pX/rNCVH3fi0ojMXI7x8MtBmek19YM2ax2cZ4=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 6 Sep 2021 17:19:08 +0900", "Message-Id": "<20210906081908.3083134-1-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] utils: ipc: proxy worker: Fix indentation\n\tin call deserialization", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The indentation of the deserialization call on the proxy worker side\ninside the case statement was one level too shallow. Fix it.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\n---\n .../libcamera_templates/module_ipa_proxy_worker.cpp.tmpl | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/utils/ipc/generators/libcamera_templates/module_ipa_proxy_worker.cpp.tmpl b/utils/ipc/generators/libcamera_templates/module_ipa_proxy_worker.cpp.tmpl\nindex c54ecdb9..c306d8df 100644\n--- a/utils/ipc/generators/libcamera_templates/module_ipa_proxy_worker.cpp.tmpl\n+++ b/utils/ipc/generators/libcamera_templates/module_ipa_proxy_worker.cpp.tmpl\n@@ -79,7 +79,7 @@ public:\n \n {% for method in interface_main.methods %}\n \t\tcase {{cmd_enum_name}}::{{method.mojom_name|cap}}: {\n-\t\t{{proxy_funcs.deserialize_call(method|method_param_inputs, '_ipcMessage.data()', '_ipcMessage.fds()', false, true)|indent(8, true)}}\n+\t\t{{proxy_funcs.deserialize_call(method|method_param_inputs, '_ipcMessage.data()', '_ipcMessage.fds()', false, true)|indent(16, true)}}\n {% for param in method|method_param_outputs %}\n \t\t\t{{param|name}} {{param.mojom_name}};\n {% endfor %}\n", "prefixes": [ "libcamera-devel" ] }