Patch Detail
Show a patch.
GET /api/1.1/patches/13610/?format=api
{ "id": 13610, "url": "https://patchwork.libcamera.org/api/1.1/patches/13610/?format=api", "web_url": "https://patchwork.libcamera.org/patch/13610/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210902134353.80920-2-jeanmichel.hautbois@ideasonboard.com>", "date": "2021-09-02T13:43:50", "name": "[libcamera-devel,v2,1/4] ipa: ipu3: Move the AWB stats structures", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "1c239085a1b70df6837ade6906515f22b6b99b1d", "submitter": { "id": 75, "url": "https://patchwork.libcamera.org/api/1.1/people/75/?format=api", "name": "Jean-Michel Hautbois", "email": "jeanmichel.hautbois@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/13610/mbox/", "series": [ { "id": 2441, "url": "https://patchwork.libcamera.org/api/1.1/series/2441/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2441", "date": "2021-09-02T13:43:49", "name": "Move and improve AWB structures", "version": 2, "mbox": "https://patchwork.libcamera.org/series/2441/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/13610/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/13610/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 56EF7C3241\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 2 Sep 2021 13:44:01 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 27D3B6916E;\n\tThu, 2 Sep 2021 15:44:00 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 77AED69166\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 2 Sep 2021 15:43:58 +0200 (CEST)", "from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:43b0:6633:e0bd:5dc6])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 07B941544;\n\tThu, 2 Sep 2021 15:43:58 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"nO0RX4es\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1630590238;\n\tbh=xja9h82q4iWa3Ti+Kgy1RkAwvN3ON2fmFF9+qFsXmVo=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=nO0RX4esbw/9jQ8ZCSr/qEFm4V3YwQOesFP4bfyLb0gDm03KKEbXp8b524MNVHQnc\n\tTRs+Ogp2TramzzHroNikbXd8PQrUu9jj5IJ2pzHOlbGA4T4ovhHFKi+L5dMeqrE40q\n\tBmRfC6rUNH4UxcvgAOd5kqFIyaxF4fCfl8Z/oB0c=", "From": "Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 2 Sep 2021 15:43:50 +0200", "Message-Id": "<20210902134353.80920-2-jeanmichel.hautbois@ideasonboard.com>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20210902134353.80920-1-jeanmichel.hautbois@ideasonboard.com>", "References": "<20210902134353.80920-1-jeanmichel.hautbois@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 1/4] ipa: ipu3: Move the AWB stats\n\tstructures", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The structure Ipu3AwbCell describes the AWB stats layout on the kernel\nside. We will need it to be used by the AGC algorithm to be introduced\nlater, so let's make it visible from ipa::ipu3::algorithms and not only\nfor the AWB class.\n\nThe IspStatsRegion will be needed by AGC too, so let's move it in the\nsame namespace too.\n\nSigned-off-by: Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/ipa/ipu3/algorithms/awb.h | 37 ++++++++++++++++++-----------------\n 1 file changed, 19 insertions(+), 18 deletions(-)", "diff": "diff --git a/src/ipa/ipu3/algorithms/awb.h b/src/ipa/ipu3/algorithms/awb.h\nindex a16dd68d..cc848060 100644\n--- a/src/ipa/ipu3/algorithms/awb.h\n+++ b/src/ipa/ipu3/algorithms/awb.h\n@@ -23,6 +23,24 @@ namespace ipa::ipu3::algorithms {\n static constexpr uint32_t kAwbStatsSizeX = 16;\n static constexpr uint32_t kAwbStatsSizeY = 12;\n \n+/* \\todo Move the cell layout into intel-ipu3.h kernel header */\n+struct Ipu3AwbCell {\n+\tunsigned char greenRedAvg;\n+\tunsigned char redAvg;\n+\tunsigned char blueAvg;\n+\tunsigned char greenBlueAvg;\n+\tunsigned char satRatio;\n+\tunsigned char padding[3];\n+} __attribute__((packed));\n+\n+struct IspStatsRegion {\n+\tunsigned int counted;\n+\tunsigned int uncounted;\n+\tunsigned long long rSum;\n+\tunsigned long long gSum;\n+\tunsigned long long bSum;\n+};\n+\n class Awb : public Algorithm\n {\n public:\n@@ -32,16 +50,7 @@ public:\n \tvoid prepare(IPAContext &context, ipu3_uapi_params *params) override;\n \tvoid process(IPAContext &context, const ipu3_uapi_stats_3a *stats) override;\n \n-\tstruct Ipu3AwbCell {\n-\t\tunsigned char greenRedAvg;\n-\t\tunsigned char redAvg;\n-\t\tunsigned char blueAvg;\n-\t\tunsigned char greenBlueAvg;\n-\t\tunsigned char satRatio;\n-\t\tunsigned char padding[3];\n-\t} __attribute__((packed));\n-\n-\t/* \\todo Make these three structs available to all the ISPs ? */\n+\t/* \\todo Make these structs available to all the ISPs ? */\n \tstruct RGB {\n \t\tRGB(double _R = 0, double _G = 0, double _B = 0)\n \t\t\t: R(_R), G(_G), B(_B)\n@@ -55,14 +64,6 @@ public:\n \t\t}\n \t};\n \n-\tstruct IspStatsRegion {\n-\t\tunsigned int counted;\n-\t\tunsigned int uncounted;\n-\t\tunsigned long long rSum;\n-\t\tunsigned long long gSum;\n-\t\tunsigned long long bSum;\n-\t};\n-\n \tstruct AwbStatus {\n \t\tdouble temperatureK;\n \t\tdouble redGain;\n", "prefixes": [ "libcamera-devel", "v2", "1/4" ] }