Patch Detail
Show a patch.
GET /api/1.1/patches/1360/?format=api
{ "id": 1360, "url": "https://patchwork.libcamera.org/api/1.1/patches/1360/?format=api", "web_url": "https://patchwork.libcamera.org/patch/1360/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190605154047.12055-1-laurent.pinchart@ideasonboard.com>", "date": "2019-06-05T15:40:47", "name": "[libcamera-devel] libcamera: Use dependency instead of link_args to link against libdl", "commit_ref": "a87c63c7e9c7186805ab2f9a16816e65a699bde7", "pull_url": null, "state": "accepted", "archived": false, "hash": "f8dd373ef3570dd1701a3ffa7a073fa6726227a2", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/1360/mbox/", "series": [ { "id": 338, "url": "https://patchwork.libcamera.org/api/1.1/series/338/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=338", "date": "2019-06-05T15:40:47", "name": "[libcamera-devel] libcamera: Use dependency instead of link_args to link against libdl", "version": 1, "mbox": "https://patchwork.libcamera.org/series/338/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/1360/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/1360/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 62B0C66260\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 5 Jun 2019 17:41:08 +0200 (CEST)", "from pendragon.ideasonboard.com (85-76-35-254-nat.elisa-mobile.fi\n\t[85.76.35.254])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6104B84\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 5 Jun 2019 17:41:06 +0200 (CEST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1559749268;\n\tbh=uB/Lt0h859rAN/nARFHZNjPwSxh33shZnhfFqekXy9E=;\n\th=From:To:Subject:Date:From;\n\tb=IUHZMdSNOuYI5Ja+sdatgpoQHtkwvIDXn6mslovfqvYvdCmGH7n0B9Q4NGTJA1KHl\n\tmELk7godOA3yYr7mFntmaj4gVWWnijGt8owFm/JQrXZQJaS6Svxc8ZCsSdLTWMzSAd\n\t2j8bKBqCN91oN7R1pwmbfgfUJYyKbPfARlUkR1NA=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 5 Jun 2019 18:40:47 +0300", "Message-Id": "<20190605154047.12055-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.21.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] libcamera: Use dependency instead of\n\tlink_args to link against libdl", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Wed, 05 Jun 2019 15:41:08 -0000" }, "content": "Instead of specifying the link arguments directly, which may be\ncompiler-specific, use a dependency object provided by find_library().\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/meson.build | 8 ++++++--\n 1 file changed, 6 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\nindex 0889b0d31f36..1ca1083cf5c7 100644\n--- a/src/libcamera/meson.build\n+++ b/src/libcamera/meson.build\n@@ -63,12 +63,16 @@ if libudev.found()\n ])\n endif\n \n+libcamera_deps = [\n+ cc.find_library('dl'),\n+ libudev,\n+]\n+\n libcamera = shared_library('camera',\n libcamera_sources,\n install : true,\n include_directories : includes,\n- dependencies : libudev,\n- link_args : '-ldl')\n+ dependencies : libcamera_deps)\n \n libcamera_dep = declare_dependency(sources : [libcamera_api, libcamera_h],\n include_directories : libcamera_includes,\n", "prefixes": [ "libcamera-devel" ] }