Patch Detail
Show a patch.
GET /api/1.1/patches/13588/?format=api
{ "id": 13588, "url": "https://patchwork.libcamera.org/api/1.1/patches/13588/?format=api", "web_url": "https://patchwork.libcamera.org/patch/13588/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210831223705.1928000-4-nfraprado@collabora.com>", "date": "2021-08-31T22:37:03", "name": "[libcamera-devel,v2,3/5] libcamera: pipeline: rkisp1: Add internal request queue", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "a9d37565500f66503a177cb463233f90f75e0cea", "submitter": { "id": 84, "url": "https://patchwork.libcamera.org/api/1.1/people/84/?format=api", "name": "Nícolas F. R. A. Prado", "email": "nfraprado@collabora.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/13588/mbox/", "series": [ { "id": 2431, "url": "https://patchwork.libcamera.org/api/1.1/series/2431/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2431", "date": "2021-08-31T22:37:00", "name": "libcamera: pipeline: Add internal request queue", "version": 2, "mbox": "https://patchwork.libcamera.org/series/2431/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/13588/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/13588/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DE030C3243\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 31 Aug 2021 22:37:47 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 53D5F69180;\n\tWed, 1 Sep 2021 00:37:46 +0200 (CEST)", "from bhuna.collabora.co.uk (bhuna.collabora.co.uk\n\t[IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 10A5060258\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 1 Sep 2021 00:37:36 +0200 (CEST)", "from localhost.localdomain (unknown\n\t[IPv6:2804:14c:1a9:2434:b693:c9:5cb6:b688])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits))\n\t(No client certificate requested) (Authenticated sender: nfraprado)\n\tby bhuna.collabora.co.uk (Postfix) with ESMTPSA id 355441F43958;\n\tTue, 31 Aug 2021 23:37:33 +0100 (BST)" ], "From": "=?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= <nfraprado@collabora.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 31 Aug 2021 19:37:03 -0300", "Message-Id": "<20210831223705.1928000-4-nfraprado@collabora.com>", "X-Mailer": "git-send-email 2.33.0", "In-Reply-To": "<20210831223705.1928000-1-nfraprado@collabora.com>", "References": "<20210831223705.1928000-1-nfraprado@collabora.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 3/5] libcamera: pipeline: rkisp1: Add\n\tinternal request queue", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Cc": "kernel@collabora.com, =?utf-8?q?Andr=C3=A9_Almeida?=\n\t<andrealmeid@collabora.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add an internal queue that stores requests until there are internal\nbuffers and V4L2 buffer slots available. This avoids the need to cancel\nrequests when there is a shortage of said buffers.\n\nSigned-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n---\n\nChanges in v2:\n- Moved cancellation of pending requests to after video devices stop\n\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 73 +++++++++++++++++++-----\n 1 file changed, 59 insertions(+), 14 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex 03a8d1d26e30..6aca4083af72 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -91,6 +91,9 @@ public:\n \tPipelineHandlerRkISP1 *pipe();\n \tint loadIPA(unsigned int hwRevision);\n \n+\tvoid queuePendingRequests();\n+\tvoid cancelPendingRequests();\n+\n \tStream mainPathStream_;\n \tStream selfPathStream_;\n \tstd::unique_ptr<CameraSensor> sensor_;\n@@ -104,6 +107,8 @@ public:\n \n \tstd::unique_ptr<ipa::rkisp1::IPAProxyRkISP1> ipa_;\n \n+\tstd::queue<Request *> pendingRequests_;\n+\n private:\n \tvoid queueFrameAction(unsigned int frame,\n \t\t\t const ipa::rkisp1::RkISP1Action &action);\n@@ -210,13 +215,13 @@ RkISP1FrameInfo *RkISP1Frames::create(const RkISP1CameraData *data, Request *req\n \tunsigned int frame = data->frame_;\n \n \tif (pipe_->availableParamBuffers_.empty()) {\n-\t\tLOG(RkISP1, Error) << \"Parameters buffer underrun\";\n+\t\tLOG(RkISP1, Debug) << \"Parameters buffer underrun\";\n \t\treturn nullptr;\n \t}\n \tFrameBuffer *paramBuffer = pipe_->availableParamBuffers_.front();\n \n \tif (pipe_->availableStatBuffers_.empty()) {\n-\t\tLOG(RkISP1, Error) << \"Statisitc buffer underrun\";\n+\t\tLOG(RkISP1, Debug) << \"Statistic buffer underrun\";\n \t\treturn nullptr;\n \t}\n \tFrameBuffer *statBuffer = pipe_->availableStatBuffers_.front();\n@@ -386,6 +391,52 @@ void RkISP1CameraData::metadataReady(unsigned int frame, const ControlList &meta\n \tpipe()->tryCompleteRequest(info->request);\n }\n \n+void RkISP1CameraData::queuePendingRequests()\n+{\n+\twhile (!pendingRequests_.empty()) {\n+\t\tRequest *request = pendingRequests_.front();\n+\n+\t\t/*\n+\t\t * If there aren't internal buffers available, we break and try\n+\t\t * again later. If there are, we're guaranteed to also have V4L2\n+\t\t * buffer slots available to queue the request, since we should\n+\t\t * always have more (or equal) buffer slots than internal\n+\t\t * buffers.\n+\t\t */\n+\t\tRkISP1FrameInfo *info = frameInfo_.create(this, request);\n+\t\tif (!info)\n+\t\t\tbreak;\n+\n+\t\tipa::rkisp1::RkISP1Event ev;\n+\t\tev.op = ipa::rkisp1::EventQueueRequest;\n+\t\tev.frame = frame_;\n+\t\tev.bufferId = info->paramBuffer->cookie();\n+\t\tev.controls = request->controls();\n+\t\tipa_->processEvent(ev);\n+\n+\t\tframe_++;\n+\n+\t\tpendingRequests_.pop();\n+\t}\n+}\n+\n+void RkISP1CameraData::cancelPendingRequests()\n+{\n+\twhile (!pendingRequests_.empty()) {\n+\t\tRequest *request = pendingRequests_.front();\n+\n+\t\tfor (auto it : request->buffers()) {\n+\t\t\tFrameBuffer *buffer = it.second;\n+\t\t\tbuffer->cancel();\n+\t\t\tpipe()->completeBuffer(request, buffer);\n+\t\t}\n+\n+\t\tpipe()->completeRequest(request);\n+\n+\t\tpendingRequests_.pop();\n+\t}\n+}\n+\n RkISP1CameraConfiguration::RkISP1CameraConfiguration(Camera *camera,\n \t\t\t\t\t\t RkISP1CameraData *data)\n \t: CameraConfiguration()\n@@ -855,6 +906,8 @@ void PipelineHandlerRkISP1::stop(Camera *camera)\n \t\tLOG(RkISP1, Warning)\n \t\t\t<< \"Failed to stop parameters for \" << camera->id();\n \n+\tdata->cancelPendingRequests();\n+\n \tASSERT(data->queuedRequests_.empty());\n \tdata->frameInfo_.clear();\n \n@@ -867,18 +920,8 @@ int PipelineHandlerRkISP1::queueRequestDevice(Camera *camera, Request *request)\n {\n \tRkISP1CameraData *data = cameraData(camera);\n \n-\tRkISP1FrameInfo *info = data->frameInfo_.create(data, request);\n-\tif (!info)\n-\t\treturn -ENOENT;\n-\n-\tipa::rkisp1::RkISP1Event ev;\n-\tev.op = ipa::rkisp1::EventQueueRequest;\n-\tev.frame = data->frame_;\n-\tev.bufferId = info->paramBuffer->cookie();\n-\tev.controls = request->controls();\n-\tdata->ipa_->processEvent(ev);\n-\n-\tdata->frame_++;\n+\tdata->pendingRequests_.push(request);\n+\tdata->queuePendingRequests();\n \n \treturn 0;\n }\n@@ -1077,6 +1120,8 @@ void PipelineHandlerRkISP1::tryCompleteRequest(Request *request)\n \tdata->frameInfo_.destroy(info->frame);\n \n \tcompleteRequest(request);\n+\n+\tdata->queuePendingRequests();\n }\n \n void PipelineHandlerRkISP1::bufferReady(FrameBuffer *buffer)\n", "prefixes": [ "libcamera-devel", "v2", "3/5" ] }