Patch Detail
Show a patch.
GET /api/1.1/patches/13573/?format=api
{ "id": 13573, "url": "https://patchwork.libcamera.org/api/1.1/patches/13573/?format=api", "web_url": "https://patchwork.libcamera.org/patch/13573/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210831063438.785767-3-hiroh@chromium.org>", "date": "2021-08-31T06:34:35", "name": "[libcamera-devel,2/5] android: jpeg: thumbnailer: Use MappedFrameBuffer::planes()", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "5fafb61f2809b096c1cb1de08c620627e34b37d5", "submitter": { "id": 63, "url": "https://patchwork.libcamera.org/api/1.1/people/63/?format=api", "name": "Hirokazu Honda", "email": "hiroh@chromium.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/13573/mbox/", "series": [ { "id": 2423, "url": "https://patchwork.libcamera.org/api/1.1/series/2423/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2423", "date": "2021-08-31T06:34:33", "name": "Improve/Clean up post processors code in android", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2423/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/13573/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/13573/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 41114BD87D\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 31 Aug 2021 06:35:10 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0426669176;\n\tTue, 31 Aug 2021 08:35:10 +0200 (CEST)", "from mail-pj1-x102b.google.com (mail-pj1-x102b.google.com\n\t[IPv6:2607:f8b0:4864:20::102b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9EAB960137\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 31 Aug 2021 08:35:07 +0200 (CEST)", "by mail-pj1-x102b.google.com with SMTP id\n\td3-20020a17090ae28300b0019629c96f25so1646074pjz.2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 30 Aug 2021 23:35:07 -0700 (PDT)", "from hiroh2.tok.corp.google.com\n\t([2401:fa00:8f:203:3c62:aba4:18ea:5441])\n\tby smtp.gmail.com with ESMTPSA id\n\td17sm16304027pfn.110.2021.08.30.23.35.04\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 30 Aug 2021 23:35:05 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"bq1qarvb\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=Oi7VNQOpVLdn4SHrGSxhRVEEm/yhbmfU+hI02STYM+s=;\n\tb=bq1qarvbyTuSIm5KQ4B3mI5wMMgXVcaY+e0G2rt1IMBz+SgQQDqEH40//Vk2aV1nrC\n\thkWIb7F2rYa2+9k8fO8cviG+aPkrs5q/wygYNHt5AUyAS62GCe0JI6f+Kf5Oip08WScg\n\tZJQegB5dSjolGPcdWL9kp+OMPny8wiLoi2KRE=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=Oi7VNQOpVLdn4SHrGSxhRVEEm/yhbmfU+hI02STYM+s=;\n\tb=ocTNAn3RQQJS4h0rNVA/h8emt9KTgKRf1BpPC/+Tc2JDDFawOOpE2hoU6Hd3M3sF3O\n\tcy5zOqwgvHrA348tYfUR8ExrLOfBJ541GhaM2y2OCphH6lUdjvIJWq3qA/mT05PAVRIV\n\tdCfI2/T8tCrSX4ZrIvjBURL9SG1/lgEEuPDa7Buyy0EmiqwcdV4imffnH9bz54mG2yEg\n\tMR1KK8Q3oV8xFQtTiHItYIUZpPqWrxOHGtIdX75Tnqc/doGLbnkjdx6lXyZpawqykEXc\n\t6E7KsPzEpGSsu6RQn57vBITabqMYn5UlE+lgGuvcDJyoal2Xt9Peh4erL8/S+JCEgTNy\n\t6BDg==", "X-Gm-Message-State": "AOAM530J9yNYa9BDNF+YABb4FrMuHfsOEFXuB2iRnACWZbFKX940XgHy\n\teWxGgow6QGKe97bgPX1UtDpgrUuSTHIMtQ==", "X-Google-Smtp-Source": "ABdhPJwOTWPktF57eEcScbSlqhn7hoUXmUg/16HbJAgKE0BKP1f1EqCy4gHyLBPo1+ygPrP+W7B55g==", "X-Received": "by 2002:a17:902:724b:b0:131:ab33:1e4e with SMTP id\n\tc11-20020a170902724b00b00131ab331e4emr3251131pll.12.1630391705860; \n\tMon, 30 Aug 2021 23:35:05 -0700 (PDT)", "From": "Hirokazu Honda <hiroh@chromium.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 31 Aug 2021 15:34:35 +0900", "Message-Id": "<20210831063438.785767-3-hiroh@chromium.org>", "X-Mailer": "git-send-email 2.33.0.259.gc128427fd7-goog", "In-Reply-To": "<20210831063438.785767-1-hiroh@chromium.org>", "References": "<20210831063438.785767-1-hiroh@chromium.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 2/5] android: jpeg: thumbnailer: Use\n\tMappedFrameBuffer::planes()", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Thumbnailer gets the address of NV12 UV Plane by computing the\nfirst plane size. MappedFrameBuffer::planes() returns the plane\naddress. This replaces the address computation with\nMappedFrameBuffer::planes() in Thumbnailer.\n\nSigned-off-by: Hirokazu Honda <hiroh@chromium.org>\n---\n src/android/jpeg/thumbnailer.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/android/jpeg/thumbnailer.cpp b/src/android/jpeg/thumbnailer.cpp\nindex 043c7b33..fe2c4969 100644\n--- a/src/android/jpeg/thumbnailer.cpp\n+++ b/src/android/jpeg/thumbnailer.cpp\n@@ -63,7 +63,7 @@ void Thumbnailer::createThumbnail(const FrameBuffer &source,\n \n \t/* Image scaling block implementing nearest-neighbour algorithm. */\n \tunsigned char *src = static_cast<unsigned char *>(frame.planes()[0].data());\n-\tunsigned char *srcC = src + sh * sw;\n+\tunsigned char *srcC = static_cast<unsigned char *>(frame.planes()[1].data());\n \tunsigned char *srcCb, *srcCr;\n \tunsigned char *dstY, *srcY;\n \n", "prefixes": [ "libcamera-devel", "2/5" ] }