Patch Detail
Show a patch.
GET /api/1.1/patches/13562/?format=api
{ "id": 13562, "url": "https://patchwork.libcamera.org/api/1.1/patches/13562/?format=api", "web_url": "https://patchwork.libcamera.org/patch/13562/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210828181824.378795-1-vedantparanjape160201@gmail.com>", "date": "2021-08-28T18:18:24", "name": "[libcamera-devel,v1] test: gstreamer: Add minimal validation of camera output", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "dcb5d00a286ff04ddb721c6aab2d5be1e774f2c9", "submitter": { "id": 85, "url": "https://patchwork.libcamera.org/api/1.1/people/85/?format=api", "name": "Vedant Paranjape", "email": "vedantparanjape160201@gmail.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/13562/mbox/", "series": [ { "id": 2416, "url": "https://patchwork.libcamera.org/api/1.1/series/2416/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2416", "date": "2021-08-28T18:18:24", "name": "[libcamera-devel,v1] test: gstreamer: Add minimal validation of camera output", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2416/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/13562/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/13562/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1B192BD87D\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSat, 28 Aug 2021 18:18:43 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 36E906916C;\n\tSat, 28 Aug 2021 20:18:42 +0200 (CEST)", "from mail-pf1-x430.google.com (mail-pf1-x430.google.com\n\t[IPv6:2607:f8b0:4864:20::430])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5114D61534\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 28 Aug 2021 20:18:41 +0200 (CEST)", "by mail-pf1-x430.google.com with SMTP id s29so3866065pfw.5\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 28 Aug 2021 11:18:41 -0700 (PDT)", "from localhost.localdomain ([1.186.166.201])\n\tby smtp.googlemail.com with ESMTPSA id\n\tv20sm11181847pgi.39.2021.08.28.11.18.38\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSat, 28 Aug 2021 11:18:39 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"HL3lJVri\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=Tt01e3/54b6MIVYvAyzcO8G89O4BFMhZz+5X1S/qWUg=;\n\tb=HL3lJVriOQxU/wsIWlzwqHhE8GJjK+3At6Qu0jZutTe6kPgtdmVpFjU6yaEbzxC5ys\n\tAV6kHd+R6wvLEbTCxapJ/NjhqDOcgHhMuoS35hBF/rv+XKrPV1yHA8qXj2cOMlx1msTB\n\tUH2oMtkv0rxjPqSbRHcKonYbu/wX2gpiqflxyWz9ZuIWADhKXdHYtIz+9SnO3FMf6Wnd\n\t7fazs6ddFeOLPEKMowVY5NDvP/A4yeK/mcc3WrhjFptY/xnQ3ctSRw4oSgACMGv9TWJn\n\tj5uY7Imv3Olpft83OKwLrBp26wIS9oYWXI2vuSJbL1Yu6JQTXbQdR6aw3qjxNdduN6L9\n\t1kUA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=Tt01e3/54b6MIVYvAyzcO8G89O4BFMhZz+5X1S/qWUg=;\n\tb=DLEtes9/nFwvoya9lUUY+ulqbnvcHj7fpRxuO9KDWxUSVStU0iqg2uMNo/RvBDVz44\n\t5EqcbpygcnAhEMPbi3flQ1wmCKRXvxYj8FHi7tJJ+ejVgDwhK9UsEiZ82atOxz1L2QsK\n\ti3uEznZO/kMx5D3RZRuKQSEsQMXvTarmKMxhFPtLQyKdCC9krMdYPimppPVq5MnAxqfN\n\t1rSM6AbYa4vto0ljxCaWp9U/2hNYdmdqsKSmP41ndWrS0JF+bQZHLWyIR50w1Q1YzSR5\n\t/KHf38Z9QGPOdxvesQRy1wO708l6jVcEKXJoNgJysK/V6SZWZo++OvmaysLXUgZoiMo5\n\tddrw==", "X-Gm-Message-State": "AOAM533k87sEQGkG17i+V4GnD/0zCJaZuVsDPPng8MzU45tdfNZi1pUz\n\tlHUpPZTEvFjOCEh3D3qvRyDc6OKlfDyA3uH1", "X-Google-Smtp-Source": "ABdhPJzLZrI8toT7rEX9FW8DKPrJyuZGqYWewZksa061V6xMaVXLUpwm/W5xmhTIHIc9CD08i5ERSg==", "X-Received": "by 2002:aa7:8e4f:0:b0:3ee:27d5:28bc with SMTP id\n\td15-20020aa78e4f000000b003ee27d528bcmr15114416pfr.24.1630174719506; \n\tSat, 28 Aug 2021 11:18:39 -0700 (PDT)", "From": "Vedant Paranjape <vedantparanjape160201@gmail.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sat, 28 Aug 2021 23:48:24 +0530", "Message-Id": "<20210828181824.378795-1-vedantparanjape160201@gmail.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v1] test: gstreamer: Add minimal\n\tvalidation of camera output", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Cc": "Vedant Paranjape <vedantparanjape160201@gmail.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Read stats property of fakesink which has Sink Statistics, It is\nexpected to be a non-zero number after running gstreamer element\nfor two seconds.\n\nSigned-off-by: Vedant Paranjape <vedantparanjape160201@gmail.com>\n---\n> I would like some minimal validation. I would expect that after 2s some frames\n> got \"rendered\" properly. You can read the GstStructure property \"stats\" from\n> fakevideosink / fakesink, and read the \"rendered\" field. Make sure this not zero\n> perhaps ?\n\nThis change was suggested by Nicolas Dufresne <nicolas@ndufresne.ca> in the\nmailing list \n---\n test/gstreamer/gstreamer_single_stream_test.cpp | 7 +++++++\n 1 file changed, 7 insertions(+)", "diff": "diff --git a/test/gstreamer/gstreamer_single_stream_test.cpp b/test/gstreamer/gstreamer_single_stream_test.cpp\nindex 4c8d4804..5d56e762 100644\n--- a/test/gstreamer/gstreamer_single_stream_test.cpp\n+++ b/test/gstreamer/gstreamer_single_stream_test.cpp\n@@ -134,8 +134,15 @@ protected:\n \t\tg_autoptr(GstBus) bus = gst_element_get_bus(pipeline_);\n \t\tg_autoptr(GstMessage) msg = gst_bus_timed_pop_filtered(bus, timeout, msgType);\n \n+\t\tgint sinkStats;\n+\t\tg_object_get(sink0_, \"stats\", &sinkStats, NULL);\n+\n \t\tgst_element_set_state(pipeline_, GST_STATE_NULL);\n \n+\t\tif (sinkStats <= 0) {\n+\t\t\treturn TestFail;\n+\t\t}\n+\n \t\t/* Parse error message */\n \t\tif (msg == NULL)\n \t\t\treturn TestPass;\n", "prefixes": [ "libcamera-devel", "v1" ] }