Patch Detail
Show a patch.
GET /api/1.1/patches/13506/?format=api
{ "id": 13506, "url": "https://patchwork.libcamera.org/api/1.1/patches/13506/?format=api", "web_url": "https://patchwork.libcamera.org/patch/13506/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210826112539.170694-7-hiroh@chromium.org>", "date": "2021-08-26T11:25:36", "name": "[libcamera-devel,v3,6/9] gstreamer: gstlibcameraallocator: Use offset in creating a buffer", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "2499ed8f8a7c7552983c7a2b82037be2514e30cc", "submitter": { "id": 63, "url": "https://patchwork.libcamera.org/api/1.1/people/63/?format=api", "name": "Hirokazu Honda", "email": "hiroh@chromium.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/13506/mbox/", "series": [ { "id": 2398, "url": "https://patchwork.libcamera.org/api/1.1/series/2398/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2398", "date": "2021-08-26T11:25:30", "name": "Add offset to FrameBuffer::Plane", "version": 3, "mbox": "https://patchwork.libcamera.org/series/2398/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/13506/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/13506/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 429A2C3242\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 26 Aug 2021 11:26:00 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D0F3168918;\n\tThu, 26 Aug 2021 13:25:59 +0200 (CEST)", "from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com\n\t[IPv6:2607:f8b0:4864:20::102d])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1C2726891B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 26 Aug 2021 13:25:58 +0200 (CEST)", "by mail-pj1-x102d.google.com with SMTP id mq3so1972271pjb.5\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 26 Aug 2021 04:25:58 -0700 (PDT)", "from hiroh2.tok.corp.google.com\n\t([2401:fa00:8f:203:a5bc:b3dd:7208:bec1])\n\tby smtp.gmail.com with ESMTPSA id\n\ts29sm3472057pgl.38.2021.08.26.04.25.54\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 26 Aug 2021 04:25:55 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"XcNJu1pc\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=w3io4ICj3+SqN8WinyGtF95ZiA98f5dYRzFd6Imr/mY=;\n\tb=XcNJu1pcFv4ezLL3mn6zO2tEPAhoBiJZzbNU6ITJQfzd/LzI9DaazqSVyAjb20gzV5\n\tE4ZLh+EGnZHcU0aSDSBcgJKcTIHqQKi/tAfrrgQvampUbSngF/qZHReVH3sNaceE1VvJ\n\tWre+kDLqCAxLmOmXpyqYDJzfOIpv0EltO07Xo=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=w3io4ICj3+SqN8WinyGtF95ZiA98f5dYRzFd6Imr/mY=;\n\tb=eTvDnwCBKyp8CX+UMbodFzxE4bZMSAZA15JPMzKpIxdmcD5nuPc6DS6JhpYWYihAar\n\t6f9GzcZWBMFZ1eaieW6tM7kpIds9dxpWRS3HyKTY5P8tZXQedygOEa/L3mPVKCrJFqdH\n\tKBaIYSOYri7Csev7rKW+23UhylQ+JoGFRnDvaK1yDmrvyR2sYrz4PmtAucvjhHQ+Xxo3\n\t/y5V1r1V74Nv+h+4Q9yij0oglbahlZDqxUc69twAN+DD9BAnOkMFkGnoMONrWcRdL4uo\n\tzZrtGKMXYhTNNvhNt0Myq0WmDeKh9ZVlw5A0kuwq5Lai3vOjhqfhdbY4jjBux8SEhKIL\n\t9/oA==", "X-Gm-Message-State": "AOAM532AtRieKr0I0qJEbEle4dG/y+ipMEBz08jQFaTDFsaDvGdHrRtg\n\tczlT77z8vKugHxiIeT4frG+b8/jCy1OKtw==", "X-Google-Smtp-Source": "ABdhPJwJudQ0T46wu5edtVH3PyDj57kM3dlctnvBBMCA8u9ge5/W+Yj3T/Kn2pwoZDykikRjNEZfQA==", "X-Received": "by 2002:a17:902:dac6:b0:138:85a7:ef80 with SMTP id\n\tq6-20020a170902dac600b0013885a7ef80mr1470898plx.45.1629977156410; \n\tThu, 26 Aug 2021 04:25:56 -0700 (PDT)", "From": "Hirokazu Honda <hiroh@chromium.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 26 Aug 2021 20:25:36 +0900", "Message-Id": "<20210826112539.170694-7-hiroh@chromium.org>", "X-Mailer": "git-send-email 2.33.0.rc2.250.ged5fa647cd-goog", "In-Reply-To": "<20210826112539.170694-1-hiroh@chromium.org>", "References": "<20210826112539.170694-1-hiroh@chromium.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v3 6/9] gstreamer: gstlibcameraallocator:\n\tUse offset in creating a buffer", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Cc": "Nicolas Dufresne <nicolas.dufresne@collabora.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The plane length is the length of the plane size. The buffer length\nto be allocated for a plane is the offset and the length of\nFrameBuffer::Plane.\n\nSigned-off-by: Hirokazu Honda <hiroh@chromium.org>\nReviewed-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>\n---\n src/gstreamer/gstlibcameraallocator.cpp | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/gstreamer/gstlibcameraallocator.cpp b/src/gstreamer/gstlibcameraallocator.cpp\nindex 7bd8ba2d..60ead273 100644\n--- a/src/gstreamer/gstlibcameraallocator.cpp\n+++ b/src/gstreamer/gstlibcameraallocator.cpp\n@@ -52,8 +52,10 @@ FrameWrap::FrameWrap(GstAllocator *allocator, FrameBuffer *buffer,\n \t outstandingPlanes_(0)\n {\n \tfor (const FrameBuffer::Plane &plane : buffer->planes()) {\n-\t\tGstMemory *mem = gst_fd_allocator_alloc(allocator, plane.fd.fd(), plane.length,\n+\t\tGstMemory *mem = gst_fd_allocator_alloc(allocator, plane.fd.fd(),\n+\t\t\t\t\t\t\tplane.offset + plane.length,\n \t\t\t\t\t\t\tGST_FD_MEMORY_FLAG_DONT_CLOSE);\n+\t\tgst_memory_resize(mem, plane.offset, plane.length);\n \t\tgst_mini_object_set_qdata(GST_MINI_OBJECT(mem), getQuark(), this, nullptr);\n \t\tGST_MINI_OBJECT(mem)->dispose = gst_libcamera_allocator_release;\n \t\tg_object_unref(mem->allocator);\n", "prefixes": [ "libcamera-devel", "v3", "6/9" ] }