Patch Detail
Show a patch.
GET /api/1.1/patches/13460/?format=api
{ "id": 13460, "url": "https://patchwork.libcamera.org/api/1.1/patches/13460/?format=api", "web_url": "https://patchwork.libcamera.org/patch/13460/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210824142450.3157833-3-kieran.bingham@ideasonboard.com>", "date": "2021-08-24T14:24:48", "name": "[libcamera-devel,SimpleCam,2/4] simple-cam: Improve documentation of validate/configure", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "68aff7b654fb9788bbe28bbee240efe328a35a8e", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/1.1/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/13460/mbox/", "series": [ { "id": 2388, "url": "https://patchwork.libcamera.org/api/1.1/series/2388/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2388", "date": "2021-08-24T14:24:46", "name": "Improve CameraManager usage and Doc", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2388/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/13460/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/13460/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 760FFBD87D\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 24 Aug 2021 14:24:58 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3470E6890C;\n\tTue, 24 Aug 2021 16:24:58 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AD26E60505\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 24 Aug 2021 16:24:55 +0200 (CEST)", "from Monstersaurus.local\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 528E1BB0;\n\tTue, 24 Aug 2021 16:24:55 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"o4JCQjj+\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1629815095;\n\tbh=twq6yGjSB8kHCTaxcagHrXyuUDPduGOV7Sjn0uuA3xE=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=o4JCQjj+ddymsjRVBZpwidCeurOuZ3CtZdQVtgbf7j2+urDP7iIfF1LnHSRVNM/4a\n\tBqQWKM4bYKcX3Y7EOdUaJgZU2fF0/KsO0mVquSX9gl8+y8LIVC5REPqCni2SzmfYCQ\n\t3hooEg0C8MoXzFxxj7C9/nygJSFmWws4uSRQXdl0=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Date": "Tue, 24 Aug 2021 15:24:48 +0100", "Message-Id": "<20210824142450.3157833-3-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20210824142450.3157833-1-kieran.bingham@ideasonboard.com>", "References": "<20210824142450.3157833-1-kieran.bingham@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [SimpleCam PATCH 2/4] simple-cam: Improve\n\tdocumentation of validate/configure", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The validation and configure phase has a couple of grammatical errors.\nFix them and reflow the text accordingly.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n simple-cam.cpp | 9 +++++----\n 1 file changed, 5 insertions(+), 4 deletions(-)", "diff": "diff --git a/simple-cam.cpp b/simple-cam.cpp\nindex 5c16db67700c..2e646a5485c9 100644\n--- a/simple-cam.cpp\n+++ b/simple-cam.cpp\n@@ -255,16 +255,17 @@ int main()\n #endif\n \n \t/*\n-\t * Validating a CameraConfiguration -before- applying it adjust it\n-\t * to a valid configuration as closest as possible to the requested one.\n+\t * Validating a CameraConfiguration -before- applying it will adjust it\n+\t * to a valid configuration which is as close as possible to the one\n+\t * requested.\n \t */\n \tconfig->validate();\n \tstd::cout << \"Validated viewfinder configuration is: \"\n \t\t << streamConfig.toString() << std::endl;\n \n \t/*\n-\t * Once we have a validate configuration, we can apply it\n-\t * to the Camera.\n+\t * Once we have a validated configuration, we can apply it to the\n+\t * Camera.\n \t */\n \tcamera->configure(config.get());\n \n", "prefixes": [ "libcamera-devel", "SimpleCam", "2/4" ] }