Patch Detail
Show a patch.
GET /api/1.1/patches/1345/?format=api
{ "id": 1345, "url": "https://patchwork.libcamera.org/api/1.1/patches/1345/?format=api", "web_url": "https://patchwork.libcamera.org/patch/1345/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190603231637.28554-9-paul.elder@ideasonboard.com>", "date": "2019-06-03T23:16:35", "name": "[libcamera-devel,v2,08/10] libcamera: test: remove test IPA and use dummy IPA instead", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "c34defbbc8008ada92eedc163e706d20fb1155ca", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/1.1/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/1345/mbox/", "series": [ { "id": 335, "url": "https://patchwork.libcamera.org/api/1.1/series/335/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=335", "date": "2019-06-03T23:16:27", "name": "Add IPAManager and IPAInterface", "version": 2, "mbox": "https://patchwork.libcamera.org/series/335/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/1345/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/1345/checks/", "tags": {}, "headers": { "Return-Path": "<paul.elder@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C169D618F9\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 4 Jun 2019 01:16:52 +0200 (CEST)", "from localhost.localdomain (unknown [96.44.9.117])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0E76284;\n\tTue, 4 Jun 2019 01:16:51 +0200 (CEST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1559603812;\n\tbh=sHLLuBNWxFbYSA4h91sOZVYyUfLGEs8Xoe6s7WHXwkE=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=FgnbvTpRNPFlCN9q1qxsgW9VpcAHO/P7gbRMxHl9JNjTu0hijOdC5fghgFIjkzrH4\n\tU3P5rhtfBcE0FO9zCjMwE6Kmz1HrRLCN7hoUvAW4piyZ0+c/uNEOmyiw2KuWWnDJQx\n\tMj+PbyihSFErAdtDZaQeSrwg7XkPleD5ktiqKf0g=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 3 Jun 2019 19:16:35 -0400", "Message-Id": "<20190603231637.28554-9-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190603231637.28554-1-paul.elder@ideasonboard.com>", "References": "<20190603231637.28554-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 08/10] libcamera: test: remove test IPA\n\tand use dummy IPA instead", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Mon, 03 Jun 2019 23:16:53 -0000" }, "content": "Use the dummy IPA for testing/sample IPA instead of the earlier test\nIPA. Remove the test IPA, and update tests and meson accordingly.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\nChanges in v2:\n- use macros for defining the fields in the expected IPA module info\n\n test/ipa/ipa_test.cpp | 8 ++++----\n test/ipa/meson.build | 10 ----------\n test/libtest/test.cpp | 2 +-\n 3 files changed, 5 insertions(+), 15 deletions(-)", "diff": "diff --git a/test/ipa/ipa_test.cpp b/test/ipa/ipa_test.cpp\nindex d7b18c7..f401e29 100644\n--- a/test/ipa/ipa_test.cpp\n+++ b/test/ipa/ipa_test.cpp\n@@ -59,12 +59,12 @@ protected:\n \n \t\tconst struct IPAModuleInfo testInfo = {\n \t\t\tIPA_MODULE_API_VERSION,\n-\t\t\tPIPELINE_VERSION(0, 9001),\n-\t\t\t\"bleep\",\n-\t\t\t\"It's over nine thousand!\",\n+\t\t\tPIPELINE_VERSION(0, 1),\n+\t\t\t\"PipelineHandlerVimc\",\n+\t\t\t\"Dummy IPA for Vimc\",\n \t\t};\n \n-\t\tcount += runTest(\"test/ipa/ipa-dummy-cpp.so\", testInfo);\n+\t\tcount += runTest(\"src/ipa/ipa_dummy.so\", testInfo);\n \n \t\tif (count < 0)\n \t\t\treturn TestFail;\ndiff --git a/test/ipa/meson.build b/test/ipa/meson.build\nindex 08ee95c..bca39fa 100644\n--- a/test/ipa/meson.build\n+++ b/test/ipa/meson.build\n@@ -1,13 +1,3 @@\n-ipa_modules_sources = [\n- ['ipa-dummy-cpp', 'shared_test.cpp'],\n-]\n-\n-foreach m : ipa_modules_sources\n- shared_library(m, name_prefix : '',\n- dependencies : libcamera_dep,\n- include_directories : test_includes_public)\n-endforeach\n-\n ipa_test = [\n ['ipa_test', 'ipa_test.cpp'],\n ]\ndiff --git a/test/libtest/test.cpp b/test/libtest/test.cpp\nindex 451c111..a0c5102 100644\n--- a/test/libtest/test.cpp\n+++ b/test/libtest/test.cpp\n@@ -21,7 +21,7 @@ int Test::execute()\n {\n \tint ret;\n \n-\tret = setenv(\"IPA_MODULE_PATH\", \"test/ipa\", 1);\n+\tret = setenv(\"IPA_MODULE_PATH\", \"src/ipa\", 1);\n \tif (ret)\n \t\treturn errno;\n \n", "prefixes": [ "libcamera-devel", "v2", "08/10" ] }