Patch Detail
Show a patch.
GET /api/1.1/patches/13429/?format=api
{ "id": 13429, "url": "https://patchwork.libcamera.org/api/1.1/patches/13429/?format=api", "web_url": "https://patchwork.libcamera.org/patch/13429/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210823094806.1434280-2-paul.elder@ideasonboard.com>", "date": "2021-08-23T09:48:06", "name": "[libcamera-devel,RFC,2/2] DNI: pipeline: ipu3: Set Sharpness control and control info", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "7e9b4950cde3a6fc6221be4c7702eaaf6012f738", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/1.1/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": { "id": 17, "url": "https://patchwork.libcamera.org/api/1.1/users/17/?format=api", "username": "epaul", "first_name": "Paul", "last_name": "Elder", "email": "paul.elder@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/patch/13429/mbox/", "series": [ { "id": 2382, "url": "https://patchwork.libcamera.org/api/1.1/series/2382/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2382", "date": "2021-08-23T09:48:05", "name": "[libcamera-devel,RFC,1/2] android: Plumb Sharpness control into EDGE_MODE", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2382/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/13429/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/13429/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0B24BBD87C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 23 Aug 2021 09:48:30 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B03B0688A6;\n\tMon, 23 Aug 2021 11:48:29 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9C5AD68893\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 23 Aug 2021 11:48:28 +0200 (CEST)", "from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 191162A5;\n\tMon, 23 Aug 2021 11:48:26 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"NouPLg0g\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1629712108;\n\tbh=TBdp+o6eQGxSdHS8ni1qZ3t8FCanEs9PcsOC7AbI4ng=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=NouPLg0gPpgC16+61sMxJ29JtOirEAe6vk3gBmsiaPrrHaPWqN1VT4lNg2+DeynEQ\n\tKhEl7Fr+U5Td0UPk7J7aGVRfdagVnlOFVMrUJQlhj+wDTjvHu6a6GlR/yD6OOQ8sjN\n\tvRk9VsMYdItsjpjj2KRT6jLKzYpXBDtbDuV9YfWU=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 23 Aug 2021 18:48:06 +0900", "Message-Id": "<20210823094806.1434280-2-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20210823094806.1434280-1-paul.elder@ideasonboard.com>", "References": "<20210823094806.1434280-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [RFC PATCH 2/2] DNI: pipeline: ipu3: Set\n\tSharpness control and control info", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "This is to demonstrate reporting and setting Sharpness on ipu3.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\n---\n src/libcamera/pipeline/ipu3/ipu3.cpp | 7 +++++++\n 1 file changed, 7 insertions(+)", "diff": "diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex a98d7eff..e90659e3 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -50,6 +50,7 @@ static constexpr unsigned int IMGU_OUTPUT_HEIGHT_MARGIN = 32;\n static constexpr Size IPU3ViewfinderSize(1280, 720);\n \n static const ControlInfoMap::Map IPU3Controls = {\n+\t{ &controls::Sharpness, ControlInfo(0.0f, 1.0f, 0.0f) },\n \t{ &controls::draft::PipelineDepth, ControlInfo(2, 3) },\n };\n \n@@ -1299,6 +1300,12 @@ void IPU3CameraData::imguOutputBufferReady(FrameBuffer *buffer)\n \t\tcropRegion_ = request->controls().get(controls::ScalerCrop);\n \trequest->metadata().set(controls::ScalerCrop, cropRegion_);\n \n+\t/* \\todo Actually apply sharpness. */\n+\tif (request->controls().contains(controls::Sharpness)) {\n+\t\tfloat val = request->controls().get<float>(controls::Sharpness);\n+\t\trequest->metadata().set(controls::Sharpness, val);\n+\t}\n+\n \tif (frameInfos_.tryComplete(info))\n \t\tpipe()->completeRequest(request);\n }\n", "prefixes": [ "libcamera-devel", "RFC", "2/2" ] }