Patch Detail
Show a patch.
GET /api/1.1/patches/13375/?format=api
{ "id": 13375, "url": "https://patchwork.libcamera.org/api/1.1/patches/13375/?format=api", "web_url": "https://patchwork.libcamera.org/patch/13375/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210817122646.185978-2-umang.jain@ideasonboard.com>", "date": "2021-08-17T12:26:45", "name": "[libcamera-devel,1/2] libtest: camera_test: Plumb constructor to set LIBCAMERA_IPA_FORCE_ISOLATION", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "8fa01e05ad587b45de6d7209861a800fd46baef9", "submitter": { "id": 86, "url": "https://patchwork.libcamera.org/api/1.1/people/86/?format=api", "name": "Umang Jain", "email": "umang.jain@ideasonboard.com" }, "delegate": { "id": 12, "url": "https://patchwork.libcamera.org/api/1.1/users/12/?format=api", "username": "uajain", "first_name": "Umang", "last_name": "Jain", "email": "umang.jain@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/patch/13375/mbox/", "series": [ { "id": 2364, "url": "https://patchwork.libcamera.org/api/1.1/series/2364/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2364", "date": "2021-08-17T12:26:44", "name": "Fd leak test", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2364/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/13375/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/13375/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 35A2ABD87D\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 17 Aug 2021 12:26:59 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D5BFB688A6;\n\tTue, 17 Aug 2021 14:26:58 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DF52F6888F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 17 Aug 2021 14:26:57 +0200 (CEST)", "from perceval.ideasonboard.com (unknown [103.238.109.15])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DCE222C5;\n\tTue, 17 Aug 2021 14:26:56 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"i1RYxCxB\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1629203217;\n\tbh=ck5dFBsMkrO/ZDCye5tpi3cjmrLCxmb7Haa/ZSjIUTw=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=i1RYxCxB2eAJJDSagWAIMQLcIhDDwo0yNGAEmH/lTBA5BEDJdbTuZOO1QtWcloGjV\n\tYz12C1TqVqhN4B6c8HyYu09mYQQo+PxcG+b2tU63q1AQK8Ps88rlxsujCFoyNGKrjE\n\tMGNTpI+YC0E41dEcua4tESDQcKuVmFx6F7tMzV3E=", "From": "Umang Jain <umang.jain@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 17 Aug 2021 17:56:45 +0530", "Message-Id": "<20210817122646.185978-2-umang.jain@ideasonboard.com>", "X-Mailer": "git-send-email 2.31.1", "In-Reply-To": "<20210817122646.185978-1-umang.jain@ideasonboard.com>", "References": "<20210817122646.185978-1-umang.jain@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 1/2] libtest: camera_test: Plumb\n\tconstructor to set LIBCAMERA_IPA_FORCE_ISOLATION", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Some tests might require to have LIBCAMERA_IPA_FORCE_ISOLATION set\nto ensure they can test the IPA running in isolated mode. These tests\nare likely to leverage CameraTest. The environment variable should\nbe set before CameraManager::start() call which happens in CameraTest's\nconstructor. Hence, plumb the constructor with a flag so that the\nLIBCAMERA_IPA_FORCE_ISOLATION can be set before CameraManager::start().\n\nSigned-off-by: Umang Jain <umang.jain@ideasonboard.com>\n---\n test/libtest/camera_test.cpp | 5 ++++-\n test/libtest/camera_test.h | 2 +-\n 2 files changed, 5 insertions(+), 2 deletions(-)", "diff": "diff --git a/test/libtest/camera_test.cpp b/test/libtest/camera_test.cpp\nindex 2ae4d677..9cbc4d82 100644\n--- a/test/libtest/camera_test.cpp\n+++ b/test/libtest/camera_test.cpp\n@@ -13,10 +13,13 @@\n using namespace libcamera;\n using namespace std;\n \n-CameraTest::CameraTest(const char *name)\n+CameraTest::CameraTest(const char *name, bool isolate)\n {\n \tcm_ = new CameraManager();\n \n+\tif (isolate)\n+\t\tsetenv(\"LIBCAMERA_IPA_FORCE_ISOLATION\", \"TRUE\", 1);\n+\n \tif (cm_->start()) {\n \t\tcerr << \"Failed to start camera manager\" << endl;\n \t\tstatus_ = TestFail;\ndiff --git a/test/libtest/camera_test.h b/test/libtest/camera_test.h\nindex 7939798f..f56e343e 100644\n--- a/test/libtest/camera_test.h\n+++ b/test/libtest/camera_test.h\n@@ -17,7 +17,7 @@ using namespace libcamera;\n class CameraTest\n {\n public:\n-\tCameraTest(const char *name);\n+\tCameraTest(const char *name, bool isolate = false);\n \t~CameraTest();\n \n protected:\n", "prefixes": [ "libcamera-devel", "1/2" ] }