Patch Detail
Show a patch.
GET /api/1.1/patches/13359/?format=api
{ "id": 13359, "url": "https://patchwork.libcamera.org/api/1.1/patches/13359/?format=api", "web_url": "https://patchwork.libcamera.org/patch/13359/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210816043138.957984-2-hiroh@chromium.org>", "date": "2021-08-16T04:31:29", "name": "[libcamera-devel,RFC,01/10] libcamera: framebuffer: Add offset to FrameBuffer::Plane", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "178cabc1fd0b2f9fc7d73efbe9d47f3154cda0ad", "submitter": { "id": 63, "url": "https://patchwork.libcamera.org/api/1.1/people/63/?format=api", "name": "Hirokazu Honda", "email": "hiroh@chromium.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/13359/mbox/", "series": [ { "id": 2359, "url": "https://patchwork.libcamera.org/api/1.1/series/2359/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2359", "date": "2021-08-16T04:31:28", "name": "Add offset to FrameBuffer::Plane", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2359/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/13359/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/13359/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 533EAC3241\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 16 Aug 2021 04:31:50 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3834368894;\n\tMon, 16 Aug 2021 06:31:49 +0200 (CEST)", "from mail-pl1-x62e.google.com (mail-pl1-x62e.google.com\n\t[IPv6:2607:f8b0:4864:20::62e])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4CFF26888A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 16 Aug 2021 06:31:48 +0200 (CEST)", "by mail-pl1-x62e.google.com with SMTP id a5so19385681plh.5\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 15 Aug 2021 21:31:48 -0700 (PDT)", "from hiroh2.tok.corp.google.com\n\t([2401:fa00:8f:203:6f5f:1479:a6ab:4229])\n\tby smtp.gmail.com with ESMTPSA id\n\tu10sm2767417pgj.48.2021.08.15.21.31.44\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSun, 15 Aug 2021 21:31:46 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"EafXNiny\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=O8KjuN3pQ3H8El8/lL+5eqPsdn/Esip4kifoaHHNeUs=;\n\tb=EafXNinylckofYhe9+3Le9A6tfmOfYTlYt/GM8jXO1FiIfcaFUO2/ka/egUutpZo5f\n\to6grWE/p1/oqcZzm/srRIXgacg31fymXVXYvcnCAUp+DF1ESdD3piQo+r9z+bmPC507q\n\tCEE1wRL83FIXA4PxleDd8xbiXsk3NZXs87nIY=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=O8KjuN3pQ3H8El8/lL+5eqPsdn/Esip4kifoaHHNeUs=;\n\tb=DcggiVtsRnTVD9T4J9dndKt5CWi1jXTU3HgjlS5iyv7UxPlXcjbHnXIhdqH8lVBOoy\n\t7C49+Jo0lhuqlwDhPd0CFSX635MdiPZ8vAIsktZeUY6oxOhPf1kUPCb83LM6YQ5CXjvP\n\tBvj4jIhweb4opBl2lwGyiE1Q29s+DKlBoPIE37bIVeelQmx78TtzIMMluDjACuI22EkM\n\tBXzWx9ECNDtIy4JUzKLijpHoiaFM9WYl2r3iRJrDQlNFDWhs4DCS8xpQHL/86xmKovyd\n\tr2L/rMnToUZEeOyuzl0zWF9wyzX6Z3zVlZTaV2z8DS46eRa/TUdV4fJeQsfoSnSdChHt\n\t3llA==", "X-Gm-Message-State": "AOAM531LMLlYNDnTdoXCAGv4D7GEiGfADE51kGxylhV41lO3s0OzsUR9\n\tz+oL6J8lbbPnd6FRiSVg4bcVFZc9eSrIMw==", "X-Google-Smtp-Source": "ABdhPJyuwbWJdc4C2F7LKtm4iSIM3OmJ5c9qXmsMeisqTLDe2G577h11p+gKXXp/yr4NQFRNOgeMRg==", "X-Received": "by 2002:a17:90a:4d8e:: with SMTP id\n\tm14mr15153782pjh.106.1629088306426; \n\tSun, 15 Aug 2021 21:31:46 -0700 (PDT)", "From": "Hirokazu Honda <hiroh@chromium.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 16 Aug 2021 13:31:29 +0900", "Message-Id": "<20210816043138.957984-2-hiroh@chromium.org>", "X-Mailer": "git-send-email 2.33.0.rc1.237.g0d66db33f3-goog", "In-Reply-To": "<20210816043138.957984-1-hiroh@chromium.org>", "References": "<20210816043138.957984-1-hiroh@chromium.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [RFC PATCH 01/10] libcamera: framebuffer: Add\n\toffset to FrameBuffer::Plane", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "This adds offset to FrameBuffer::Plane. It enables represents V4L2\nmulti-planar format and mapping with MappedFrameBuffer.\n\nSigned-off-by: Hirokazu Honda <hiroh@chromium.org>\n---\n include/libcamera/framebuffer.h | 1 +\n src/libcamera/framebuffer.cpp | 11 ++++++++---\n 2 files changed, 9 insertions(+), 3 deletions(-)", "diff": "diff --git a/include/libcamera/framebuffer.h b/include/libcamera/framebuffer.h\nindex 28307890..5de3c744 100644\n--- a/include/libcamera/framebuffer.h\n+++ b/include/libcamera/framebuffer.h\n@@ -42,6 +42,7 @@ class FrameBuffer final : public Extensible\n public:\n \tstruct Plane {\n \t\tFileDescriptor fd;\n+\t\tunsigned int offset;\n \t\tunsigned int length;\n \t};\n \ndiff --git a/src/libcamera/framebuffer.cpp b/src/libcamera/framebuffer.cpp\nindex 42c73134..1d7d5ea3 100644\n--- a/src/libcamera/framebuffer.cpp\n+++ b/src/libcamera/framebuffer.cpp\n@@ -131,7 +131,7 @@ FrameBuffer::Private::Private()\n *\n * The static information describes the memory planes that make a frame. The\n * planes are specified when creating the FrameBuffer and are expressed as a set\n- * of dmabuf file descriptors and length.\n+ * of dmabuf file descriptors, offset and length.\n *\n * The dynamic information is grouped in a FrameMetadata instance. It is updated\n * during the processing of a queued capture request, and is valid from the\n@@ -151,8 +151,8 @@ FrameBuffer::Private::Private()\n *\n * Planar pixel formats use multiple memory regions to store the different\n * colour components of a frame. The Plane structure describes such a memory\n- * region by a dmabuf file descriptor and a length. A FrameBuffer then\n- * contains one or multiple planes, depending on the pixel format of the\n+ * region by a dmabuf file descriptor, an offset and a length. A FrameBuffer\n+ * then contains one or multiple planes, depending on the pixel format of the\n * frames it is meant to store.\n *\n * To support DMA access, planes are associated with dmabuf objects represented\n@@ -170,6 +170,11 @@ FrameBuffer::Private::Private()\n * \\brief The dmabuf file descriptor\n */\n \n+/**\n+ * \\var FrameBuffer::Plane::offset\n+ * \\brief The plane offset in bytes\n+*/\n+\n /**\n * \\var FrameBuffer::Plane::length\n * \\brief The plane length in bytes\n", "prefixes": [ "libcamera-devel", "RFC", "01/10" ] }