Patch Detail
Show a patch.
GET /api/1.1/patches/13349/?format=api
{ "id": 13349, "url": "https://patchwork.libcamera.org/api/1.1/patches/13349/?format=api", "web_url": "https://patchwork.libcamera.org/patch/13349/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210813144437.138005-3-umang.jain@ideasonboard.com>", "date": "2021-08-13T14:44:35", "name": "[libcamera-devel,v2,2/4] pipeline: vimc: Allocate fake IPA buffers", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "f6de2dc45adb32fb05a05c26f333db1fa66f6a01", "submitter": { "id": 86, "url": "https://patchwork.libcamera.org/api/1.1/people/86/?format=api", "name": "Umang Jain", "email": "umang.jain@ideasonboard.com" }, "delegate": { "id": 12, "url": "https://patchwork.libcamera.org/api/1.1/users/12/?format=api", "username": "uajain", "first_name": "Umang", "last_name": "Jain", "email": "umang.jain@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/patch/13349/mbox/", "series": [ { "id": 2356, "url": "https://patchwork.libcamera.org/api/1.1/series/2356/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2356", "date": "2021-08-13T14:44:33", "name": "Pass buffers to VIMC IPA", "version": 2, "mbox": "https://patchwork.libcamera.org/series/2356/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/13349/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/13349/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 92956C3240\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 13 Aug 2021 14:44:54 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4780968894;\n\tFri, 13 Aug 2021 16:44:54 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 524A16888E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 13 Aug 2021 16:44:53 +0200 (CEST)", "from perceval.ideasonboard.com (unknown [103.251.226.198])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4DBE98F;\n\tFri, 13 Aug 2021 16:44:52 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"vWc2ehVA\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1628865893;\n\tbh=COa/xVRCb6EE1//4yL1JTNYhp9JCqMFcyyhVF66h1zI=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=vWc2ehVAJGb0JIOeHRa5MbkuatjwMCccD6GvhhsjAK2pnOqxrvNACYumjFvx+PuRq\n\tWsKsatz7Ez7rLxwpZE4A7nLhB6lSJzSApRyVyIQduNgCsM0ek/um39dVNdBkoHETsN\n\tEsQRuya+ZWM9afLh6eIGvm1L745SU6zFxibiyXMw=", "From": "Umang Jain <umang.jain@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 13 Aug 2021 20:14:35 +0530", "Message-Id": "<20210813144437.138005-3-umang.jain@ideasonboard.com>", "X-Mailer": "git-send-email 2.31.1", "In-Reply-To": "<20210813144437.138005-1-umang.jain@ideasonboard.com>", "References": "<20210813144437.138005-1-umang.jain@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 2/4] pipeline: vimc: Allocate fake IPA\n\tbuffers", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "VIMC is a virtual test driver that doesn't generate statistics or\nconsume parameters buffers. Thus, create simple (single plane)\ndmabuf-backed FrameBuffers, which can act as fake IPA buffers and\ncan be memory mapped(mmap) to VIMC IPA.\n\nTo create these buffers, temporarily hijack the output video node\nand configure it with a V4L2DeviceFormat. Buffers then can be exported\nfrom the output video node using V4L2VideoDevice::exportBuffers().\nThese buffers will be mimicked as IPA buffers in subsequent commits.\n\nSigned-off-by: Umang Jain <umang.jain@ideasonboard.com>\n---\n src/libcamera/pipeline/vimc/vimc.cpp | 27 +++++++++++++++++++++++++++\n 1 file changed, 27 insertions(+)", "diff": "diff --git a/src/libcamera/pipeline/vimc/vimc.cpp b/src/libcamera/pipeline/vimc/vimc.cpp\nindex 4c92729d..edf8c58e 100644\n--- a/src/libcamera/pipeline/vimc/vimc.cpp\n+++ b/src/libcamera/pipeline/vimc/vimc.cpp\n@@ -50,6 +50,7 @@ public:\n \t}\n \n \tint init();\n+\tint allocateMockIPABuffers();\n \tvoid bufferReady(FrameBuffer *buffer);\n \n \tMediaDevice *media_;\n@@ -61,6 +62,7 @@ public:\n \tStream stream_;\n \n \tstd::unique_ptr<ipa::vimc::IPAProxyVimc> ipa_;\n+\tstd::vector<std::unique_ptr<FrameBuffer>> mockIPABufs_;\n };\n \n class VimcCameraConfiguration : public CameraConfiguration\n@@ -500,6 +502,12 @@ int VimcCameraData::init()\n \tif (raw_->open())\n \t\treturn -ENODEV;\n \n+\tret = allocateMockIPABuffers();\n+\tif (!ret) {\n+\t\tLOG(VIMC, Warning) << \"Cannot allocate fake IPA buffers\";\n+\t\t/* \\todo fail hard or continue? */\n+\t}\n+\n \t/* Initialise the supported controls. */\n \tconst ControlInfoMap &controls = sensor_->controls();\n \tControlInfoMap::Map ctrls;\n@@ -548,6 +556,25 @@ void VimcCameraData::bufferReady(FrameBuffer *buffer)\n \tpipe_->completeRequest(request);\n }\n \n+int VimcCameraData::allocateMockIPABuffers()\n+{\n+\tunsigned int bufCount = 2;\n+\n+\tV4L2DeviceFormat format;\n+\tformat.fourcc = video_->toV4L2PixelFormat(formats::BGR888);\n+\tformat.size = Size(160, 120);\n+\n+\tint ret = video_->tryFormat(&format);\n+\tif (ret < 0)\n+\t\treturn ret;\n+\n+\tret = video_->setFormat(&format);\n+\tif (ret < 0)\n+\t\treturn ret;\n+\n+\treturn video_->exportBuffers(bufCount, &mockIPABufs_);\n+}\n+\n REGISTER_PIPELINE_HANDLER(PipelineHandlerVimc)\n \n } /* namespace libcamera */\n", "prefixes": [ "libcamera-devel", "v2", "2/4" ] }