Patch Detail
Show a patch.
GET /api/1.1/patches/13339/?format=api
{ "id": 13339, "url": "https://patchwork.libcamera.org/api/1.1/patches/13339/?format=api", "web_url": "https://patchwork.libcamera.org/patch/13339/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210812173907.204700-1-jacopo@jmondi.org>", "date": "2021-08-12T17:39:07", "name": "[libcamera-devel] libcamera: controls: Initialize ControlInfoMap::idmap_", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "6b72eb886701a482b5957aae95cd05c896301a29", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/1.1/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/13339/mbox/", "series": [ { "id": 2348, "url": "https://patchwork.libcamera.org/api/1.1/series/2348/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2348", "date": "2021-08-12T17:39:07", "name": "[libcamera-devel] libcamera: controls: Initialize ControlInfoMap::idmap_", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2348/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/13339/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/13339/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BA519C3240\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 12 Aug 2021 17:38:29 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7C8A66888A;\n\tThu, 12 Aug 2021 19:38:28 +0200 (CEST)", "from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net\n\t[217.70.183.197])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 98B9068823\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 12 Aug 2021 19:38:27 +0200 (CEST)", "(Authenticated sender: jacopo@jmondi.org)\n\tby relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 047E41C0002;\n\tThu, 12 Aug 2021 17:38:26 +0000 (UTC)" ], "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 12 Aug 2021 19:39:07 +0200", "Message-Id": "<20210812173907.204700-1-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.32.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] libcamera: controls: Initialize\n\tControlInfoMap::idmap_", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The compiler generated constructor does not initialize the\nControlInfoMap::idmap_ field.\n\nFix this by explicitly defining an empty constructor for the class.\n\nReported-by: Coverity CID=354657\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n include/libcamera/controls.h | 2 +-\n src/libcamera/controls.cpp | 8 ++++++++\n 2 files changed, 9 insertions(+), 1 deletion(-)", "diff": "diff --git a/include/libcamera/controls.h b/include/libcamera/controls.h\nindex 9b0d5a545301..7352c62ec03c 100644\n--- a/include/libcamera/controls.h\n+++ b/include/libcamera/controls.h\n@@ -307,7 +307,7 @@ class ControlInfoMap : private std::unordered_map<const ControlId *, ControlInfo\n public:\n \tusing Map = std::unordered_map<const ControlId *, ControlInfo>;\n \n-\tControlInfoMap() = default;\n+\tControlInfoMap();\n \tControlInfoMap(const ControlInfoMap &other) = default;\n \tControlInfoMap(std::initializer_list<Map::value_type> init,\n \t\t const ControlIdMap &idmap);\ndiff --git a/src/libcamera/controls.cpp b/src/libcamera/controls.cpp\nindex 5c05ba4a7cd0..83f61fd96b24 100644\n--- a/src/libcamera/controls.cpp\n+++ b/src/libcamera/controls.cpp\n@@ -636,6 +636,14 @@ std::string ControlInfo::toString() const\n * \\brief The base std::unsorted_map<> container\n */\n \n+/**\n+ * \\brief Construct an empty ControlInfoMap\n+ */\n+ControlInfoMap::ControlInfoMap()\n+\t: idmap_(nullptr)\n+{\n+}\n+\n /**\n * \\fn ControlInfoMap::ControlInfoMap(const ControlInfoMap &other)\n * \\brief Copy constructor, construct a ControlInfoMap from a copy of \\a other\n", "prefixes": [ "libcamera-devel" ] }