Patch Detail
Show a patch.
GET /api/1.1/patches/13335/?format=api
{ "id": 13335, "url": "https://patchwork.libcamera.org/api/1.1/patches/13335/?format=api", "web_url": "https://patchwork.libcamera.org/patch/13335/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210812165243.276977-8-jeanmichel.hautbois@ideasonboard.com>", "date": "2021-08-12T16:52:40", "name": "[libcamera-devel,v2,07/10] ipa: ipu3: convert AGC to the new algorithm interface", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "9e0d6fc5499854422a685f16c311724818c6d29a", "submitter": { "id": 75, "url": "https://patchwork.libcamera.org/api/1.1/people/75/?format=api", "name": "Jean-Michel Hautbois", "email": "jeanmichel.hautbois@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/13335/mbox/", "series": [ { "id": 2347, "url": "https://patchwork.libcamera.org/api/1.1/series/2347/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2347", "date": "2021-08-12T16:52:33", "name": "IPU3: Introduce modularity for algorithms", "version": 2, "mbox": "https://patchwork.libcamera.org/series/2347/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/13335/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/13335/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 12D46C3242\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 12 Aug 2021 16:52:56 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9E9CD68886;\n\tThu, 12 Aug 2021 18:52:55 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1E20768893\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 12 Aug 2021 18:52:48 +0200 (CEST)", "from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:3d6d:7284:3c48:5edc])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D09A3F49;\n\tThu, 12 Aug 2021 18:52:47 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"GfW/FEHi\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1628787167;\n\tbh=tkuhE9jzm9r7eXnQj67EBvKN4thsCmh0T0knUSicSQM=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=GfW/FEHiB83KPdqddOKr8TRYnKibKsgChDxnxwPqPca5JWYmbHC2a4EXCiQ5s4UQm\n\tK5QpHD4QWMnJMZ2VSAx2gJgPqfraX1nxsKO3iCLO3ZlhYhxxkSfVA8pF9Ufyo+R+gQ\n\tMrjtER/GKXp5MN/MNwC1DVXcMpGXJtjU4o5/+dNY=", "From": "Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 12 Aug 2021 18:52:40 +0200", "Message-Id": "<20210812165243.276977-8-jeanmichel.hautbois@ideasonboard.com>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20210812165243.276977-1-jeanmichel.hautbois@ideasonboard.com>", "References": "<20210812165243.276977-1-jeanmichel.hautbois@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 07/10] ipa: ipu3: convert AGC to the\n\tnew algorithm interface", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Signed-off-by: Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>\n---\n src/ipa/ipu3/ipu3.cpp | 2 +-\n src/ipa/ipu3/ipu3_agc.cpp | 8 +++++---\n src/ipa/ipu3/ipu3_agc.h | 2 +-\n 3 files changed, 7 insertions(+), 5 deletions(-)", "diff": "diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\nindex dba5554d..2a8225a0 100644\n--- a/src/ipa/ipu3/ipu3.cpp\n+++ b/src/ipa/ipu3/ipu3.cpp\n@@ -232,7 +232,7 @@ int IPAIPU3::configure(const IPAConfigInfo &configInfo)\n \tawbAlgo_ = std::make_unique<IPU3Awb>();\n \n \tagcAlgo_ = std::make_unique<IPU3Agc>();\n-\tagcAlgo_->initialise(context_.configuration.grid.bdsGrid, sensorInfo_);\n+\tagcAlgo_->configure(context_, configInfo);\n \n \treturn 0;\n }\ndiff --git a/src/ipa/ipu3/ipu3_agc.cpp b/src/ipa/ipu3/ipu3_agc.cpp\nindex c6782ff4..0cc35b9f 100644\n--- a/src/ipa/ipu3/ipu3_agc.cpp\n+++ b/src/ipa/ipu3/ipu3_agc.cpp\n@@ -59,12 +59,14 @@ IPU3Agc::IPU3Agc()\n {\n }\n \n-void IPU3Agc::initialise(struct ipu3_uapi_grid_config &bdsGrid, const IPACameraSensorInfo &sensorInfo)\n+int IPU3Agc::configure(IPAContext &context, const IPAConfigInfo &configInfo)\n {\n-\taeGrid_ = bdsGrid;\n+\taeGrid_ = context.configuration.grid.bdsGrid;\n \n-\tlineDuration_ = sensorInfo.lineLength * 1.0s / sensorInfo.pixelRate;\n+\tlineDuration_ = configInfo.sensorInfo.lineLength * 1.0s / configInfo.sensorInfo.pixelRate;\n \tmaxExposureTime_ = kMaxExposure * lineDuration_;\n+\n+\treturn 0;\n }\n \n void IPU3Agc::processBrightness(const ipu3_uapi_stats_3a *stats)\ndiff --git a/src/ipa/ipu3/ipu3_agc.h b/src/ipa/ipu3/ipu3_agc.h\nindex 8b32e52f..e096648b 100644\n--- a/src/ipa/ipu3/ipu3_agc.h\n+++ b/src/ipa/ipu3/ipu3_agc.h\n@@ -29,7 +29,7 @@ public:\n \tIPU3Agc();\n \t~IPU3Agc() = default;\n \n-\tvoid initialise(struct ipu3_uapi_grid_config &bdsGrid, const IPACameraSensorInfo &sensorInfo);\n+\tint configure(IPAContext &context, const IPAConfigInfo &configInfo) override;\n \tvoid process(IPAContext &context, const ipu3_uapi_stats_3a *stats) override;\n \tbool converged() { return converged_; }\n \tbool updateControls() { return updateControls_; }\n", "prefixes": [ "libcamera-devel", "v2", "07/10" ] }