Patch Detail
Show a patch.
GET /api/1.1/patches/13327/?format=api
{ "id": 13327, "url": "https://patchwork.libcamera.org/api/1.1/patches/13327/?format=api", "web_url": "https://patchwork.libcamera.org/patch/13327/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210812135750.165416-1-jeanmichel.hautbois@ideasonboard.com>", "date": "2021-08-12T13:57:50", "name": "[libcamera-devel] ipa: ipu3: fix headers order", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": false, "hash": "d11349fe081525b0cab211b15392bd824a660d77", "submitter": { "id": 75, "url": "https://patchwork.libcamera.org/api/1.1/people/75/?format=api", "name": "Jean-Michel Hautbois", "email": "jeanmichel.hautbois@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/13327/mbox/", "series": [ { "id": 2346, "url": "https://patchwork.libcamera.org/api/1.1/series/2346/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2346", "date": "2021-08-12T13:57:50", "name": "[libcamera-devel] ipa: ipu3: fix headers order", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2346/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/13327/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/13327/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DC409BD87D\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 12 Aug 2021 13:57:56 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 43B5C6884F;\n\tThu, 12 Aug 2021 15:57:56 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B17D660264\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 12 Aug 2021 15:57:54 +0200 (CEST)", "from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:3d6d:7284:3c48:5edc])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 52A18EE;\n\tThu, 12 Aug 2021 15:57:54 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"hF7Q5M6b\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1628776674;\n\tbh=MLMqrQraH4kFeprd6mYKQEEor8mQ2ivgslgfHLvQ9mM=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=hF7Q5M6b5TueigtA7v9HXVc+SZnscjxDFpR9pdvaV1KfMZa5SQ1NchC6Hz13Lsa1I\n\tx01SaBwrusJwiRmwRUmFtT8fFnZhqPeXRpc07qyFjsxb4PHvT24XRaMdOQLmD0kaqt\n\tYp0nsYVxGiq4bWe/etdLCjOxw2CdqoieAckmtJJ4=", "From": "Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 12 Aug 2021 15:57:50 +0200", "Message-Id": "<20210812135750.165416-1-jeanmichel.hautbois@ideasonboard.com>", "X-Mailer": "git-send-email 2.30.2", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] ipa: ipu3: fix headers order", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The ipu3 does not follow the current coding style practices for header inclusion.\nRe-order the headers to match the updated styles.\n\nSigned-off-by: Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>\n---\n src/ipa/ipu3/ipu3.cpp | 6 ++++--\n 1 file changed, 4 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\nindex c34fa460..21b9db64 100644\n--- a/src/ipa/ipu3/ipu3.cpp\n+++ b/src/ipa/ipu3/ipu3.cpp\n@@ -22,16 +22,18 @@\n \n #include <libcamera/control_ids.h>\n #include <libcamera/framebuffer.h>\n+#include <libcamera/request.h>\n+\n #include <libcamera/ipa/ipa_interface.h>\n #include <libcamera/ipa/ipa_module_info.h>\n #include <libcamera/ipa/ipu3_ipa_interface.h>\n-#include <libcamera/request.h>\n \n #include \"libcamera/internal/mapped_framebuffer.h\"\n \n+#include \"libipa/camera_sensor_helper.h\"\n+\n #include \"ipu3_agc.h\"\n #include \"ipu3_awb.h\"\n-#include \"libipa/camera_sensor_helper.h\"\n \n static constexpr uint32_t kMaxCellWidthPerSet = 160;\n static constexpr uint32_t kMaxCellHeightPerSet = 56;\n", "prefixes": [ "libcamera-devel" ] }