Patch Detail
Show a patch.
GET /api/1.1/patches/13323/?format=api
{ "id": 13323, "url": "https://patchwork.libcamera.org/api/1.1/patches/13323/?format=api", "web_url": "https://patchwork.libcamera.org/patch/13323/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210812034818.1070867-1-paul.elder@ideasonboard.com>", "date": "2021-08-12T03:48:18", "name": "[libcamera-devel] ipa: raspberrypi: Use boolean constructor for AeEnable ControlInfo", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "3c362c519016cb566fb82b4fa15b6eaa14666ccc", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/1.1/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/13323/mbox/", "series": [ { "id": 2342, "url": "https://patchwork.libcamera.org/api/1.1/series/2342/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2342", "date": "2021-08-12T03:48:18", "name": "[libcamera-devel] ipa: raspberrypi: Use boolean constructor for AeEnable ControlInfo", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2342/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/13323/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/13323/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8AA42C3240\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 12 Aug 2021 03:48:32 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C70CD6884D;\n\tThu, 12 Aug 2021 05:48:31 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DFB4B60260\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 12 Aug 2021 05:48:29 +0200 (CEST)", "from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4663DEE;\n\tThu, 12 Aug 2021 05:48:27 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"eDticLFC\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1628740109;\n\tbh=4yAVicL2VLk7jaLzsAC9hqGU9pi+z+HyvM7zGyoyvSc=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=eDticLFCDnChrHovlob+fYK/6dOjjdvCqK8PJML6OwG0SAgpyTQ2YGxRXX9f7t4sX\n\tq2uO1SFpp5H8o11dUIhm8J3DX23hq8cjZKYiCBMJ0jKmVaU+BTO/24ALu9YFM+5ccP\n\tYt7qJrwBOpIRWXVMVZLB5FHhftEwANsKQGyDeGiw=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 12 Aug 2021 12:48:18 +0900", "Message-Id": "<20210812034818.1070867-1-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] ipa: raspberrypi: Use boolean constructor\n\tfor AeEnable ControlInfo", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The min-max constructor is not the proper constructor for boolean\nControlInfos. Use the proper boolean constructor.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\n---\n include/libcamera/ipa/raspberrypi.h | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/include/libcamera/ipa/raspberrypi.h b/include/libcamera/ipa/raspberrypi.h\nindex b82c2cec..6ff9ed7b 100644\n--- a/include/libcamera/ipa/raspberrypi.h\n+++ b/include/libcamera/ipa/raspberrypi.h\n@@ -28,7 +28,7 @@ namespace RPi {\n * unsupported control is encountered.\n */\n static const ControlInfoMap Controls({\n-\t\t{ &controls::AeEnable, ControlInfo(false, true) },\n+\t\t{ &controls::AeEnable, ControlInfo({ false, true }, true) },\n \t\t{ &controls::ExposureTime, ControlInfo(0, 999999) },\n \t\t{ &controls::AnalogueGain, ControlInfo(1.0f, 32.0f) },\n \t\t{ &controls::AeMeteringMode, ControlInfo(controls::AeMeteringModeValues) },\n", "prefixes": [ "libcamera-devel" ] }