Patch Detail
Show a patch.
GET /api/1.1/patches/13315/?format=api
{ "id": 13315, "url": "https://patchwork.libcamera.org/api/1.1/patches/13315/?format=api", "web_url": "https://patchwork.libcamera.org/patch/13315/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210811232625.17280-8-laurent.pinchart@ideasonboard.com>", "date": "2021-08-11T23:26:18", "name": "[libcamera-devel,v3,07/14] libcamera: pipeline: vimc: Migrate to Camera::Private", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "a84a8d849d78665f7c04b759614371a9a48df691", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/13315/mbox/", "series": [ { "id": 2341, "url": "https://patchwork.libcamera.org/api/1.1/series/2341/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2341", "date": "2021-08-11T23:26:11", "name": "libcamera: Replace CameraData with Camera::Private", "version": 3, "mbox": "https://patchwork.libcamera.org/series/2341/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/13315/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/13315/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6D8B8BD87D\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 11 Aug 2021 23:26:44 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E185B68890;\n\tThu, 12 Aug 2021 01:26:43 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4E49D68855\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 12 Aug 2021 01:26:35 +0200 (CEST)", "from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E3434EE\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 12 Aug 2021 01:26:34 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"mKC6XSJ5\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1628724395;\n\tbh=Ry+ToS4cgAu8WRDGIe64ticp5fo7TojLPk+26acZtiQ=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=mKC6XSJ5Qze30gEbx0CUWh4L5Ppu/Oc+qXlAgSU/ropmgOLlrbfI4PMzcTmRQ+OK/\n\tnZui/5Hohc96BkPd8rOn0MQUi6ndZRZOBnMr3TYlCdOVTrwjiRNh/XCFgGlzvkyuCV\n\tZW7h/E5bdbsOtgJmvxiDewjv3pjp5w9t+PHjzhZ8=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 12 Aug 2021 02:26:18 +0300", "Message-Id": "<20210811232625.17280-8-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.31.1", "In-Reply-To": "<20210811232625.17280-1-laurent.pinchart@ideasonboard.com>", "References": "<20210811232625.17280-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v3 07/14] libcamera: pipeline: vimc:\n\tMigrate to Camera::Private", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "As part of the effort to remove the CameraData class, migrate the\npipeline handler-specific camera data from CameraData to the\nCamera::Private class.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\nReviewed-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/libcamera/pipeline/vimc/vimc.cpp | 19 +++++++++----------\n 1 file changed, 9 insertions(+), 10 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/vimc/vimc.cpp b/src/libcamera/pipeline/vimc/vimc.cpp\nindex 999d975716fa..0ce467e8e520 100644\n--- a/src/libcamera/pipeline/vimc/vimc.cpp\n+++ b/src/libcamera/pipeline/vimc/vimc.cpp\n@@ -42,11 +42,11 @@ namespace libcamera {\n \n LOG_DEFINE_CATEGORY(VIMC)\n \n-class VimcCameraData : public CameraData\n+class VimcCameraData : public Camera::Private\n {\n public:\n \tVimcCameraData(PipelineHandler *pipe, MediaDevice *media)\n-\t\t: CameraData(pipe), media_(media)\n+\t\t: Camera::Private(pipe), media_(media)\n \t{\n \t}\n \n@@ -97,10 +97,9 @@ public:\n private:\n \tint processControls(VimcCameraData *data, Request *request);\n \n-\tVimcCameraData *cameraData(const Camera *camera)\n+\tVimcCameraData *cameraData(Camera *camera)\n \t{\n-\t\treturn static_cast<VimcCameraData *>(\n-\t\t\tPipelineHandler::cameraData(camera));\n+\t\treturn static_cast<VimcCameraData *>(camera->_d());\n \t}\n };\n \n@@ -438,10 +437,10 @@ bool PipelineHandlerVimc::match(DeviceEnumerator *enumerator)\n \n \t/* Create and register the camera. */\n \tstd::set<Stream *> streams{ &data->stream_ };\n+\tconst std::string &id = data->sensor_->id();\n \tstd::shared_ptr<Camera> camera =\n-\t\tCamera::create(std::make_unique<Camera::Private>(this),\n-\t\t\t data->sensor_->id(), streams);\n-\tregisterCamera(std::move(camera), std::move(data));\n+\t\tCamera::create(std::move(data), id, streams);\n+\tregisterCamera(std::move(camera), nullptr);\n \n \treturn true;\n }\n@@ -530,8 +529,8 @@ void VimcCameraData::bufferReady(FrameBuffer *buffer)\n \trequest->metadata().set(controls::SensorTimestamp,\n \t\t\t\tbuffer->metadata().timestamp);\n \n-\tpipe_->completeBuffer(request, buffer);\n-\tpipe_->completeRequest(request);\n+\tpipe()->completeBuffer(request, buffer);\n+\tpipe()->completeRequest(request);\n }\n \n REGISTER_PIPELINE_HANDLER(PipelineHandlerVimc)\n", "prefixes": [ "libcamera-devel", "v3", "07/14" ] }