Patch Detail
Show a patch.
GET /api/1.1/patches/13300/?format=api
{ "id": 13300, "url": "https://patchwork.libcamera.org/api/1.1/patches/13300/?format=api", "web_url": "https://patchwork.libcamera.org/patch/13300/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210811080546.2266825-1-kieran.bingham@ideasonboard.com>", "date": "2021-08-11T08:05:46", "name": "[libcamera-devel] base: class: Remove undesired semi-colon from LIBCAMERA_O_PTR", "commit_ref": "b1d818beb44d8a658eeae6f83a440c33aeff1f4f", "pull_url": null, "state": "accepted", "archived": false, "hash": "acc70f0b487d4b62c9aeae24b4467479a02303f4", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/1.1/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/13300/mbox/", "series": [ { "id": 2338, "url": "https://patchwork.libcamera.org/api/1.1/series/2338/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2338", "date": "2021-08-11T08:05:46", "name": "[libcamera-devel] base: class: Remove undesired semi-colon from LIBCAMERA_O_PTR", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2338/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/13300/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/13300/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 37793C3240\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 11 Aug 2021 08:05:53 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 82B0D6884F;\n\tWed, 11 Aug 2021 10:05:51 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7560060265\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 11 Aug 2021 10:05:50 +0200 (CEST)", "from Monstersaurus.local\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EACFEEE;\n\tWed, 11 Aug 2021 10:05:49 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"u/EsWhV6\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1628669150;\n\tbh=eNlLObYRb5MFVEf/ZQ0ThmocwgeQ97pgmcPYI0NQUXE=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=u/EsWhV6AvBVLWZT85M0U/wzYA9IacsccvopRkdIhlyzqIFf916zvb2/SMDbGrKvD\n\tzjAfd3midjDGMB66UYtLLWvrNZPdFD6M6O2KkLxe7QqLbcrdANV0taAaR/F0gUikho\n\tpbcjbhE1ZIVtaBClEGqHsCAJ6GO/+znIKXXLz3LM=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Date": "Wed, 11 Aug 2021 09:05:46 +0100", "Message-Id": "<20210811080546.2266825-1-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.30.2", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] base: class: Remove undesired semi-colon\n\tfrom LIBCAMERA_O_PTR", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The LIBCAMERA_O_PTR() define adds the ';' at the end of the\ntemplated call to _o().\n\nWhile this works for the only current user in camera_manager.cpp, even\nthe statement there adds another semi-colon following it.\n\nThe addition of the semi-colon in the define unnecessarily prohibits the\nmacro from being used in places other than the end of a statement.\n\nRemove it.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n include/libcamera/base/class.h | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/include/libcamera/base/class.h b/include/libcamera/base/class.h\nindex a5946836d2b9..02bbd91f93f8 100644\n--- a/include/libcamera/base/class.h\n+++ b/include/libcamera/base/class.h\n@@ -50,7 +50,7 @@ public:\t\t\t\t\t\t\t\t\t\\\n \tusing Public = klass;\n \n #define LIBCAMERA_O_PTR()\t\t\t\t\t\t\\\n-\t_o<Public>();\n+\t_o<Public>()\n \n #else\n #define LIBCAMERA_DECLARE_PRIVATE()\n", "prefixes": [ "libcamera-devel" ] }