Patch Detail
Show a patch.
GET /api/1.1/patches/13293/?format=api
{ "id": 13293, "url": "https://patchwork.libcamera.org/api/1.1/patches/13293/?format=api", "web_url": "https://patchwork.libcamera.org/patch/13293/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210810161134.2243796-4-kieran.bingham@ideasonboard.com>", "date": "2021-08-10T16:11:34", "name": "[libcamera-devel,3/3] libcamera: request: Use external CameraControlValidator", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "6d58d81b7c5161ad1a31660d0b318b1d14a392cd", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/1.1/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": { "id": 11, "url": "https://patchwork.libcamera.org/api/1.1/users/11/?format=api", "username": "kbingham", "first_name": "Kieran", "last_name": "Bingham", "email": "kieran.bingham@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/patch/13293/mbox/", "series": [ { "id": 2335, "url": "https://patchwork.libcamera.org/api/1.1/series/2335/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2335", "date": "2021-08-10T16:11:31", "name": "Request: Use the Camera's CameraControlValidator", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2335/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/13293/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/13293/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BC334C3242\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 10 Aug 2021 16:11:41 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DF3EF6888C;\n\tTue, 10 Aug 2021 18:11:40 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BE2DE687F0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 10 Aug 2021 18:11:37 +0200 (CEST)", "from Monstersaurus.local\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6E4E43F0;\n\tTue, 10 Aug 2021 18:11:37 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"kqYpNDlR\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1628611897;\n\tbh=E2al2TTS7/EVKTrISR8n83R4O7/TJ9m2ZkLc/j+JELA=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=kqYpNDlReDZzpkw/indMPExyF+CJ3g/1P0FuT969e4kPcJyWgJHn7xx0+XixFNKSY\n\tuA8xD6Ppog6Pqym3fnpp9A786F8tIY6QqUqpa959Gn3hQgLIbawYqq8oz0VWZFeIha\n\tXLa9212mcwePh2NPDpb1bIeGvvzvujbJ1EdhWc5w=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Date": "Tue, 10 Aug 2021 17:11:34 +0100", "Message-Id": "<20210810161134.2243796-4-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20210810161134.2243796-1-kieran.bingham@ideasonboard.com>", "References": "<20210810161134.2243796-1-kieran.bingham@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 3/3] libcamera: request: Use external\n\tCameraControlValidator", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Each Request is currently creating its own CameraControlValidator\nusing the Camera instance at construction.\n\nNow that the Camera exposes its own CameraControlValidator on its\nprivate interface, use that one on all Requests.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n include/libcamera/request.h | 1 -\n src/libcamera/request.cpp | 11 ++++-------\n 2 files changed, 4 insertions(+), 8 deletions(-)", "diff": "diff --git a/include/libcamera/request.h b/include/libcamera/request.h\nindex 2d361c9d97dc..d16904e6b679 100644\n--- a/include/libcamera/request.h\n+++ b/include/libcamera/request.h\n@@ -71,7 +71,6 @@ private:\n \tbool completeBuffer(FrameBuffer *buffer);\n \n \tCamera *camera_;\n-\tCameraControlValidator *validator_;\n \tControlList *controls_;\n \tControlList *metadata_;\n \tBufferMap bufferMap_;\ndiff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp\nindex f95ce4db5eaa..4cb4963ea352 100644\n--- a/src/libcamera/request.cpp\n+++ b/src/libcamera/request.cpp\n@@ -17,6 +17,7 @@\n #include <libcamera/framebuffer.h>\n #include <libcamera/stream.h>\n \n+#include \"libcamera/internal/camera.h\"\n #include \"libcamera/internal/camera_controls.h\"\n #include \"libcamera/internal/framebuffer.h\"\n #include \"libcamera/internal/tracepoints.h\"\n@@ -77,12 +78,9 @@ Request::Request(Camera *camera, uint64_t cookie)\n \t: camera_(camera), sequence_(0), cookie_(cookie),\n \t status_(RequestPending), cancelled_(false)\n {\n-\t/**\n-\t * \\todo Should the Camera expose a validator instance, to avoid\n-\t * creating a new instance for each request?\n-\t */\n-\tvalidator_ = new CameraControlValidator(camera);\n-\tcontrols_ = new ControlList(controls::controls, validator_);\n+\tconst CameraControlValidator &validator = camera->_d()->validator();\n+\n+\tcontrols_ = new ControlList(controls::controls, &validator);\n \n \t/**\n \t * \\todo: Add a validator for metadata controls.\n@@ -100,7 +98,6 @@ Request::~Request()\n \n \tdelete metadata_;\n \tdelete controls_;\n-\tdelete validator_;\n }\n \n /**\n", "prefixes": [ "libcamera-devel", "3/3" ] }