Patch Detail
Show a patch.
GET /api/1.1/patches/13292/?format=api
{ "id": 13292, "url": "https://patchwork.libcamera.org/api/1.1/patches/13292/?format=api", "web_url": "https://patchwork.libcamera.org/patch/13292/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210810161134.2243796-3-kieran.bingham@ideasonboard.com>", "date": "2021-08-10T16:11:33", "name": "[libcamera-devel,2/3] libcamera: camera: Create a CameraControlValidator", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "2faabbcb2e4f3c479f1936731b54e6b66b72348f", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/1.1/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": { "id": 11, "url": "https://patchwork.libcamera.org/api/1.1/users/11/?format=api", "username": "kbingham", "first_name": "Kieran", "last_name": "Bingham", "email": "kieran.bingham@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/patch/13292/mbox/", "series": [ { "id": 2335, "url": "https://patchwork.libcamera.org/api/1.1/series/2335/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2335", "date": "2021-08-10T16:11:31", "name": "Request: Use the Camera's CameraControlValidator", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2335/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/13292/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/13292/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 989C0C3241\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 10 Aug 2021 16:11:41 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9A07B68889;\n\tTue, 10 Aug 2021 18:11:40 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 865536882A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 10 Aug 2021 18:11:37 +0200 (CEST)", "from Monstersaurus.local\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 35E2D51D;\n\tTue, 10 Aug 2021 18:11:37 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Q19egqXp\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1628611897;\n\tbh=GYAGZA65zSTTH4oYxRWQzmpCkpgf3bwVqLP0gekS1iY=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=Q19egqXpDMOJ0XPZuvBDqgePEkMx7dfK7Kv0TwlOmIcGA4QsvXl53fnXU81+38Lhu\n\tUOcgi0FQ4fJALcDVMruFP/8NLfxuMTIo/iOs/2cIQ8BMuHOojkJPxQ53Wr0aJUylHb\n\tKsxhIirqikAyPnCfBwR8aa4eR9ufKI6jfFqjX8UY=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Date": "Tue, 10 Aug 2021 17:11:33 +0100", "Message-Id": "<20210810161134.2243796-3-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20210810161134.2243796-1-kieran.bingham@ideasonboard.com>", "References": "<20210810161134.2243796-1-kieran.bingham@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 2/3] libcamera: camera: Create a\n\tCameraControlValidator", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Create a Camera specific CameraControlValidator for the Camera instance.\nThis will allow requests to use a single validor instance without having\nto construct their own.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n\nLaurent:\n - Is the use of the _o<Public>() reference valid here in the\n initialiser list?\n\n\n include/libcamera/internal/camera.h | 6 ++++++\n src/libcamera/camera.cpp | 2 +-\n 2 files changed, 7 insertions(+), 1 deletion(-)", "diff": "diff --git a/include/libcamera/internal/camera.h b/include/libcamera/internal/camera.h\nindex b60ed140356a..f14bafc75e05 100644\n--- a/include/libcamera/internal/camera.h\n+++ b/include/libcamera/internal/camera.h\n@@ -16,6 +16,8 @@\n \n #include <libcamera/camera.h>\n \n+#include \"libcamera/internal/camera_controls.h\"\n+\n namespace libcamera {\n \n class PipelineHandler;\n@@ -30,6 +32,8 @@ public:\n \t\tconst std::set<Stream *> &streams);\n \t~Private();\n \n+\tconst CameraControlValidator &validator() const { return validator_; }\n+\n private:\n \tenum State {\n \t\tCameraAvailable,\n@@ -56,6 +60,8 @@ private:\n \n \tbool disconnected_;\n \tstd::atomic<State> state_;\n+\n+\tCameraControlValidator validator_;\n };\n \n } /* namespace libcamera */\ndiff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\nindex 6281e92057e4..b914bf188d57 100644\n--- a/src/libcamera/camera.cpp\n+++ b/src/libcamera/camera.cpp\n@@ -336,7 +336,7 @@ Camera::Private::Private(PipelineHandler *pipe,\n \t\t\t const std::string &id,\n \t\t\t const std::set<Stream *> &streams)\n \t: pipe_(pipe->shared_from_this()), id_(id), streams_(streams),\n-\t disconnected_(false), state_(CameraAvailable)\n+\t disconnected_(false), state_(CameraAvailable), validator_(_o<Public>())\n {\n }\n \n", "prefixes": [ "libcamera-devel", "2/3" ] }