Patch Detail
Show a patch.
GET /api/1.1/patches/13282/?format=api
{ "id": 13282, "url": "https://patchwork.libcamera.org/api/1.1/patches/13282/?format=api", "web_url": "https://patchwork.libcamera.org/patch/13282/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<tencent_BF16B7D9BE760D0F69B2504CCE47A0EBAA08@qq.com>", "date": "2021-08-10T12:17:40", "name": "[libcamera-devel,RFC,v2,2/4] libcamera: swisp: Move the softawre ISP process to swisp", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "932f8ded079b6cae1f2a193707b60ce59290a0ec", "submitter": { "id": 88, "url": "https://patchwork.libcamera.org/api/1.1/people/88/?format=api", "name": "Siyuan Fan", "email": "siyuan.fan@foxmail.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/13282/mbox/", "series": [ { "id": 2332, "url": "https://patchwork.libcamera.org/api/1.1/series/2332/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2332", "date": "2021-08-10T12:17:39", "name": "[libcamera-devel,RFC,v2,1/4] pipeline: isp: The software ISP-based pipeline handler", "version": 2, "mbox": "https://patchwork.libcamera.org/series/2332/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/13282/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/13282/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7EE4CC3241\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 10 Aug 2021 12:17:58 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4EE786888B;\n\tTue, 10 Aug 2021 14:17:57 +0200 (CEST)", "from out203-205-221-202.mail.qq.com (out203-205-221-202.mail.qq.com\n\t[203.205.221.202])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 32E34687F0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 10 Aug 2021 14:17:53 +0200 (CEST)", "from localhost.localdomain ([123.126.82.8])\n\tby newxmesmtplogicsvrsza5.qq.com (NewEsmtp) with SMTP\n\tid 46D0AC53; Tue, 10 Aug 2021 20:17:45 +0800" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=foxmail.com header.i=@foxmail.com\n\theader.b=\"fF3RuIun\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com;\n\ts=s201512; t=1628597870;\n\tbh=MpPBdLHjXJ3P7/mkUaYI/7v+TX5Yp4xG20oBoUfcXag=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References;\n\tb=fF3RuIunO9WbaEiD94szOF0bfKRXXrtKJE00UHYDsmLqP4403jzDOgzXVr2WleVSD\n\tWREsdW2hJ9sLUzPJgbaqYd3Y8IwD4got/JY6mjHp0g6fXYK1VxZBTDlOwiw7uQW0Qu\n\tEAl5bC/U5/GBZMP+qrIAVagmy1VQnajiAQssauqE=", "X-QQ-mid": "xmsmtpt1628597868ts7fxlrfm", "Message-ID": "<tencent_BF16B7D9BE760D0F69B2504CCE47A0EBAA08@qq.com>", "X-QQ-XMAILINFO": "N8r1CgRsoLeWHmeMH9snNJkGbAYLkgsf33FaKFQrjfxE98ni6AGtKCckvU8D31\n\twe5wOK1LGXcKZ37JqIz/OdqiKds1XgkR37r7eBtucS9HRQqzB6mZFx7wtkhau+s7YeXUpA2BylZp\n\tC6yDwn7tCNvMwPewwG23uQLrMGETuM5lMwwoyH+7FKDUs5aIX94i77oiEEgfGp5BNSow/x3v/FhU\n\thurZ1JrIgyeQk+haIEXyf4TawxY6orfRT6AynIwoQqUzog9kmzL7itx0d63ZO+MYg6523mXs+kRv\n\tzpgYupEAhfV1NWufWIW4ugPeS81ISNwgrFESFHwKpj7KjPkJ23YGmtEvFlsycN5VoO8TyNBZhlK/\n\tEAtYQlH2b7QOoKVoRdMVp7dkqnmMtCVIGZDO3gb9qFkos9cNmUSzmUducu4FhLWSIe7kfku/m7mr\n\ttMi27W5KlcsxOYm1WKHAwO1fpyPxWwENMC5WDPAT6O9nTqFgafmm2QV4b7zFIEtK/UbwZQVp4Rh+\n\tmp7nrNNum0GSekRGooWDCppdTil4v+tftWIuNHxnvtcA767b/grafAPUpc/bRT/q+hZ9GNXNZeMs\n\tqsQO+Y5BhjHZJrwdjx5m+WzrLxdQIDu5ZKeMwWMvBXtpx8PuR6XGuqFrcaksz7YNAADmmIgubBss\n\txs61i+1FXJtILs7I4Du6cIerDH+NDFEczcyip0ETdPcWhJYhuiXmfANT/JLa/Pc1uAYkeIBwLmmL\n\t2rQogckLks9RBscwsafBg42+MGhRFLPIV7sNDxwB4ytxFewgFKv8UYkxBhZFDOMxaTfn3CUMckDj\n\tA7DsHRP13oeoeyzxzetwJ89YoDV9Opz6evxDinvofEYjlfTwWd7Ch61sf7fPCpWRlcmjX0piOeZs\n\tBtwF6tOTKyyOE2e8IhkNZYhqt5Mv9dmmZDs1UojliEYO1ZAenrCEt3url9Bo3ogCTqLi7I7ALIaM\n\thajhz/r++caEQyrMNJ0iW1L0J7UhwU8HFTtlAlIOlllKTvjht0REKFqs7wlD5/jPaxz5GtQgQ=", "From": "Siyuan Fan <siyuan.fan@foxmail.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 10 Aug 2021 13:17:40 +0100", "X-OQ-MSGID": "<20210810121742.11012-3-siyuan.fan@foxmail.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20210810121742.11012-1-siyuan.fan@foxmail.com>", "References": "<20210810121742.11012-1-siyuan.fan@foxmail.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [RFC PATCH v2 2/4] libcamera: swisp: Move the\n\tsoftawre ISP process to swisp", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Fan Siyuan <siyuan.fan@foxmail.com>\n\n Changes in V2:\n -Design the abstract class ISP, CPU_ISP and future GPU_ISP inherit from it.\n -Add the rgb buf alloc and thread control member function\n\n Now the ISP must implement the below process:\n BLC-->demosaic-->AWB-->tone mapping-->gamma-->Noise reduction\n\n Plan to add:\n lens shading correct-->Color correct-->color space transform\n\nSigned-off-by: Fan Siyuan <siyuan.fan@foxmail.com>\n---\n .../isp/isp_processing.cpp => swisp/isp.cpp} | 90 ++++++++++++++-----\n .../isp/isp_processing.h => swisp/isp.h} | 52 ++++++++---\n 2 files changed, 111 insertions(+), 31 deletions(-)\n rename src/libcamera/{pipeline/isp/isp_processing.cpp => swisp/isp.cpp} (87%)\n rename src/libcamera/{pipeline/isp/isp_processing.h => swisp/isp.h} (54%)", "diff": "diff --git a/src/libcamera/pipeline/isp/isp_processing.cpp b/src/libcamera/swisp/isp.cpp\nsimilarity index 87%\nrename from src/libcamera/pipeline/isp/isp_processing.cpp\nrename to src/libcamera/swisp/isp.cpp\nindex 94e8081d..6d073040 100644\n--- a/src/libcamera/pipeline/isp/isp_processing.cpp\n+++ b/src/libcamera/swisp/isp.cpp\n@@ -2,10 +2,10 @@\n /*\n * Copyright (C) 2021, Siyuan Fan <siyuan.fan@foxmail.com>\n *\n- * isp_processing.cpp - The software ISP class\n+ * isp.cpp - The software ISP class\n */\n \n-#include \"isp_processing.h\"\n+#include \"isp.h\"\n \n #include <math.h>\n #include <stdlib.h>\n@@ -14,6 +14,7 @@\n #include <unistd.h>\n \n #include <libcamera/request.h>\n+#include <libcamera/file_descriptor.h>\n \n #include \"libcamera/base/log.h\"\n \n@@ -21,7 +22,7 @@ namespace libcamera{\n \n LOG_DECLARE_CATEGORY(ISP)\n \n-void ISP::autoContrast(uint16_t *data, float lowCut, float highCut, int width, int height)\n+void CPU_ISP::autoContrast(uint16_t *data, float lowCut, float highCut, int width, int height)\n {\n int blue, gr, gb, red;\n int histBlue[1024] = {0}, histGb[1024] = {0}, histGr[1024] = {0}, histRed[1024] = {0};\n@@ -211,7 +212,7 @@ void ISP::autoContrast(uint16_t *data, float lowCut, float highCut, int width, i\n }\n }\n \n-void ISP::blackLevelCorrect(uint16_t *data, uint16_t offset, int width, int height)\n+void CPU_ISP::blackLevelCorrect(uint16_t *data, uint16_t offset, int width, int height)\n {\n int len = width * height;\n for(int i = 0; i < len; i++) {\n@@ -224,7 +225,7 @@ void ISP::blackLevelCorrect(uint16_t *data, uint16_t offset, int width, int heig\n }\n }\n \n-void ISP::readChannels(uint16_t *data, uint16_t *R, uint16_t *G, uint16_t *B,\n+void CPU_ISP::readChannels(uint16_t *data, uint16_t *R, uint16_t *G, uint16_t *B,\n int width, int height)\n {\n int index;\n@@ -245,7 +246,7 @@ void ISP::readChannels(uint16_t *data, uint16_t *R, uint16_t *G, uint16_t *B,\n }\n }\n \n-void ISP::firstPixelInsert(uint16_t *src, uint16_t *dst, int width, int height)\n+void CPU_ISP::firstPixelInsert(uint16_t *src, uint16_t *dst, int width, int height)\n {\n int index;\n for (int i = 0; i < height; i++) {\n@@ -295,7 +296,7 @@ void ISP::firstPixelInsert(uint16_t *src, uint16_t *dst, int width, int height)\n }\n }\n \n-void ISP::twoPixelInsert(uint16_t *src, uint16_t *dst, int width, int height)\n+void CPU_ISP::twoPixelInsert(uint16_t *src, uint16_t *dst, int width, int height)\n {\n int index;\n for (int i = 0; i < height; i++) {\n@@ -340,7 +341,7 @@ void ISP::twoPixelInsert(uint16_t *src, uint16_t *dst, int width, int height)\n }\n }\n \n-void ISP::lastPixelInsert(uint16_t *src, uint16_t *dst, int width, int height)\n+void CPU_ISP::lastPixelInsert(uint16_t *src, uint16_t *dst, int width, int height)\n {\n int index;\n for (int i = 0; i < height; i++) {\n@@ -390,15 +391,15 @@ void ISP::lastPixelInsert(uint16_t *src, uint16_t *dst, int width, int height)\n }\n }\n \n-void ISP::demosaic(uint16_t *data, uint16_t *R, uint16_t *G, uint16_t *B,\n- int width, int height)\n+void CPU_ISP::demosaic(uint16_t *data, uint16_t *R, uint16_t *G, uint16_t *B,\n+ int width, int height)\n {\n firstPixelInsert(data, B, width, height);\n twoPixelInsert(data, G, width, height);\n lastPixelInsert(data, R, width, height);\n }\n \n-void ISP::autoWhiteBalance(uint16_t *R, uint16_t *G, uint16_t *B, int width, int height)\n+void CPU_ISP::autoWhiteBalance(uint16_t *R, uint16_t *G, uint16_t *B, int width, int height)\n {\n float aveB = 0, aveG = 0, aveR = 0;\n float Kb, Kg, Kr;\n@@ -428,8 +429,7 @@ void ISP::autoWhiteBalance(uint16_t *R, uint16_t *G, uint16_t *B, int width, int\n }\n }\n \n-void ISP::gammaCorrect(uint16_t *R, uint16_t *G, uint16_t *B, float val,\n- int width, int height)\n+void CPU_ISP::gammaCorrect(uint16_t *R, uint16_t *G, uint16_t *B, float val, int width, int height)\n {\n float nor = 1.0 / 1023.0;\n float gamma = 1.0 / val;\n@@ -444,24 +444,24 @@ void ISP::gammaCorrect(uint16_t *R, uint16_t *G, uint16_t *B, float val,\n }\n }\n \n-void ISP::compress_10bit_to_8bit (uint16_t *src, uint8_t *dst, int width, int height)\n+void CPU_ISP::compress_10bit_to_8bit (uint16_t *src, uint8_t *dst, int width, int height)\n {\n for (int i = 0; i < width * height; i++) {\n dst[i] = src[i] >> 2 & 0xff;\n }\n }\n \n-float ISP::distance(int x, int y, int i, int j)\n+float CPU_ISP::distance(int x, int y, int i, int j)\n {\n return float(sqrt(pow(x - i, 2) + pow(y - j, 2)));\n }\n \n-double ISP::gaussian(float x, double sigma)\n+double CPU_ISP::gaussian(float x, double sigma)\n {\n return exp(-(pow(x, 2)) / (2 * pow(sigma, 2))) / (2 * 3.1415926 * pow(sigma, 2));\n }\n \n-void ISP::bilateralFilter(uint16_t *R, uint16_t *G, uint16_t *B,\n+void CPU_ISP::bilateralFilter(uint16_t *R, uint16_t *G, uint16_t *B,\n int diameter, double sigmaI,\n double sigmaS, int width, int height)\n {\n@@ -541,7 +541,12 @@ void ISP::bilateralFilter(uint16_t *R, uint16_t *G, uint16_t *B,\n }\n }\n \n-void ISP::processing(FrameBuffer *srcBuffer, FrameBuffer *dstBuffer, int width, int height)\n+void CPU_ISP::noiseReduction(uint16_t *R, uint16_t *G, uint16_t *B, int width, int height)\n+{\n+ bilateralFilter(R, G, B, 5, 24.0, 32.0, width, height);\n+}\n+\n+void CPU_ISP::processing(FrameBuffer *srcBuffer, FrameBuffer *dstBuffer, int width, int height)\n {\n uint8_t *rgb_buf;\n uint16_t *rawData;\n@@ -554,6 +559,7 @@ void ISP::processing(FrameBuffer *srcBuffer, FrameBuffer *dstBuffer, int width,\n \n const FrameBuffer::Plane &plane = srcBuffer->planes()[0]; \n rawData = (uint16_t *)mmap(NULL, plane.length, PROT_READ|PROT_WRITE, MAP_SHARED, plane.fd.fd(), 0);\n+ LOG(ISP, Debug) << plane.length << \" \" << plane.fd.fd();\n if (rawData == MAP_FAILED) {\n LOG(ISP, Error) << \"Read raw data failed\";\n ispCompleted.emit(dstBuffer);\n@@ -567,7 +573,7 @@ void ISP::processing(FrameBuffer *srcBuffer, FrameBuffer *dstBuffer, int width,\n autoContrast(gData, 0.01, 0.01, width, height);\n autoContrast(bData, 0.01, 0.01, width, height);\n gammaCorrect(rData, gData, bData, 2.2, width, height);\n- //bilateralFilter(rData, gData, bData, 5, 24.0, 32.0);\n+ //bilateralFilter(rData, gData, bData, 5, 24.0, 32.0, width, height);\n \n const FrameBuffer::Plane &rgbPlane = dstBuffer->planes()[0];\n rgb_buf = (uint8_t *)mmap(NULL, rgbPlane.length, PROT_READ|PROT_WRITE, MAP_SHARED, rgbPlane.fd.fd(), 0);\n@@ -584,10 +590,54 @@ void ISP::processing(FrameBuffer *srcBuffer, FrameBuffer *dstBuffer, int width,\n compress_10bit_to_8bit(gData, gData_8, width, height);\n compress_10bit_to_8bit(bData, bData_8, width, height);\n \n+ dstBuffer->metadata_.status = srcBuffer->metadata().status;\n+ dstBuffer->metadata_.sequence = srcBuffer->metadata().sequence;\n+ dstBuffer->metadata_.timestamp = srcBuffer->metadata().timestamp;\n+\n+ dstBuffer->metadata_.planes.clear();\n+ dstBuffer->metadata_.planes.push_back({rgbPlane.length});\n+\n delete[] rgbData;\n \n ispCompleted.emit(dstBuffer);\n }\n \n-} /* namespace libcamera */\n+int CPU_ISP::exportBuffers(std::vector<std::unique_ptr<FrameBuffer>> *buffers,\n+ unsigned int count, int width, int height)\n+{\n+ int bufferByte = width * height * 3;\n+\n+ for (unsigned int i = 0; i < count; i++) {\n+ std::string name = \"frame-\" + std::to_string(i);\n+\n+ const int isp_fd = memfd_create(name.c_str(), 0);\n+ int ret = ftruncate(isp_fd, bufferByte);\n+ if (ret < 0) {\n+ LOG(ISP, Error) << \"Failed to resize memfd\" << strerror(-ret);\n+ return ret;\n+ }\n+\n+ FrameBuffer::Plane rgbPlane;\n+ rgbPlane.fd = FileDescriptor(std::move(isp_fd));\n+ rgbPlane.length = bufferByte;\n+\n+ std::vector<FrameBuffer::Plane> planes{rgbPlane};\n+ buffers->emplace_back(std::make_unique<FrameBuffer>(std::move(planes)));\n+ }\n+\n+ return count;\n+}\n+\n+void CPU_ISP::startThreadISP()\n+{\n+ moveToThread(&thread_);\n+ thread_.start();\n+}\n+\n+void CPU_ISP::stopThreadISP()\n+{\n+ thread_.exit();\n+ thread_.wait();\n+}\n \n+} /* namespace libcamera */\n\\ No newline at end of file\ndiff --git a/src/libcamera/pipeline/isp/isp_processing.h b/src/libcamera/swisp/isp.h\nsimilarity index 54%\nrename from src/libcamera/pipeline/isp/isp_processing.h\nrename to src/libcamera/swisp/isp.h\nindex b80b4218..4099e2c6 100644\n--- a/src/libcamera/pipeline/isp/isp_processing.h\n+++ b/src/libcamera/swisp/isp.h\n@@ -2,15 +2,16 @@\n /*\n * Copyright (C) 2021, Siyuan Fan <siyuan.fan@foxmail.com>\n *\n- * isp_processing.h - The software ISP class\n+ * isp.h - The software ISP class\n */\n-#ifndef __LIBCAMERA_PIPELINE_ISP_PROCESSING_H__\n-#define __LIBCAMERA_PIPELINE_ISP_PROCESSING_H__\n+#ifndef __LIBCAMERA_SWISP_ISP_H__\n+#define __LIBCAMERA_SWISP_ISP_H__\n \n #include <libcamera/framebuffer.h>\n \n-#include \"libcamera/base/signal.h\"\n #include \"libcamera/base/object.h\"\n+#include \"libcamera/base/signal.h\"\n+#include \"libcamera/base/thread.h\"\n \n namespace libcamera{\n \n@@ -19,10 +20,29 @@ using std::uint8_t;\n \n class ISP : public Object\n {\n+public:\n+ ISP() {}\n+\n+ virtual void blackLevelCorrect(uint16_t *data, uint16_t offset, int width, int height) = 0;\n+\n+ virtual void demosaic(uint16_t *data, uint16_t *R, uint16_t *G, uint16_t *B,\n+ int width, int height) = 0;\n+\n+ virtual void autoWhiteBalance(uint16_t *R, uint16_t *G, uint16_t *B, int width, int height) = 0;\n+\n+ virtual void gammaCorrect(uint16_t *R, uint16_t *G, uint16_t *B, float val, int width, int height) = 0;\n+\n+ virtual void noiseReduction(uint16_t *R, uint16_t *G, uint16_t *B, int width, int height) = 0;\n+\n+ virtual ~ISP() {}\n+};\n+\n+class CPU_ISP : public ISP\n+{\n public:\n void autoContrast(uint16_t *data, float lowCut, float highCut, int width, int height);\n \n- void blackLevelCorrect(uint16_t *data, uint16_t offset, int width, int height);\n+ void blackLevelCorrect(uint16_t *data, uint16_t offset, int width, int height) override;\n \n void readChannels(uint16_t *data, uint16_t *R, uint16_t *G, uint16_t *B,\n int width, int height);\n@@ -34,12 +54,11 @@ public:\n void lastPixelInsert(uint16_t *src, uint16_t *dst, int width, int height);\n \n void demosaic(uint16_t *data, uint16_t *R, uint16_t *G, uint16_t *B,\n- int width, int height);\n+ int width, int height) override;\n \n- void autoWhiteBalance(uint16_t *R, uint16_t *G, uint16_t *B, int width, int height);\n+ void autoWhiteBalance(uint16_t *R, uint16_t *G, uint16_t *B, int width, int height) override;\n \n- void gammaCorrect(uint16_t *R, uint16_t *G, uint16_t *B, float val,\n- int width, int height);\n+ void gammaCorrect(uint16_t *R, uint16_t *G, uint16_t *B, float val, int width, int height) override;\n \n float distance(int x, int y, int i, int j);\n \n@@ -49,14 +68,25 @@ public:\n int diameter, double sigmaI, double sigmaS,\n int width, int height);\n \n+ void noiseReduction(uint16_t *R, uint16_t *G, uint16_t *B, int width, int height) override;\n+\n void compress_10bit_to_8bit(uint16_t *src, uint8_t *dst, int width, int height); \n \n void processing(FrameBuffer *srcBuffer, FrameBuffer *dstBuffer, int width, int height);\n \n+ int exportBuffers(std::vector<std::unique_ptr<FrameBuffer>> *buffers,\n+ unsigned int count, int width, int height);\n+\n+ void startThreadISP();\n+\n+ void stopThreadISP();\n+\n Signal<FrameBuffer *> ispCompleted;\n \n+private:\n+ Thread thread_;\n };\n \n-}\n+} /* namespace libcamera */\n \n-#endif /* __LIBCAMERA_PIPELINE_ISP_PROCESSING_H__ */\n+#endif /* __LIBCAMERA_SWISP_ISP_H__ */\n\\ No newline at end of file\n", "prefixes": [ "libcamera-devel", "RFC", "v2", "2/4" ] }