Patch Detail
Show a patch.
GET /api/1.1/patches/13226/?format=api
{ "id": 13226, "url": "https://patchwork.libcamera.org/api/1.1/patches/13226/?format=api", "web_url": "https://patchwork.libcamera.org/patch/13226/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210805175848.24188-9-laurent.pinchart@ideasonboard.com>", "date": "2021-08-05T17:58:45", "name": "[libcamera-devel,v2,08/11] libcamera: pipeline: ipu3: Migrate to Camera::Private", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "700d69dc21c2f44eeb795df5ddc57df04887bc1a", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/13226/mbox/", "series": [ { "id": 2312, "url": "https://patchwork.libcamera.org/api/1.1/series/2312/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2312", "date": "2021-08-05T17:58:37", "name": "libcamera: Replace CameraData with Camera::Private", "version": 2, "mbox": "https://patchwork.libcamera.org/series/2312/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/13226/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/13226/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1FAF3C323B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 5 Aug 2021 17:59:13 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CA7DA6888A;\n\tThu, 5 Aug 2021 19:59:12 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9E1C668888\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 5 Aug 2021 19:59:07 +0200 (CEST)", "from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 44178E04\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 5 Aug 2021 19:59:07 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"B8sDJ+nr\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1628186347;\n\tbh=QKxYL1Gxkt/R41Xd3kOJLKixYc3td9asEKVUQnhiKZU=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=B8sDJ+nrsR/OoBD2lSLIfsBfZkAP6Uwpq7xNBxfRY9wXbD36EbMQMaYZHJ0j6NRku\n\tJkwT3EwfdKmPcSLzfvJhx6YRsHZUJubFm4A7Ix058nul5lVsI9Im/cRC65ws5RLbum\n\t3v3fdCb2u5BRxliZadedsGtTGscDW50jrnkUJ4fY=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 5 Aug 2021 20:58:45 +0300", "Message-Id": "<20210805175848.24188-9-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.31.1", "In-Reply-To": "<20210805175848.24188-1-laurent.pinchart@ideasonboard.com>", "References": "<20210805175848.24188-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 08/11] libcamera: pipeline: ipu3:\n\tMigrate to Camera::Private", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "As part of the effort to remove the CameraData class, migrate the\npipeline handler-specific camera data from CameraData to the\nCamera::Private class.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n---\n src/libcamera/pipeline/ipu3/ipu3.cpp | 38 +++++++++++++---------------\n 1 file changed, 18 insertions(+), 20 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex 15d6cca609ff..6d097ac91d2e 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -53,11 +53,11 @@ static const ControlInfoMap::Map IPU3Controls = {\n \t{ &controls::draft::PipelineDepth, ControlInfo(2, 3) },\n };\n \n-class IPU3CameraData : public CameraData\n+class IPU3CameraData : public Camera::Private\n {\n public:\n \tIPU3CameraData(PipelineHandler *pipe)\n-\t\t: CameraData(pipe), exposureTime_(0), supportsFlips_(false)\n+\t\t: Camera::Private(pipe), exposureTime_(0), supportsFlips_(false)\n \t{\n \t}\n \n@@ -146,10 +146,9 @@ public:\n \tbool match(DeviceEnumerator *enumerator) override;\n \n private:\n-\tIPU3CameraData *cameraData(const Camera *camera)\n+\tIPU3CameraData *cameraData(Camera *camera)\n \t{\n-\t\treturn static_cast<IPU3CameraData *>(\n-\t\t\tPipelineHandler::cameraData(camera));\n+\t\treturn static_cast<IPU3CameraData *>(camera->_d());\n \t}\n \n \tint initControls(IPU3CameraData *data);\n@@ -800,10 +799,10 @@ void IPU3CameraData::cancelPendingRequests()\n \t\tfor (auto it : request->buffers()) {\n \t\t\tFrameBuffer *buffer = it.second;\n \t\t\tbuffer->cancel();\n-\t\t\tpipe_->completeBuffer(request, buffer);\n+\t\t\tpipe()->completeBuffer(request, buffer);\n \t\t}\n \n-\t\tpipe_->completeRequest(request);\n+\t\tpipe()->completeRequest(request);\n \t\tpendingRequests_.pop();\n \t}\n }\n@@ -1184,12 +1183,11 @@ int PipelineHandlerIPU3::registerCameras()\n \t\t\t\t\t&IPU3CameraData::statBufferReady);\n \n \t\t/* Create and register the Camera instance. */\n-\t\tstd::string cameraId = cio2->sensor()->id();\n+\t\tconst std::string &cameraId = cio2->sensor()->id();\n \t\tstd::shared_ptr<Camera> camera =\n-\t\t\tCamera::create(new Camera::Private(this), cameraId,\n-\t\t\t\t streams);\n+\t\t\tCamera::create(data.release(), cameraId, streams);\n \n-\t\tregisterCamera(std::move(camera), std::move(data));\n+\t\tregisterCamera(std::move(camera), nullptr);\n \n \t\tLOG(IPU3, Info)\n \t\t\t<< \"Registered Camera[\" << numCameras << \"] \\\"\"\n@@ -1204,7 +1202,7 @@ int PipelineHandlerIPU3::registerCameras()\n \n int IPU3CameraData::loadIPA()\n {\n-\tipa_ = IPAManager::createIPA<ipa::ipu3::IPAProxyIPU3>(pipe_, 1, 1);\n+\tipa_ = IPAManager::createIPA<ipa::ipu3::IPAProxyIPU3>(pipe(), 1, 1);\n \tif (!ipa_)\n \t\treturn -ENOENT;\n \n@@ -1261,7 +1259,7 @@ void IPU3CameraData::queueFrameAction(unsigned int id,\n \n \t\tinfo->metadataProcessed = true;\n \t\tif (frameInfos_.tryComplete(info))\n-\t\t\tpipe_->completeRequest(request);\n+\t\t\tpipe()->completeRequest(request);\n \n \t\tbreak;\n \t}\n@@ -1289,7 +1287,7 @@ void IPU3CameraData::imguOutputBufferReady(FrameBuffer *buffer)\n \n \tRequest *request = info->request;\n \n-\tpipe_->completeBuffer(request, buffer);\n+\tpipe()->completeBuffer(request, buffer);\n \n \trequest->metadata().set(controls::draft::PipelineDepth, 3);\n \t/* \\todo Move the ExposureTime control to the IPA. */\n@@ -1300,7 +1298,7 @@ void IPU3CameraData::imguOutputBufferReady(FrameBuffer *buffer)\n \trequest->metadata().set(controls::ScalerCrop, cropRegion_);\n \n \tif (frameInfos_.tryComplete(info))\n-\t\tpipe_->completeRequest(request);\n+\t\tpipe()->completeRequest(request);\n }\n \n /**\n@@ -1332,16 +1330,16 @@ void IPU3CameraData::cio2BufferReady(FrameBuffer *buffer)\n \t\tfor (auto it : request->buffers()) {\n \t\t\tFrameBuffer *b = it.second;\n \t\t\tb->cancel();\n-\t\t\tpipe_->completeBuffer(request, b);\n+\t\t\tpipe()->completeBuffer(request, b);\n \t\t}\n \n \t\tframeInfos_.remove(info);\n-\t\tpipe_->completeRequest(request);\n+\t\tpipe()->completeRequest(request);\n \t\treturn;\n \t}\n \n \tif (request->findBuffer(&rawStream_))\n-\t\tpipe_->completeBuffer(request, buffer);\n+\t\tpipe()->completeBuffer(request, buffer);\n \n \tipa::ipu3::IPU3Event ev;\n \tev.op = ipa::ipu3::EventFillParams;\n@@ -1367,7 +1365,7 @@ void IPU3CameraData::paramBufferReady(FrameBuffer *buffer)\n \tRequest *request = info->request;\n \n \tif (frameInfos_.tryComplete(info))\n-\t\tpipe_->completeRequest(request);\n+\t\tpipe()->completeRequest(request);\n }\n \n void IPU3CameraData::statBufferReady(FrameBuffer *buffer)\n@@ -1386,7 +1384,7 @@ void IPU3CameraData::statBufferReady(FrameBuffer *buffer)\n \t\t * In that event, we must have obtained the Request before hand.\n \t\t */\n \t\tif (frameInfos_.tryComplete(info))\n-\t\t\tpipe_->completeRequest(request);\n+\t\t\tpipe()->completeRequest(request);\n \n \t\treturn;\n \t}\n", "prefixes": [ "libcamera-devel", "v2", "08/11" ] }