Patch Detail
Show a patch.
GET /api/1.1/patches/13204/?format=api
{ "id": 13204, "url": "https://patchwork.libcamera.org/api/1.1/patches/13204/?format=api", "web_url": "https://patchwork.libcamera.org/patch/13204/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210804132526.162376-1-umang.jain@ideasonboard.com>", "date": "2021-08-04T13:25:26", "name": "[libcamera-devel,v2] ipu3: Disallow raw only camera configuration", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "82a44cc9c4e5ed9c80ab1e141ab9449b24730fce", "submitter": { "id": 86, "url": "https://patchwork.libcamera.org/api/1.1/people/86/?format=api", "name": "Umang Jain", "email": "umang.jain@ideasonboard.com" }, "delegate": { "id": 12, "url": "https://patchwork.libcamera.org/api/1.1/users/12/?format=api", "username": "uajain", "first_name": "Umang", "last_name": "Jain", "email": "umang.jain@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/patch/13204/mbox/", "series": [ { "id": 2304, "url": "https://patchwork.libcamera.org/api/1.1/series/2304/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2304", "date": "2021-08-04T13:25:26", "name": "[libcamera-devel,v2] ipu3: Disallow raw only camera configuration", "version": 2, "mbox": "https://patchwork.libcamera.org/series/2304/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/13204/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/13204/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 80319C3232\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 4 Aug 2021 13:25:35 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E2E94687B6;\n\tWed, 4 Aug 2021 15:25:34 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B5BD36026E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 4 Aug 2021 15:25:33 +0200 (CEST)", "from perceval.ideasonboard.com (unknown [103.251.226.40])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8094324F;\n\tWed, 4 Aug 2021 15:25:32 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"VQ2tG5Gr\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1628083533;\n\tbh=2fgjKcbCG0DG+hVy80XxmSIlVDuYlmOwuDtxn7LcdGA=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=VQ2tG5GrZVHXy2oQfnkK46bLDDFeMAg7EH+Ag4rWBwo4F/TYtjL6v9IjKB4zkJFVw\n\tFCaC3/2WL/RWU5Roe39fphSqQJOm0WCbtw92Yp195xmFWJ64YDuUp2tgIhA4DiUk9M\n\tUXsMZz1uTLj4XeJIVzWauCz7MkOhGgpURGeZyCXQ=", "From": "Umang Jain <umang.jain@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 4 Aug 2021 18:55:26 +0530", "Message-Id": "<20210804132526.162376-1-umang.jain@ideasonboard.com>", "X-Mailer": "git-send-email 2.31.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2] ipu3: Disallow raw only camera\n\tconfiguration", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Ideally to capture the raw frames, ImgU should not be required.\nHowever, we do need to configure the IPA since it shall setup\nthe sensor controls (exposure, vblank and so on) for the capture.\nOne cannot simply configure the IPA, without the ImgU as the\nparameters and statistics buffer passed to the IPA are actually\nmanaged by the ImgU.\n\nUntil we prepare and setup the ImgU to run an internal queue for\nraw-only camera configuration, disallow this configuration and\nreport it as invalid.\n\nSigned-off-by: Umang Jain <umang.jain@ideasonboard.com>\n---\n src/libcamera/pipeline/ipu3/ipu3.cpp | 14 ++++++++++++++\n 1 file changed, 14 insertions(+)", "diff": "diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex 76c3bb3d..9f6a6f21 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -248,6 +248,20 @@ CameraConfiguration::Status IPU3CameraConfiguration::validate()\n \tif (rawCount > 1 || yuvCount > 2) {\n \t\tLOG(IPU3, Debug) << \"Camera configuration not supported\";\n \t\treturn Invalid;\n+\t} else if (rawCount && !yuvCount) {\n+\t\t/*\n+\t\t * Disallow raw-only camera configuration. Currently, ImgU does\n+\t\t * not get configured for raw-only streams and has early return\n+\t\t * in configure(). To support raw-only stream, we do need the IPA\n+\t\t * to get configured since it will setup the sensor controls for\n+\t\t * the capture.\n+\t\t *\n+\t\t * \\todo Configure the ImgU with internal buffers which will enable\n+\t\t * the IPA to get configured, for the raw-only camera configuration.\n+\t\t */\n+\t\tLOG(IPU3, Debug)\n+\t\t\t<< \"Camera configuration cannot support raw-only streams\";\n+\t\treturn Invalid;\n \t}\n \n \t/*\n", "prefixes": [ "libcamera-devel", "v2" ] }