Patch Detail
Show a patch.
GET /api/1.1/patches/13107/?format=api
{ "id": 13107, "url": "https://patchwork.libcamera.org/api/1.1/patches/13107/?format=api", "web_url": "https://patchwork.libcamera.org/patch/13107/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210723112233.1361319-2-umang.jain@ideasonboard.com>", "date": "2021-07-23T11:22:32", "name": "[libcamera-devel,1/2] media: imx258: Rectify mismatch of VTS value", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": false, "hash": "0285837d9356c46077e5e15bd6408e820c067998", "submitter": { "id": 86, "url": "https://patchwork.libcamera.org/api/1.1/people/86/?format=api", "name": "Umang Jain", "email": "umang.jain@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/13107/mbox/", "series": [ { "id": 2273, "url": "https://patchwork.libcamera.org/api/1.1/series/2273/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2273", "date": "2021-07-23T11:22:31", "name": "IMX258 driver fixes", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2273/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/13107/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/13107/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8ED14C322C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 23 Jul 2021 11:22:46 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 471C4687A6;\n\tFri, 23 Jul 2021 13:22:45 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E879368536\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 23 Jul 2021 13:22:43 +0200 (CEST)", "from perceval.ideasonboard.com (unknown [103.251.226.103])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A7862885;\n\tFri, 23 Jul 2021 13:22:42 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"HniKeMM2\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1627039363;\n\tbh=ftX9QVrpqRPkwwZDC6EZFxog/v2aUTQrh0HjXGjTriY=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=HniKeMM2nVl6oXfgfmEiZpauI4g5yq4uxYULb+vyxjDhzGa6OgAd5dDOzr6rf9Upq\n\t2YgxTpFlWjWs/PRwMU4CoUFAM/1/TyEx+JLdpixqCaekBWjI3eeEmefkQpuWSNmVms\n\tdEazLi1Crkj8nHLOL5EJwRGuWpMKjiPa0tXwy+vw=", "From": "Umang Jain <umang.jain@ideasonboard.com>", "To": "linux-media@vger.kernel.org", "Date": "Fri, 23 Jul 2021 16:52:32 +0530", "Message-Id": "<20210723112233.1361319-2-umang.jain@ideasonboard.com>", "X-Mailer": "git-send-email 2.31.1", "In-Reply-To": "<20210723112233.1361319-1-umang.jain@ideasonboard.com>", "References": "<20210723112233.1361319-1-umang.jain@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 1/2] media: imx258: Rectify mismatch of\n\tVTS value", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Cc": "libcamera-devel@lists.libcamera.org", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\nThe frame_length_lines (0x0340) registers are hard-coded as follows:\n\n- 4208x3118\n frame_length_lines = 0x0c50\n\n- 2104x1560\n frame_length_lines = 0x0638\n\n- 1048x780\n frame_length_lines = 0x034c\n\nThe driver exposes the V4L2_CID_VBLANK control in read-only mode and\nsets its value to vts_def - height, where vts_def is a mode-dependent\nvalue coming from the supported_modes array. It is set using one of\nthe following macros defined in the driver:\n\n #define IMX258_VTS_30FPS 0x0c98\n #define IMX258_VTS_30FPS_2K 0x0638\n #define IMX258_VTS_30FPS_VGA 0x034c\n\nThere's a clear mismatch in the value for the full resolution mode i.e.\nIMX258_VTS_30FPS. Fix it by rectifying the macro with the value set for\nthe frame_length_lines register as stated above.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nSigned-off-by: Umang Jain <umang.jain@ideasonboard.com>\n---\n drivers/media/i2c/imx258.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/drivers/media/i2c/imx258.c b/drivers/media/i2c/imx258.c\nindex 7ab9e5f9f267..4e695096e5d0 100644\n--- a/drivers/media/i2c/imx258.c\n+++ b/drivers/media/i2c/imx258.c\n@@ -23,7 +23,7 @@\n #define IMX258_CHIP_ID\t\t\t0x0258\n \n /* V_TIMING internal */\n-#define IMX258_VTS_30FPS\t\t0x0c98\n+#define IMX258_VTS_30FPS\t\t0x0c50\n #define IMX258_VTS_30FPS_2K\t\t0x0638\n #define IMX258_VTS_30FPS_VGA\t\t0x034c\n #define IMX258_VTS_MAX\t\t\t0xffff\n", "prefixes": [ "libcamera-devel", "1/2" ] }