Patch Detail
Show a patch.
GET /api/1.1/patches/13097/?format=api
{ "id": 13097, "url": "https://patchwork.libcamera.org/api/1.1/patches/13097/?format=api", "web_url": "https://patchwork.libcamera.org/patch/13097/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210723040036.32346-12-laurent.pinchart@ideasonboard.com>", "date": "2021-07-23T04:00:30", "name": "[libcamera-devel,RFC,11/17] libcamera: pipeline: uvcvideo: Migrate to Camera::Private", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "de1950de40a124841e5b28816246f9dc39a78c21", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/13097/mbox/", "series": [ { "id": 2270, "url": "https://patchwork.libcamera.org/api/1.1/series/2270/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2270", "date": "2021-07-23T04:00:19", "name": "libcamera: Replace CameraData with Camera::Private", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2270/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/13097/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/13097/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DA7D3C322B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 23 Jul 2021 04:00:55 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8120A687B0;\n\tFri, 23 Jul 2021 06:00:55 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A0E8E687B8\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 23 Jul 2021 06:00:46 +0200 (CEST)", "from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 480793F2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 23 Jul 2021 06:00:46 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"hZ5crH3Q\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1627012846;\n\tbh=3DtBBVxGIVC49GG2tY0w3L2TSGfDvX473+kQYROvREs=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=hZ5crH3QhLK9ttV/cvRc3kXId/7LoKlpVQZsQzQurjLvtV7L5aMGi1+cTdgDvjwc+\n\t5qWnW4xdBkuaAcc4o8ukGVR3lnLe/y99vIUKDupvD4kcKdy+cbXjdPLKormFf3343b\n\tDwh/29p/YDPfCp4S4Ar06XRKaOIq1QaEEYtK+P0g=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 23 Jul 2021 07:00:30 +0300", "Message-Id": "<20210723040036.32346-12-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.31.1", "In-Reply-To": "<20210723040036.32346-1-laurent.pinchart@ideasonboard.com>", "References": "<20210723040036.32346-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [RFC PATCH 11/17] libcamera: pipeline: uvcvideo:\n\tMigrate to Camera::Private", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "As part of the effort to remove the CameraData class, migrate the\npipeline handler-specific camera data from CameraData to the\nCamera::Private class.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 17 ++++++++---------\n 1 file changed, 8 insertions(+), 9 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\nindex 63cb1daaae22..bbeeda97a91a 100644\n--- a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n+++ b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n@@ -33,11 +33,11 @@ namespace libcamera {\n \n LOG_DEFINE_CATEGORY(UVC)\n \n-class UVCCameraData : public CameraData\n+class UVCCameraData : public Camera::Private\n {\n public:\n \tUVCCameraData(PipelineHandler *pipe)\n-\t\t: CameraData(pipe)\n+\t\t: Camera::Private(pipe)\n \t{\n \t}\n \n@@ -87,10 +87,9 @@ private:\n \t\t\t const ControlValue &value);\n \tint processControls(UVCCameraData *data, Request *request);\n \n-\tUVCCameraData *cameraData(const Camera *camera)\n+\tUVCCameraData *cameraData(Camera *camera)\n \t{\n-\t\treturn static_cast<UVCCameraData *>(\n-\t\t\tPipelineHandler::cameraData(camera));\n+\t\treturn static_cast<UVCCameraData *>(camera->_d());\n \t}\n };\n \n@@ -472,8 +471,8 @@ bool PipelineHandlerUVC::match(DeviceEnumerator *enumerator)\n \n \tstd::set<Stream *> streams{ &data->stream_ };\n \tstd::shared_ptr<Camera> camera =\n-\t\tCamera::create(new Camera::Private(this), id, streams);\n-\tregisterCamera(std::move(camera), std::move(data));\n+\t\tCamera::create(data.release(), id, streams);\n+\tregisterCamera(std::move(camera), nullptr);\n \n \t/* Enable hot-unplug notifications. */\n \thotplugMediaDevice(media);\n@@ -668,8 +667,8 @@ void UVCCameraData::bufferReady(FrameBuffer *buffer)\n \trequest->metadata().set(controls::SensorTimestamp,\n \t\t\t\tbuffer->metadata().timestamp);\n \n-\tpipe_->completeBuffer(request, buffer);\n-\tpipe_->completeRequest(request);\n+\tpipe()->completeBuffer(request, buffer);\n+\tpipe()->completeRequest(request);\n }\n \n REGISTER_PIPELINE_HANDLER(PipelineHandlerUVC)\n", "prefixes": [ "libcamera-devel", "RFC", "11/17" ] }