Patch Detail
Show a patch.
GET /api/1.1/patches/13070/?format=api
{ "id": 13070, "url": "https://patchwork.libcamera.org/api/1.1/patches/13070/?format=api", "web_url": "https://patchwork.libcamera.org/patch/13070/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210722112250.805973-1-umang.jain@ideasonboard.com>", "date": "2021-07-22T11:22:50", "name": "[libcamera-devel,v2] libipa: Add CameraSensorHelper for IMX258", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "f18d439f1ce14ed7f9ab09db23b8a33d447fbe42", "submitter": { "id": 86, "url": "https://patchwork.libcamera.org/api/1.1/people/86/?format=api", "name": "Umang Jain", "email": "umang.jain@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/13070/mbox/", "series": [ { "id": 2266, "url": "https://patchwork.libcamera.org/api/1.1/series/2266/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2266", "date": "2021-07-22T11:22:50", "name": "[libcamera-devel,v2] libipa: Add CameraSensorHelper for IMX258", "version": 2, "mbox": "https://patchwork.libcamera.org/series/2266/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/13070/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/13070/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 676DEC322B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 22 Jul 2021 11:23:00 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B9F6568543;\n\tThu, 22 Jul 2021 13:22:59 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 762176027A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 22 Jul 2021 13:22:58 +0200 (CEST)", "from perceval.ideasonboard.com (unknown [103.238.109.21])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 58D37465;\n\tThu, 22 Jul 2021 13:22:57 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"OjNLTXXh\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1626952978;\n\tbh=LNSEhVMASzZWUTpu7E3xXeRHGONI4Chew2bcS3xmiNc=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=OjNLTXXhewKcBms8s+513+4u4fOgIyhqEb+pElP2cmwTQSLt963DLTa4P9v9giekW\n\tUpYKGJVXCvH4OMayR1GAm8SOpPUNpYKoUId15jU2yDpEAW5dRQrkndRGmX0jXjAFFy\n\tEXj1/fLGR/wG3JL6Ic9HnwgUGqQRgt6kHOd6Kfsg=", "From": "Umang Jain <umang.jain@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 22 Jul 2021 16:52:50 +0530", "Message-Id": "<20210722112250.805973-1-umang.jain@ideasonboard.com>", "X-Mailer": "git-send-email 2.31.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2] libipa: Add CameraSensorHelper for\n\tIMX258", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Extend the CameraSensorHelper factory with support for the IMX258\nsensor found in the Nautilus Chromebook.\n\nThe values are read by manually tweaking the IMX258 kernel driver.\nThe IMX258 kernel driver hints that the sensor may be compatible\nwith the MIPI CCS specification, as the register set matches.\nThe values for analog gain constants are obtained by reading the\nregister indexes, corresponding to the analog gain constants, as\nmentioned in MIPI CCS v1.1 specification.\n\nSigned-off-by: Umang Jain <umang.jain@ideasonboard.com>\n---\nv1 -> v2:\n- Revamp commit message. \n- Dave from RPi can confirm these values from the datasheet.\n---\n src/ipa/libipa/camera_sensor_helper.cpp | 10 ++++++++++\n 1 file changed, 10 insertions(+)", "diff": "diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\nindex 709835a8..c43368df 100644\n--- a/src/ipa/libipa/camera_sensor_helper.cpp\n+++ b/src/ipa/libipa/camera_sensor_helper.cpp\n@@ -295,6 +295,16 @@ public:\n };\n REGISTER_CAMERA_SENSOR_HELPER(\"imx219\", CameraSensorHelperImx219)\n \n+class CameraSensorHelperImx258 : public CameraSensorHelper\n+{\n+public:\n+ CameraSensorHelperImx258()\n+ {\n+ analogueGainConstants_ = { AnalogueGainLinear, 0, 512, -1, 512 };\n+ }\n+};\n+REGISTER_CAMERA_SENSOR_HELPER(\"imx258\", CameraSensorHelperImx258)\n+\n class CameraSensorHelperOv5670 : public CameraSensorHelper\n {\n public:\n", "prefixes": [ "libcamera-devel", "v2" ] }