Patch Detail
Show a patch.
GET /api/1.1/patches/13062/?format=api
{ "id": 13062, "url": "https://patchwork.libcamera.org/api/1.1/patches/13062/?format=api", "web_url": "https://patchwork.libcamera.org/patch/13062/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210720173548.313901-1-vedantparanjape160201@gmail.com>", "date": "2021-07-20T17:35:47", "name": "[libcamera-devel,RFC,v1,1/2] gstreamer: Factor out _pad_push_stream_start from _task_enter", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "a2478e073935a5bfd2a9a1a6d12d221dcd0b645b", "submitter": { "id": 85, "url": "https://patchwork.libcamera.org/api/1.1/people/85/?format=api", "name": "Vedant Paranjape", "email": "vedantparanjape160201@gmail.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/13062/mbox/", "series": [ { "id": 2262, "url": "https://patchwork.libcamera.org/api/1.1/series/2262/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2262", "date": "2021-07-20T17:35:47", "name": "[libcamera-devel,RFC,v1,1/2] gstreamer: Factor out _pad_push_stream_start from _task_enter", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2262/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/13062/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/13062/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3F2DFC322B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 20 Jul 2021 17:36:13 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7E01A6852A;\n\tTue, 20 Jul 2021 19:36:12 +0200 (CEST)", "from mail-pg1-x534.google.com (mail-pg1-x534.google.com\n\t[IPv6:2607:f8b0:4864:20::534])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6F50868521\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 20 Jul 2021 19:36:11 +0200 (CEST)", "by mail-pg1-x534.google.com with SMTP id t9so23189919pgn.4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 20 Jul 2021 10:36:11 -0700 (PDT)", "from localhost.localdomain ([1.186.165.221])\n\tby smtp.googlemail.com with ESMTPSA id\n\tcp8sm8271113pjb.27.2021.07.20.10.36.07\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 20 Jul 2021 10:36:09 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"E5ImE4xo\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=QfzlIZvRRrQ+Dzm43JuVObfNnYivEBjggFAXwbLJ3ok=;\n\tb=E5ImE4xonlHtOxlLHYrofyXP8cKo51WHAvJlBFt5IrHE2o/5aiqNaYEDMZzuVyQrYU\n\t16f23zsayTUVYgGD9BNHYeptQbBo14/AmnU6B35r/6VHNpDKm5UXXds+sAb2koqu8C62\n\tR7mcd9udLDGNu02o4w+1XiNLuLZU6gyT5G5WhxmFue8mN9ckTG6ZcR+NmTbOdgotGvWj\n\tDza+TgK4BfUETOh/0hMB9UZX8cXe+2Sf0By8rUXD6KDxnogv9RBjWHDPpVi/Im81Y5Fu\n\tdZHfpoN07lE3FfA6SZjJTOrcUIpJ1g5uOHVrLYcoZZEDb76QMLJYS8s6eqFClozIvX77\n\tAMUA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=QfzlIZvRRrQ+Dzm43JuVObfNnYivEBjggFAXwbLJ3ok=;\n\tb=jl9dS5pv0VDLcm/A2xv/zfaF9SqsOShSOhwHc391MHXxjlWJp6eYuqGxuHilvY4OOd\n\tSz4Z0F9L3ihqrNvbBreKPW+IUC5iQs0mZcZ8sky7hDkUglFRJ3biCkhn00PwW2svHTZP\n\tFLzWRvAjtJz9frZPSFxwLu0/4Lro5mIl7s8M1aoYysdixvt86AQRtw/p5NKOtEiv3LdB\n\tQjpMylakXYdyPr4L7XXCV8A8pBAt6inJuoV0ah/ZqknSeFVYk9ovrmNh7GtCWYFtquCg\n\tRqex2QcbbPkDWjyM/cvWGLXssE8GxpVixb4rtj205urXXsj3VYnrI+fmGLJC6uBD3Bhl\n\tLthQ==", "X-Gm-Message-State": "AOAM531rRPR0Mqe17YyCu+egzct+EFYbiLeS5dy/ntuPiLZA43IJZW0j\n\tW8MRszbmm3/g1e2yAGf/5iQjfTZerdCfKw==", "X-Google-Smtp-Source": "ABdhPJx4QbmTIagd9e0yn5E5lfc6U/QhWLRd0noiFXiZGxFpc47d5e9gN1F5Scss6wrZ94zICEoyfA==", "X-Received": "by 2002:a05:6a00:1582:b029:333:a366:fe47 with SMTP id\n\tu2-20020a056a001582b0290333a366fe47mr28600550pfk.0.1626802569582; \n\tTue, 20 Jul 2021 10:36:09 -0700 (PDT)", "From": "Vedant Paranjape <vedantparanjape160201@gmail.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 20 Jul 2021 23:05:47 +0530", "Message-Id": "<20210720173548.313901-1-vedantparanjape160201@gmail.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [RFC PATCH v1 1/2] gstreamer: Factor out\n\t_pad_push_stream_start from _task_enter", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Cc": "Vedant Paranjape <vedantparanjape160201@gmail.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "This patch creates gst_libcamera_pad_push_stream_start function to\ncreate stream id and to push the stream start. This is a non functional\nchange.\n\nSigned-off-by: Vedant Paranjape <vedantparanjape160201@gmail.com>\n---\n src/gstreamer/gstlibcamerapad.cpp | 13 +++++++++++++\n src/gstreamer/gstlibcamerapad.h | 2 ++\n 2 files changed, 15 insertions(+)", "diff": "diff --git a/src/gstreamer/gstlibcamerapad.cpp b/src/gstreamer/gstlibcamerapad.cpp\nindex c00e81c8..c5bd14f0 100644\n--- a/src/gstreamer/gstlibcamerapad.cpp\n+++ b/src/gstreamer/gstlibcamerapad.cpp\n@@ -155,6 +155,19 @@ gst_libcamera_pad_get_stream(GstPad *pad)\n \treturn nullptr;\n }\n \n+void\n+gst_libcamera_pad_push_stream_start(GstPad *pad, const guint group_id)\n+{\n+\tg_autoptr(GstElement) element = gst_pad_get_parent_element(pad);\n+\tstatic gint stream_id_num = 0;\n+\n+\tg_autofree gchar *stream_id_intermediate = g_strdup_printf(\"%i%i\", group_id, g_atomic_int_add(&stream_id_num, 1));\n+\tg_autofree gchar *stream_id = gst_pad_create_stream_id(pad, element, stream_id_intermediate);\n+\tGstEvent *event = gst_event_new_stream_start(stream_id);\n+\tgst_event_set_group_id(event, group_id);\n+\tgst_pad_push_event(pad, event);\n+}\n+\n void\n gst_libcamera_pad_queue_buffer(GstPad *pad, GstBuffer *buffer)\n {\ndiff --git a/src/gstreamer/gstlibcamerapad.h b/src/gstreamer/gstlibcamerapad.h\nindex 779f2d13..7693374f 100644\n--- a/src/gstreamer/gstlibcamerapad.h\n+++ b/src/gstreamer/gstlibcamerapad.h\n@@ -26,6 +26,8 @@ void gst_libcamera_pad_set_pool(GstPad *pad, GstLibcameraPool *pool);\n \n libcamera::Stream *gst_libcamera_pad_get_stream(GstPad *pad);\n \n+void gst_libcamera_pad_push_stream_start(GstPad *pad, const guint group_id);\n+\n void gst_libcamera_pad_queue_buffer(GstPad *pad, GstBuffer *buffer);\n \n GstFlowReturn gst_libcamera_pad_push_pending(GstPad *pad);\n", "prefixes": [ "libcamera-devel", "RFC", "v1", "1/2" ] }