Patch Detail
Show a patch.
GET /api/1.1/patches/13057/?format=api
{ "id": 13057, "url": "https://patchwork.libcamera.org/api/1.1/patches/13057/?format=api", "web_url": "https://patchwork.libcamera.org/patch/13057/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210720101307.26010-9-paul.elder@ideasonboard.com>", "date": "2021-07-20T10:13:06", "name": "[libcamera-devel,v5,8/9] android: Add skeletal still and manual request templates", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "eb04bf315509437957fa78879b9005dbc4b49c51", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/1.1/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/13057/mbox/", "series": [ { "id": 2258, "url": "https://patchwork.libcamera.org/api/1.1/series/2258/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2258", "date": "2021-07-20T10:12:58", "name": "android: Support capability and hardware level detection", "version": 5, "mbox": "https://patchwork.libcamera.org/series/2258/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/13057/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/13057/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D1075C0109\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 20 Jul 2021 10:13:37 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 94C8568550;\n\tTue, 20 Jul 2021 12:13:37 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1685368541\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 20 Jul 2021 12:13:36 +0200 (CEST)", "from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 55D5B51D;\n\tTue, 20 Jul 2021 12:13:34 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"CAXbMsqB\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1626776015;\n\tbh=glE8P1C2yIQv2kk1hPmHaoL/GPVfbGpOaNGOaLZEG8Y=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=CAXbMsqBrggsafhQBya4clRQvMDXWEg3iJwXI3oddr5Mse0U7XJFz+FAtzgKBktB/\n\t28bYgkSC6MzdnwAsa25g81XQ/bSmYUCLCTBKYz4EQDZlzgv8ctuMAU5DylUZcuf0JE\n\tIyQ8ukqMTvrBg5r452NQJOZq3nYJP6cXCc2wEg4s=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 20 Jul 2021 19:13:06 +0900", "Message-Id": "<20210720101307.26010-9-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20210720101307.26010-1-paul.elder@ideasonboard.com>", "References": "<20210720101307.26010-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v5 8/9] android: Add skeletal still and\n\tmanual request templates", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add skeletal still and manual request templates so that we can expand\nthem for FULL support.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\nReviewed-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/android/camera_capabilities.cpp | 18 ++++++++++++++++++\n src/android/camera_capabilities.h | 2 ++\n src/android/camera_device.cpp | 7 +++++--\n 3 files changed, 25 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/android/camera_capabilities.cpp b/src/android/camera_capabilities.cpp\nindex 4048a94b..8c425138 100644\n--- a/src/android/camera_capabilities.cpp\n+++ b/src/android/camera_capabilities.cpp\n@@ -1445,3 +1445,21 @@ std::unique_ptr<CameraMetadata> CameraCapabilities::requestTemplateVideo() const\n \n \treturn previewTemplate;\n }\n+\n+std::unique_ptr<CameraMetadata> CameraCapabilities::requestTemplateStill() const\n+{\n+\tstd::unique_ptr<CameraMetadata> stillTemplate = requestTemplatePreview();\n+\tif (!stillTemplate)\n+\t\treturn nullptr;\n+\n+\treturn stillTemplate;\n+}\n+\n+std::unique_ptr<CameraMetadata> CameraCapabilities::requestTemplateManual() const\n+{\n+\tstd::unique_ptr<CameraMetadata> manualTemplate = requestTemplatePreview();\n+\tif (!manualTemplate)\n+\t\treturn nullptr;\n+\n+\treturn manualTemplate;\n+}\ndiff --git a/src/android/camera_capabilities.h b/src/android/camera_capabilities.h\nindex e0c2786b..b9395544 100644\n--- a/src/android/camera_capabilities.h\n+++ b/src/android/camera_capabilities.h\n@@ -34,6 +34,8 @@ public:\n \n \tstd::unique_ptr<CameraMetadata> requestTemplatePreview() const;\n \tstd::unique_ptr<CameraMetadata> requestTemplateVideo() const;\n+\tstd::unique_ptr<CameraMetadata> requestTemplateStill() const;\n+\tstd::unique_ptr<CameraMetadata> requestTemplateManual() const;\n \n private:\n \tLIBCAMERA_DISABLE_COPY_AND_MOVE(CameraCapabilities)\ndiff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex 678cde23..692d0a5b 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -487,7 +487,7 @@ const camera_metadata_t *CameraDevice::constructDefaultRequestSettings(int type)\n \t\t * for the torch mode we currently do not support.\n \t\t */\n \t\tcaptureIntent = ANDROID_CONTROL_CAPTURE_INTENT_STILL_CAPTURE;\n-\t\trequestTemplate = capabilities_.requestTemplatePreview();\n+\t\trequestTemplate = capabilities_.requestTemplateStill();\n \t\tbreak;\n \tcase CAMERA3_TEMPLATE_VIDEO_RECORD:\n \t\tcaptureIntent = ANDROID_CONTROL_CAPTURE_INTENT_VIDEO_RECORD;\n@@ -497,9 +497,12 @@ const camera_metadata_t *CameraDevice::constructDefaultRequestSettings(int type)\n \t\tcaptureIntent = ANDROID_CONTROL_CAPTURE_INTENT_VIDEO_SNAPSHOT;\n \t\trequestTemplate = capabilities_.requestTemplateVideo();\n \t\tbreak;\n+\tcase CAMERA3_TEMPLATE_MANUAL:\n+\t\tcaptureIntent = ANDROID_CONTROL_CAPTURE_INTENT_MANUAL;\n+\t\trequestTemplate = capabilities_.requestTemplateManual();\n+\t\tbreak;\n \t/* \\todo Implement templates generation for the remaining use cases. */\n \tcase CAMERA3_TEMPLATE_ZERO_SHUTTER_LAG:\n-\tcase CAMERA3_TEMPLATE_MANUAL:\n \tdefault:\n \t\tLOG(HAL, Error) << \"Unsupported template request type: \" << type;\n \t\treturn nullptr;\n", "prefixes": [ "libcamera-devel", "v5", "8/9" ] }