Patch Detail
Show a patch.
GET /api/1.1/patches/13043/?format=api
{ "id": 13043, "url": "https://patchwork.libcamera.org/api/1.1/patches/13043/?format=api", "web_url": "https://patchwork.libcamera.org/patch/13043/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210719143442.1328281-1-vedantparanjape160201@gmail.com>", "date": "2021-07-19T14:34:42", "name": "[libcamera-devel,v3] gstreamer: Store group_id in GstLibcameraSrcState", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "69d9158de299c17bd8841157470f2fa07c399dd8", "submitter": { "id": 85, "url": "https://patchwork.libcamera.org/api/1.1/people/85/?format=api", "name": "Vedant Paranjape", "email": "vedantparanjape160201@gmail.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/13043/mbox/", "series": [ { "id": 2255, "url": "https://patchwork.libcamera.org/api/1.1/series/2255/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2255", "date": "2021-07-19T14:34:42", "name": "[libcamera-devel,v3] gstreamer: Store group_id in GstLibcameraSrcState", "version": 3, "mbox": "https://patchwork.libcamera.org/series/2255/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/13043/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/13043/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A361FC0109\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 19 Jul 2021 14:35:08 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BEDB16853C;\n\tMon, 19 Jul 2021 16:35:07 +0200 (CEST)", "from mail-pf1-x435.google.com (mail-pf1-x435.google.com\n\t[IPv6:2607:f8b0:4864:20::435])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E6C1C6851F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 19 Jul 2021 16:35:05 +0200 (CEST)", "by mail-pf1-x435.google.com with SMTP id p36so16633104pfw.11\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 19 Jul 2021 07:35:05 -0700 (PDT)", "from localhost.localdomain ([1.186.166.226])\n\tby smtp.googlemail.com with ESMTPSA id\n\tce15sm17262691pjb.3.2021.07.19.07.35.02\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 19 Jul 2021 07:35:03 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"iDV/Sy4z\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=VPF5JYauVk6bCLhEzJm7QdoiutNZyZgZSTcsTTk4/Uc=;\n\tb=iDV/Sy4zv+xpcoM671yjqZjJZChZzhGsqGuBIpqND9ucr6+6TVRo4slup5gj9HeT1f\n\tS6xAz7pAG+11Djop/OZ41CoUZR/WdfCCiYILlNc+e3J5bJw2n/uLx9l28dY9VCbs6k5w\n\tVHz7bbQWQuSryyeOYI+Lu3LG/8PROG6oaeq/xnDRyybfzbC/y/obf/DT3DPBCS/FRBjb\n\tyrwpoFRK+BUkQ3crm2xl42Q7HfB5uXiJaihZPxXp6m5W6080fDdVJC7Ht0i4oL69V1kE\n\th7GVXEYVIcnRf+IBWXH+p0vrLkXtlJmbxNzJkUdQ2pmHzI+0s8K4iw8/rjlgYvY+KTPP\n\tHgWg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=VPF5JYauVk6bCLhEzJm7QdoiutNZyZgZSTcsTTk4/Uc=;\n\tb=awedCBCj+eNgRc3MsSRSuGtnoffkVOb8Gv+nu5imHNN/0VxoVj6WGHlnl8ToswpZCc\n\t9g734qs8OQxKGFpvaIgVc2OpGxgzneH+1JBfEP1t62GnfxtRyspV22H1PrCaub1bm0va\n\tBRdZ6HhoVbOfDWe1J5aVbtEk0amX7h4Db/7L53UA3qMVJRi9QVq8wZDyhN+jyUbwcvqD\n\t3IRvRXOFm3h8gxlQKkZmhN4Mkp5dUUIkc9wMdyLzdsDAYoLl4D4BBdkqR2g5Fp5utKvq\n\tdzWko4QF+A1BIdOAUuHx+fvTbYpl5e5qctFfMCIQIEhVnTA+CWQOxIPszb9N7gSPi3xm\n\tBo/A==", "X-Gm-Message-State": "AOAM531hmefEMh0TmNku1IZriymvKVGggZ55R4GekOuZ+wTBqkb4TdkK\n\tKbFpYjcSFR5t435If47xWKQkWUfhtfUAWT4x", "X-Google-Smtp-Source": "ABdhPJwg/g/rFjQQFvyLYhntT/8YETjuR460sV+Bgss4S7nrHeg4TU1O/bdxxWqy1W7+nFkNkk6Hrg==", "X-Received": "by 2002:a05:6a00:1822:b029:32b:cf78:405 with SMTP id\n\ty34-20020a056a001822b029032bcf780405mr26348881pfa.80.1626705303766; \n\tMon, 19 Jul 2021 07:35:03 -0700 (PDT)", "From": "Vedant Paranjape <vedantparanjape160201@gmail.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 19 Jul 2021 20:04:42 +0530", "Message-Id": "<20210719143442.1328281-1-vedantparanjape160201@gmail.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v3] gstreamer: Store group_id in\n\tGstLibcameraSrcState", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Cc": "Vedant Paranjape <vedantparanjape160201@gmail.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "This patch adds group_id in GstLibcameraSrcState, since group_id is\nsomething which should be same for all the pads, it can be reused\nlater.\n\nSigned-off-by: Vedant Paranjape <vedantparanjape160201@gmail.com>\n---\n src/gstreamer/gstlibcamerasrc.cpp | 7 ++++---\n 1 file changed, 4 insertions(+), 3 deletions(-)", "diff": "diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp\nindex ea53c2b5..37ddf78d 100644\n--- a/src/gstreamer/gstlibcamerasrc.cpp\n+++ b/src/gstreamer/gstlibcamerasrc.cpp\n@@ -113,6 +113,7 @@ struct GstLibcameraSrcState {\n \tstd::unique_ptr<CameraConfiguration> config_;\n \tstd::vector<GstPad *> srcpads_;\n \tstd::queue<std::unique_ptr<RequestWrap>> requests_;\n+\tguint group_id_;\n \n \tvoid requestCompleted(Request *request);\n };\n@@ -360,15 +361,14 @@ gst_libcamera_src_task_enter(GstTask *task, [[maybe_unused]] GThread *thread,\n \n \tGST_DEBUG_OBJECT(self, \"Streaming thread has started\");\n \n-\tguint group_id = gst_util_group_id_next();\n \tgint stream_id_num = 0;\n \tStreamRoles roles;\n \tfor (GstPad *srcpad : state->srcpads_) {\n \t\t/* Create stream-id and push stream-start. */\n-\t\tg_autofree gchar *stream_id_intermediate = g_strdup_printf(\"%i%i\", group_id, stream_id_num++);\n+\t\tg_autofree gchar *stream_id_intermediate = g_strdup_printf(\"%i%i\", state->group_id_, stream_id_num++);\n \t\tg_autofree gchar *stream_id = gst_pad_create_stream_id(srcpad, GST_ELEMENT(self), stream_id_intermediate);\n \t\tGstEvent *event = gst_event_new_stream_start(stream_id);\n-\t\tgst_event_set_group_id(event, group_id);\n+\t\tgst_event_set_group_id(event, state->group_id_);\n \t\tgst_pad_push_event(srcpad, event);\n \n \t\t/* Collect the streams roles for the next iteration. */\n@@ -636,6 +636,7 @@ gst_libcamera_src_init(GstLibcameraSrc *self)\n \n \tstate->srcpads_.push_back(gst_pad_new_from_template(templ, \"src\"));\n \tgst_element_add_pad(GST_ELEMENT(self), state->srcpads_[0]);\n+\tstate->group_id_ = gst_util_group_id_next();\n \n \t/* C-style friend. */\n \tstate->src_ = self;\n", "prefixes": [ "libcamera-devel", "v3" ] }