Patch Detail
Show a patch.
GET /api/1.1/patches/13035/?format=api
{ "id": 13035, "url": "https://patchwork.libcamera.org/api/1.1/patches/13035/?format=api", "web_url": "https://patchwork.libcamera.org/patch/13035/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210718064850.837873-1-vedantparanjape160201@gmail.com>", "date": "2021-07-18T06:48:50", "name": "[libcamera-devel,v1] gstreamer: Factor out _pad_push_stream_start from _task_enter", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "d1134b544b4375a3a68b15150fee95bdf253c19c", "submitter": { "id": 85, "url": "https://patchwork.libcamera.org/api/1.1/people/85/?format=api", "name": "Vedant Paranjape", "email": "vedantparanjape160201@gmail.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/13035/mbox/", "series": [ { "id": 2250, "url": "https://patchwork.libcamera.org/api/1.1/series/2250/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2250", "date": "2021-07-18T06:48:50", "name": "[libcamera-devel,v1] gstreamer: Factor out _pad_push_stream_start from _task_enter", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2250/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/13035/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/13035/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F2EADC0109\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSun, 18 Jul 2021 06:49:26 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 21DE06851F;\n\tSun, 18 Jul 2021 08:49:26 +0200 (CEST)", "from mail-pl1-x629.google.com (mail-pl1-x629.google.com\n\t[IPv6:2607:f8b0:4864:20::629])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 903B460279\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 18 Jul 2021 08:49:11 +0200 (CEST)", "by mail-pl1-x629.google.com with SMTP id j3so7810476plx.7\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 17 Jul 2021 23:49:11 -0700 (PDT)", "from localhost.localdomain ([1.186.166.94])\n\tby smtp.googlemail.com with ESMTPSA id\n\tq14sm15002216pff.209.2021.07.17.23.49.07\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSat, 17 Jul 2021 23:49:09 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"ST6k7wHo\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=z4aoEY0Tuh1KDrUqCLumfu9K7nlW7O9ok8mQITHXYN4=;\n\tb=ST6k7wHoQmiCMIl/g+//6YOgSw6uS5BnRdsvfCaYHTbuNvrjbGI3XPTM721cc5OkkJ\n\ttf3bbbw4NHL111HPVzHfWgNWzdtFmvk2Uc3wKDOFPJdDVZA9bMAfTDqVp7lYUQX6Dkg5\n\tQwBHCKVOXZOnLlwfXkGJ0ce8iXSWMcS8Q3Wuw8/w1ZhS4clR+trH5CO6DRyym8fr3dZI\n\tMORJbEyQ3CstNxdbqHnmEcl89lQbS1MLl1qG3Osp5c1E1LhwiSuNu3tr9dFBRFCRBuJa\n\tGeo0kosmJ3G8tI9Y5yKwKGFRKAgMmQ86XAjuP394sGC/3XSwylu9bkgRSc3OjJPhWvfz\n\tRIVA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=z4aoEY0Tuh1KDrUqCLumfu9K7nlW7O9ok8mQITHXYN4=;\n\tb=JZAqD6WNvmI4aCFUSQXqG9zHIq+9nSDjVIPML5WWJXwN1/oSftm1M8T0nIGDBj2bCJ\n\t20FQc1sd8pSp8z5L+EKd7fdsJhNv3sUe+4Bte7Gv5ZANfr+TfEexrgJAcN1JQ4h2+TfU\n\tmJFpN2wNeYsWRB+22MLPg2yfeJka5VSy5gVuLQIEhlCzsYpoSQQyth3IKw7AKomvH9UP\n\tAe47woFnR/83YcHN9Nele+lTj6uOXg0Vbx3Vib7Loiz+C7BiVvT8SivhNdx04UROKe3g\n\tN4i+FaGD99A26bEZ8GkVUiPR2UJ9SIHSLVcQLSsg0YlMYa9J5sDrM+ujQa77OsikkHgF\n\tImhQ==", "X-Gm-Message-State": "AOAM533uVXk3W74keUFdyMIBX7s005lxpUAxgumoP8VR8mP4tLeZ6Bt4\n\to+gHz12HGMJLKdWN73+dNakrAJ3TGXverw==", "X-Google-Smtp-Source": "ABdhPJyT2C1iz98KeCREm9OxpOQtJb4cuLvssdEcTuGzqguFCwhk818VIXmkQFL//HacaJD/uEmYXw==", "X-Received": "by 2002:a17:902:6b42:b029:11d:a147:bb7b with SMTP id\n\tg2-20020a1709026b42b029011da147bb7bmr14624529plt.9.1626590949689; \n\tSat, 17 Jul 2021 23:49:09 -0700 (PDT)", "From": "Vedant Paranjape <vedantparanjape160201@gmail.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sun, 18 Jul 2021 12:18:50 +0530", "Message-Id": "<20210718064850.837873-1-vedantparanjape160201@gmail.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v1] gstreamer: Factor out\n\t_pad_push_stream_start from _task_enter", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Cc": "Vedant Paranjape <vedantparanjape160201@gmail.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "This patch creates gst_libcamera_pad_push_stream_start function to\ncreate stream id and to push the stream start. This is a non functional\nchange.\n\nSigned-off-by: Vedant Paranjape <vedantparanjape160201@gmail.com>\n---\n src/gstreamer/gstlibcamerapad.cpp | 13 +++++++++++++\n src/gstreamer/gstlibcamerapad.h | 2 ++\n src/gstreamer/gstlibcamerasrc.cpp | 7 +------\n 3 files changed, 16 insertions(+), 6 deletions(-)", "diff": "diff --git a/src/gstreamer/gstlibcamerapad.cpp b/src/gstreamer/gstlibcamerapad.cpp\nindex c00e81c8..6f889472 100644\n--- a/src/gstreamer/gstlibcamerapad.cpp\n+++ b/src/gstreamer/gstlibcamerapad.cpp\n@@ -155,6 +155,19 @@ gst_libcamera_pad_get_stream(GstPad *pad)\n \treturn nullptr;\n }\n \n+void\n+gst_libcamera_pad_push_stream_start(GstPad *pad, const guint group_id)\n+{\n+\tGstElement *element = gst_pad_get_parent_element(pad);\n+\tstatic gint stream_id_num = 0;\n+\n+\tg_autofree gchar *stream_id_intermediate = g_strdup_printf(\"%i%i\", group_id, stream_id_num++);\n+\tg_autofree gchar *stream_id = gst_pad_create_stream_id(pad, element, stream_id_intermediate);\n+\tGstEvent *event = gst_event_new_stream_start(stream_id);\n+\tgst_event_set_group_id(event, group_id);\n+\tgst_pad_push_event(pad, event);\n+}\n+\n void\n gst_libcamera_pad_queue_buffer(GstPad *pad, GstBuffer *buffer)\n {\ndiff --git a/src/gstreamer/gstlibcamerapad.h b/src/gstreamer/gstlibcamerapad.h\nindex 779f2d13..7693374f 100644\n--- a/src/gstreamer/gstlibcamerapad.h\n+++ b/src/gstreamer/gstlibcamerapad.h\n@@ -26,6 +26,8 @@ void gst_libcamera_pad_set_pool(GstPad *pad, GstLibcameraPool *pool);\n \n libcamera::Stream *gst_libcamera_pad_get_stream(GstPad *pad);\n \n+void gst_libcamera_pad_push_stream_start(GstPad *pad, const guint group_id);\n+\n void gst_libcamera_pad_queue_buffer(GstPad *pad, GstBuffer *buffer);\n \n GstFlowReturn gst_libcamera_pad_push_pending(GstPad *pad);\ndiff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp\nindex 79b0d867..f9ac50ef 100644\n--- a/src/gstreamer/gstlibcamerasrc.cpp\n+++ b/src/gstreamer/gstlibcamerasrc.cpp\n@@ -364,15 +364,10 @@ gst_libcamera_src_task_enter(GstTask *task, [[maybe_unused]] GThread *thread,\n \tif (state->group_id_ == 0) {\n \t\tstate->group_id_ = gst_util_group_id_next();\n \t}\n-\tgint stream_id_num = 0;\n \tStreamRoles roles;\n \tfor (GstPad *srcpad : state->srcpads_) {\n \t\t/* Create stream-id and push stream-start. */\n-\t\tg_autofree gchar *stream_id_intermediate = g_strdup_printf(\"%i%i\", state->group_id_, stream_id_num++);\n-\t\tg_autofree gchar *stream_id = gst_pad_create_stream_id(srcpad, GST_ELEMENT(self), stream_id_intermediate);\n-\t\tGstEvent *event = gst_event_new_stream_start(stream_id);\n-\t\tgst_event_set_group_id(event, state->group_id_);\n-\t\tgst_pad_push_event(srcpad, event);\n+\t\tgst_libcamera_pad_push_stream_start(srcpad, state->group_id_);\n \n \t\t/* Collect the streams roles for the next iteration. */\n \t\troles.push_back(gst_libcamera_pad_get_role(srcpad));\n", "prefixes": [ "libcamera-devel", "v1" ] }