Patch Detail
Show a patch.
GET /api/1.1/patches/12995/?format=api
{ "id": 12995, "url": "https://patchwork.libcamera.org/api/1.1/patches/12995/?format=api", "web_url": "https://patchwork.libcamera.org/patch/12995/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210715211459.19373-26-laurent.pinchart@ideasonboard.com>", "date": "2021-07-15T21:14:51", "name": "[libcamera-devel,v3,25/33] cam: Make CamApp::cameraName() static", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "d13f2866229a76dd60cccca28f6fa13fac1a9f61", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/12995/mbox/", "series": [ { "id": 2242, "url": "https://patchwork.libcamera.org/api/1.1/series/2242/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2242", "date": "2021-07-15T21:14:26", "name": "Multi-camera support in the cam application", "version": 3, "mbox": "https://patchwork.libcamera.org/series/2242/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/12995/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/12995/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 30DF1C322B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 15 Jul 2021 21:15:31 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C08A468540;\n\tThu, 15 Jul 2021 23:15:30 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 05C8568541\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 15 Jul 2021 23:15:13 +0200 (CEST)", "from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id ABF03340\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 15 Jul 2021 23:15:12 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"sorRQRqT\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1626383712;\n\tbh=jOy4SyKjUDyf+//EBxL2A6r7aABK3WzCl6iZMitMA/w=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=sorRQRqTF/7jw7zGS60mm4zhwvfT/rIV1jSy5uBxeJ8Azh/O0NPKFdClvnfWzAnrI\n\tj+UvE+G2+KWn18sK9qriBXUYJaWslHWs8q1dWcxsnO9aVmbLnXFk0rSwaxtj5v3vUZ\n\tQIinBbOGVdu3t5uJCm3CfV1l+mY5uqh2Utf8OJ1M=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 16 Jul 2021 00:14:51 +0300", "Message-Id": "<20210715211459.19373-26-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.31.1", "In-Reply-To": "<20210715211459.19373-1-laurent.pinchart@ideasonboard.com>", "References": "<20210715211459.19373-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v3 25/33] cam: Make CamApp::cameraName()\n\tstatic", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The CamApp::cameraName() doesn't need to access any member of the CamApp\nclass. Make it static. While at it, drop an unneeded const from the\nreturn value.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/cam/main.cpp | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/cam/main.cpp b/src/cam/main.cpp\nindex 19ed9837cf4f..03e62f305f24 100644\n--- a/src/cam/main.cpp\n+++ b/src/cam/main.cpp\n@@ -44,7 +44,7 @@ private:\n \tint infoConfiguration();\n \tint run();\n \n-\tstd::string const cameraName(const Camera *camera);\n+\tstatic std::string cameraName(const Camera *camera);\n \n \tstatic CamApp *app_;\n \tOptionsParser::Options options_;\n@@ -319,7 +319,7 @@ int CamApp::run()\n \treturn 0;\n }\n \n-std::string const CamApp::cameraName(const Camera *camera)\n+std::string CamApp::cameraName(const Camera *camera)\n {\n \tconst ControlList &props = camera->properties();\n \tbool addModel = true;\n", "prefixes": [ "libcamera-devel", "v3", "25/33" ] }