Patch Detail
Show a patch.
GET /api/1.1/patches/12986/?format=api
{ "id": 12986, "url": "https://patchwork.libcamera.org/api/1.1/patches/12986/?format=api", "web_url": "https://patchwork.libcamera.org/patch/12986/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210715211459.19373-15-laurent.pinchart@ideasonboard.com>", "date": "2021-07-15T21:14:40", "name": "[libcamera-devel,v3,14/33] cam: options: Fail parsing when non-option arguments are found", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "28d9ac522c406fac6b0d1f77b637b9ecae0ad9a2", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/12986/mbox/", "series": [ { "id": 2242, "url": "https://patchwork.libcamera.org/api/1.1/series/2242/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2242", "date": "2021-07-15T21:14:26", "name": "Multi-camera support in the cam application", "version": 3, "mbox": "https://patchwork.libcamera.org/series/2242/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/12986/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/12986/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 369FAC3227\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 15 Jul 2021 21:15:23 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4434A6059F;\n\tThu, 15 Jul 2021 23:15:20 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 653B468553\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 15 Jul 2021 23:15:09 +0200 (CEST)", "from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CE405340\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 15 Jul 2021 23:15:08 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"UaL6Jkas\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1626383709;\n\tbh=d/GKM8jX8FccS5quAQcvimkG/BOL4gq1kNDBoypOx4E=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=UaL6JkasM2xf0Of6W1EClrqRi3jLr2bG2YIF9JyMJukk0hir8KDUhOq/3/kmi5EDP\n\tRLrQprccLEPEQ+E4yw8OivQShkiPnzW3xKI9oJLIFUKHmox6Bp0j5jB+rmCwu31Zv2\n\tdCMzcwHz8kAsTV2tKprnpEoQSl+SbyBHDvlMXrxg=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 16 Jul 2021 00:14:40 +0300", "Message-Id": "<20210715211459.19373-15-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.31.1", "In-Reply-To": "<20210715211459.19373-1-laurent.pinchart@ideasonboard.com>", "References": "<20210715211459.19373-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v3 14/33] cam: options: Fail parsing when\n\tnon-option arguments are found", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The options parser currently ignores non-option arguments silently,\nwhich is confusing. It's a common error to run 'cam -c1 -C 10' and\nexpect only 10 frames to be captured. As the -C option takes an optional\nargument, the number 10 is interpreted as a non-option argument instead\nof the argument to the -C option.\n\nFail parsing with an appropriate message and print usage information\nwhen a non-option argument is found. The parser may be extended later to\naccept non-option arguments when the application has a use for them.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/cam/options.cpp | 7 +++++++\n 1 file changed, 7 insertions(+)", "diff": "diff --git a/src/cam/options.cpp b/src/cam/options.cpp\nindex 6e0d802cb986..33bc512e6571 100644\n--- a/src/cam/options.cpp\n+++ b/src/cam/options.cpp\n@@ -945,6 +945,13 @@ OptionsParser::Options OptionsParser::parse(int argc, char **argv)\n \t\t}\n \t}\n \n+\tif (optind < argc) {\n+\t\tstd::cerr << \"Invalid non-option argument '\" << argv[optind]\n+\t\t\t << \"'\" << std::endl;\n+\t\tusage();\n+\t\treturn options;\n+\t}\n+\n \toptions.valid_ = true;\n \treturn options;\n }\n", "prefixes": [ "libcamera-devel", "v3", "14/33" ] }