Patch Detail
Show a patch.
GET /api/1.1/patches/12982/?format=api
{ "id": 12982, "url": "https://patchwork.libcamera.org/api/1.1/patches/12982/?format=api", "web_url": "https://patchwork.libcamera.org/patch/12982/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210715211459.19373-12-laurent.pinchart@ideasonboard.com>", "date": "2021-07-15T21:14:37", "name": "[libcamera-devel,v3,11/33] cam: options: Add empty() function to OptionValue class", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "05984fe41df15e6358e5b941849a775f4352b045", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/12982/mbox/", "series": [ { "id": 2242, "url": "https://patchwork.libcamera.org/api/1.1/series/2242/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2242", "date": "2021-07-15T21:14:26", "name": "Multi-camera support in the cam application", "version": 3, "mbox": "https://patchwork.libcamera.org/series/2242/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/12982/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/12982/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F1B81C3227\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 15 Jul 2021 21:15:21 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DF8F168549;\n\tThu, 15 Jul 2021 23:15:16 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3961068549\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 15 Jul 2021 23:15:08 +0200 (CEST)", "from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C9D3D56B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 15 Jul 2021 23:15:07 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"rM93Dv/1\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1626383708;\n\tbh=+rgkfu9YI35jiQoxt5lY7KDJNUOCgq1UFoLMw+QYjoQ=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=rM93Dv/1A3IJHz/YI6ttrwrqG+pUFP7bmjvSJUjDWafy6iqkMhMQT8PCRT3n+6AeK\n\tGZsTFAn5xcDbXEAnQgccMi/KBj+NzL2bLnfzavj2qVQkTJSGLp4MKwiOJEJc2zt0YE\n\tkRRoTzk0FOh4FM4q4jL1XAwdHYb/WfKrghy5845o=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 16 Jul 2021 00:14:37 +0300", "Message-Id": "<20210715211459.19373-12-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.31.1", "In-Reply-To": "<20210715211459.19373-1-laurent.pinchart@ideasonboard.com>", "References": "<20210715211459.19373-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v3 11/33] cam: options: Add empty()\n\tfunction to OptionValue class", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add a convenience helper to check if an option value is empty, based on\nthe value type. This is useful as a shortcut syntax to check if an\noption has been set.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/cam/options.cpp | 7 +++++++\n src/cam/options.h | 1 +\n 2 files changed, 8 insertions(+)", "diff": "diff --git a/src/cam/options.cpp b/src/cam/options.cpp\nindex fda6d9764ac5..481ac189f115 100644\n--- a/src/cam/options.cpp\n+++ b/src/cam/options.cpp\n@@ -583,6 +583,13 @@ void OptionValue::addValue(const OptionValue &value)\n * \\return The value type\n */\n \n+/**\n+ * \\fn OptionValue::empty()\n+ * \\brief Check if the value is empty\n+ * \\return True if the value is empty (type set to ValueType::ValueNone), or\n+ * false otherwise\n+ */\n+\n /**\n * \\brief Cast the value to an int\n * \\return The option value as an int, or 0 if the value type isn't\ndiff --git a/src/cam/options.h b/src/cam/options.h\nindex 210e502a24e1..83c409ae4d28 100644\n--- a/src/cam/options.h\n+++ b/src/cam/options.h\n@@ -135,6 +135,7 @@ public:\n \tvoid addValue(const OptionValue &value);\n \n \tValueType type() const { return type_; }\n+\tbool empty() const { return type_ == ValueType::ValueNone; }\n \n \toperator int() const;\n \toperator std::string() const;\n", "prefixes": [ "libcamera-devel", "v3", "11/33" ] }