Patch Detail
Show a patch.
GET /api/1.1/patches/12975/?format=api
{ "id": 12975, "url": "https://patchwork.libcamera.org/api/1.1/patches/12975/?format=api", "web_url": "https://patchwork.libcamera.org/patch/12975/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210715211459.19373-5-laurent.pinchart@ideasonboard.com>", "date": "2021-07-15T21:14:30", "name": "[libcamera-devel,v3,04/33] cam: options: Move OptionValue class after OptionsParser", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "6e1b95da24f13bfe2df34a50d346a5217d8b398d", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/12975/mbox/", "series": [ { "id": 2242, "url": "https://patchwork.libcamera.org/api/1.1/series/2242/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2242", "date": "2021-07-15T21:14:26", "name": "Multi-camera support in the cam application", "version": 3, "mbox": "https://patchwork.libcamera.org/series/2242/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/12975/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/12975/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 81E1CC3226\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 15 Jul 2021 21:15:15 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C0E156855C;\n\tThu, 15 Jul 2021 23:15:11 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D898F68538\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 15 Jul 2021 23:15:05 +0200 (CEST)", "from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 710C7340\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 15 Jul 2021 23:15:05 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"OlU0AvsD\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1626383705;\n\tbh=u4NF1n4ch7rg4HLqz/5lzP6cCkpx25MmJyUbamz+650=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=OlU0AvsDRboXzZif4SbczzplryCq6PaeG6D5o+cWjGQXTbZPtOxJsrMFVQaTjH4nr\n\tYFR9d2mbB+KoBp3AJbK52o10bLeloAK0REe7UGsvxUsO+BBLJB/DcNDGBdmASqf8lf\n\tecNNq+nhc+5wXdFJ7n2mhzWEnyTA3jPyYNpz4ap4=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 16 Jul 2021 00:14:30 +0300", "Message-Id": "<20210715211459.19373-5-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.31.1", "In-Reply-To": "<20210715211459.19373-1-laurent.pinchart@ideasonboard.com>", "References": "<20210715211459.19373-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v3 04/33] cam: options: Move OptionValue\n\tclass after OptionsParser", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "To prepare for usage of the OptionsParser::Options class in OptionValue,\nmove the definition of the OptionValue class after OptionsParser. There\nis no functional change.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/cam/options.h | 54 +++++++++++++++++++++++------------------------\n 1 file changed, 27 insertions(+), 27 deletions(-)", "diff": "diff --git a/src/cam/options.h b/src/cam/options.h\nindex 688fe26011f8..a3b18bb6c4ea 100644\n--- a/src/cam/options.h\n+++ b/src/cam/options.h\n@@ -74,6 +74,33 @@ private:\n \tstd::map<std::string, Option> optionsMap_;\n };\n \n+class OptionsParser\n+{\n+public:\n+\tclass Options : public OptionsBase<int>\n+\t{\n+\t};\n+\n+\tOptionsParser();\n+\t~OptionsParser();\n+\n+\tbool addOption(int opt, OptionType type, const char *help,\n+\t\t const char *name = nullptr,\n+\t\t OptionArgument argument = ArgumentNone,\n+\t\t const char *argumentName = nullptr, bool array = false);\n+\tbool addOption(int opt, KeyValueParser *parser, const char *help,\n+\t\t const char *name = nullptr, bool array = false);\n+\n+\tOptions parse(int argc, char *argv[]);\n+\tvoid usage();\n+\n+private:\n+\tvoid parseValueError(const Option &option);\n+\n+\tstd::list<Option> options_;\n+\tstd::map<unsigned int, Option *> optionsMap_;\n+};\n+\n class OptionValue\n {\n public:\n@@ -113,31 +140,4 @@ private:\n \tstd::vector<OptionValue> array_;\n };\n \n-class OptionsParser\n-{\n-public:\n-\tclass Options : public OptionsBase<int>\n-\t{\n-\t};\n-\n-\tOptionsParser();\n-\t~OptionsParser();\n-\n-\tbool addOption(int opt, OptionType type, const char *help,\n-\t\t const char *name = nullptr,\n-\t\t OptionArgument argument = ArgumentNone,\n-\t\t const char *argumentName = nullptr, bool array = false);\n-\tbool addOption(int opt, KeyValueParser *parser, const char *help,\n-\t\t const char *name = nullptr, bool array = false);\n-\n-\tOptions parse(int argc, char *argv[]);\n-\tvoid usage();\n-\n-private:\n-\tvoid parseValueError(const Option &option);\n-\n-\tstd::list<Option> options_;\n-\tstd::map<unsigned int, Option *> optionsMap_;\n-};\n-\n #endif /* __CAM_OPTIONS_H__ */\n", "prefixes": [ "libcamera-devel", "v3", "04/33" ] }